From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [RFC PATCH 2/6] Squash-to: "mptcp: Add path manager interface"
Date: Wed, 12 Feb 2020 15:22:43 +0100 [thread overview]
Message-ID: <20200212142243.GL2991@breakpoint.cc> (raw)
In-Reply-To: d62fdfef647801bac3445fa4f210d4aacc0e5991.1581444137.git.pabeni@redhat.com
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
Paolo Abeni <pabeni(a)redhat.com> wrote:
> +struct mptcp_pm_data {
> + struct mptcp_addr_info local;
> + struct mptcp_addr_info remote;
> +
> + spinlock_t lock;
> +
> + bool addr_signal;
> + bool server_side;
> + bool fully_established;
> + enum mptcp_pm_status status;
> + u8 add_addr_signaled;
> + u8 add_addr_accepted;
Why are the first three bool and the rest u8?
We should probably avoid "bool" in structs.
Perhaps use foo:1 as most of net stack?
next reply other threads:[~2020-02-12 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 14:22 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-12 14:51 [MPTCP] Re: [RFC PATCH 2/6] Squash-to: "mptcp: Add path manager interface" Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212142243.GL2991@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.