From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Miroslav Rezanina <mrezanin@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] docs: Fix virtiofsd.1 location
Date: Wed, 12 Feb 2020 14:28:32 +0000 [thread overview]
Message-ID: <20200212142832.GC434563@redhat.com> (raw)
In-Reply-To: <CAFEAcA-F-F1C4si7OXNkMnzE+9DHXtNnvCYv1eTx-nEpb4_OZw@mail.gmail.com>
On Wed, Feb 12, 2020 at 02:18:19PM +0000, Peter Maydell wrote:
> On Wed, 12 Feb 2020 at 13:16, Miroslav Rezanina <mrezanin@redhat.com> wrote:
> >
> > Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man
> > page virtiofsd.1. Unfortunately, wrong file location is used as
> > source for install command. This cause installation of docs fail.
> >
> > Fixing wrong location so installation is successful.
> >
> > Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> I noticed this in review of v1 of the patch
> https://patchew.org/QEMU/20200127162514.56784-1-stefanha@redhat.com/
> but missed that it hadn't been fixed in v2/v3.
How come the mistake didn't break any of our CI ? Looks like it
should have failed due to non-existing source file
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-02-12 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1908428819.7192207.1581512184275.JavaMail.zimbra@redhat.com>
2020-02-12 13:16 ` [PATCH] docs: Fix virtiofsd.1 location Miroslav Rezanina
2020-02-12 14:18 ` Peter Maydell
2020-02-12 14:26 ` Dr. David Alan Gilbert
2020-02-12 14:28 ` Daniel P. Berrangé [this message]
2020-02-12 16:02 ` Peter Maydell
2020-02-12 16:51 ` Philippe Mathieu-Daudé
2020-02-12 17:51 ` Peter Maydell
2020-02-13 10:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212142832.GC434563@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mrezanin@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.