From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 46/62] x86/sev-es: Handle INVD Events Date: Wed, 12 Feb 2020 16:36:17 +0100 Message-ID: <20200212153617.GD22063@8bytes.org> References: <20200211135256.24617-47-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Andy Lutomirski Cc: Juergen Gross , Tom Lendacky , Thomas Hellstrom , Dave Hansen , Kees Cook , kvm@vger.kernel.org, Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Joerg Roedel , Andy Lutomirski , hpa@zytor.com, Dan Williams , Jiri Slaby List-Id: virtualization@lists.linuxfoundation.org T24gVHVlLCBGZWIgMTEsIDIwMjAgYXQgMDQ6MTI6MTlQTSAtMDgwMCwgQW5keSBMdXRvbWlyc2tp IHdyb3RlOgo+IAo+IAo+ID4gT24gRmViIDExLCAyMDIwLCBhdCA1OjUzIEFNLCBKb2VyZyBSb2Vk ZWwgPGpvcm9AOGJ5dGVzLm9yZz4gd3JvdGU6Cj4gPiAKPiA+IO+7v0Zyb206IFRvbSBMZW5kYWNr eSA8dGhvbWFzLmxlbmRhY2t5QGFtZC5jb20+Cj4gPiAKPiA+IEltcGxlbWVudCBhIGhhbmRsZXIg Zm9yICNWQyBleGNlcHRpb25zIGNhdXNlZCBieSBJTlZEIGluc3RydWN0aW9ucy4KPiAKPiBVaCwg d2hhdD8gIFN1cmVseSB0aGUgI1ZDIGNvZGUgY2FuIGhhdmUgYSBjYXRjaC1hbGwgT09QUyBwYXRo IGZvciB0aGluZ3MgbGlrZSB0aGlzLiBMaW51eCBzaG91bGQgbmV2ZXIgZXZlciBkbyBJTlZELgoK UmlnaHQsIGl0cyBoYXJkIHRvIGNvbWUgdXAgd2l0aCBhIHZhbGlkIHVzZS1jYXNlIGZvciBJTlZE IGluIHRoZSBMaW51eAprZXJuZWwuIEkgY2hhbmdlZCB0aGUgcGF0Y2ggdG8gbWFyayBJTlZEIGFz IHVuc3VwcG9ydGVkIGFuZCBwcmludCBhbgplcnJvciBtZXNzYWdlLgoKUmVnYXJkcywKCglKb2Vy ZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFs aXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlv bi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8v dmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6197EC3B186 for ; Wed, 12 Feb 2020 15:36:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4511D206ED for ; Wed, 12 Feb 2020 15:36:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728458AbgBLPgV (ORCPT ); Wed, 12 Feb 2020 10:36:21 -0500 Received: from 8bytes.org ([81.169.241.247]:54056 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727026AbgBLPgU (ORCPT ); Wed, 12 Feb 2020 10:36:20 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 56BB03D3; Wed, 12 Feb 2020 16:36:19 +0100 (CET) Date: Wed, 12 Feb 2020 16:36:17 +0100 From: Joerg Roedel To: Andy Lutomirski Cc: x86@kernel.org, hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Thomas Hellstrom , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, Joerg Roedel Subject: Re: [PATCH 46/62] x86/sev-es: Handle INVD Events Message-ID: <20200212153617.GD22063@8bytes.org> References: <20200211135256.24617-47-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Feb 11, 2020 at 04:12:19PM -0800, Andy Lutomirski wrote: > > > > On Feb 11, 2020, at 5:53 AM, Joerg Roedel wrote: > > > > From: Tom Lendacky > > > > Implement a handler for #VC exceptions caused by INVD instructions. > > Uh, what? Surely the #VC code can have a catch-all OOPS path for things like this. Linux should never ever do INVD. Right, its hard to come up with a valid use-case for INVD in the Linux kernel. I changed the patch to mark INVD as unsupported and print an error message. Regards, Joerg