From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext4: delete declaration for ext4_split_extent()
Date: Wed, 12 Feb 2020 09:02:36 -0800 [thread overview]
Message-ID: <20200212170236.GA6863@magnolia> (raw)
In-Reply-To: <20200212162141.22381-1-enwlinux@gmail.com>
On Wed, Feb 12, 2020 at 11:21:41AM -0500, Eric Whitney wrote:
> There are no forward references for ext4_split_extent() in extents.c,
> so delete its unnecessary declaration.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Looks good to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/ext4/extents.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 89aa9c7ae293..a5338a8da2ab 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -83,13 +83,6 @@ static void ext4_extent_block_csum_set(struct inode *inode,
> et->et_checksum = ext4_extent_block_csum(inode, eh);
> }
>
> -static int ext4_split_extent(handle_t *handle,
> - struct inode *inode,
> - struct ext4_ext_path **ppath,
> - struct ext4_map_blocks *map,
> - int split_flag,
> - int flags);
> -
> static int ext4_split_extent_at(handle_t *handle,
> struct inode *inode,
> struct ext4_ext_path **ppath,
> --
> 2.11.0
>
next prev parent reply other threads:[~2020-02-12 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 16:21 [PATCH] ext4: delete declaration for ext4_split_extent() Eric Whitney
2020-02-12 17:02 ` Darrick J. Wong [this message]
2020-03-05 21:28 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212170236.GA6863@magnolia \
--to=darrick.wong@oracle.com \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.