All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Keith Busch <keith.busch@wdc.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: Case-sensitive host NQN
Date: Wed, 12 Feb 2020 18:35:29 +0100	[thread overview]
Message-ID: <20200212173529.GA5648@lst.de> (raw)
In-Reply-To: <4973fdd4-8a6c-1218-8f82-5413d3fec37f@suse.de>

On Wed, Feb 12, 2020 at 01:58:26PM +0100, Hannes Reinecke wrote:
> Hi all,
> 
> I've stumbled across a slight weirdness for our handling of host NQNs.
> We do format them like
> 
> # cat /etc/nvme/hostnqn
> nqn.2014-08.org.nvmexpress:uuid:36343050-3834-584D-5138-33313030344E
> 
> as this is a UUID, one would expect that it's identical to
> 
> # cat /etc/nvme/hostnqn
> nqn.2014-08.org.nvmexpress:uuid:36343050-3834-584d-5138-33313030344e
> 
> (Note the lowercase letters).
> As it turns out, this is _not_ the case, causing the connection not to
> be established.
> 
> Which is slightly weird, and not what one would expect.
> The NVMe spec only has this vague statement
> "Upon entry NVM host software may process an NVMe qualified name..."
> so we would be spec-compatible when setting the fields to lowercase
> when reading the nqn.

Check section 7.9 of NVMe 1.4:

"NVMe hosts, controllers and NVM subsystems compare (e.g., for equality)
NVMe Qualified Names used by NVMe as binary strings without any text
processing or text comparison logic that is specific to the Unicode
character set or locale (e.g., case folding or conversion to lower case,
Unicode normalization)."

so no, they are case sensitive and the above is by design.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-02-12 17:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 12:58 Case-sensitive host NQN Hannes Reinecke
2020-02-12 17:35 ` Christoph Hellwig [this message]
2020-02-12 17:51   ` Hannes Reinecke
2020-02-12 17:55     ` Christoph Hellwig
2020-02-12 19:20       ` Sagi Grimberg
2020-02-13 15:38       ` Hannes Reinecke
2020-02-13 23:33         ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200212173529.GA5648@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=keith.busch@wdc.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.