From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71970C352A4 for ; Wed, 12 Feb 2020 19:21:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A12321569 for ; Wed, 12 Feb 2020 19:21:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dT8aLuaa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A12321569 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1xZt-0003SN-Ca for qemu-devel@archiver.kernel.org; Wed, 12 Feb 2020 14:21:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60366) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1xZ7-0002yr-Oj for qemu-devel@nongnu.org; Wed, 12 Feb 2020 14:20:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1xZ5-0005Ih-Io for qemu-devel@nongnu.org; Wed, 12 Feb 2020 14:20:52 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:49356 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j1xZ5-0005I4-AH for qemu-devel@nongnu.org; Wed, 12 Feb 2020 14:20:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581535250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s0lXdHMdVKA2lMjrl9KywbEwQU1cAXTI72xDOQukghM=; b=dT8aLuaaEvyPK2I5aZV5Ccao0JlAFlDbGvuCPoklJf+aI8gxH0kMTMGFpSxRDcINe1Vb/2 T3vZkLQuhPEcfsn1gEEIa8VJBevunpB57OKNK2/4MDrICJfYYKtFtHc0Cc80X4UxVICwap z1nWCoiajm5uujGlLgmJ2BozzQqAaF4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-iXHHlpguOIiyJaHHuuYTyA-1; Wed, 12 Feb 2020 14:20:47 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C23948017CC for ; Wed, 12 Feb 2020 19:20:46 +0000 (UTC) Received: from localhost (ovpn-126-54.rdu2.redhat.com [10.10.126.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 881D15C10D; Wed, 12 Feb 2020 19:20:46 +0000 (UTC) Date: Wed, 12 Feb 2020 14:20:45 -0500 From: Eduardo Habkost To: Paolo Bonzini Subject: Re: [PATCH] target/i386: enable monitor and ucode revision with -cpu max Message-ID: <20200212192045.GD30675@habkost.net> References: <1581521009-44121-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 In-Reply-To: <1581521009-44121-1-git-send-email-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: iXHHlpguOIiyJaHHuuYTyA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Feb 12, 2020 at 04:23:29PM +0100, Paolo Bonzini wrote: > These two features were incorrectly tied to host_cpuid_required rather th= an > cpu->max_features. As a result, -cpu max was not enabling either MONITOR > features or ucode revision. >=20 > Signed-off-by: Paolo Bonzini Reviewed-by: Eduardo Habkost --=20 Eduardo