From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B7F7C352A4 for ; Wed, 12 Feb 2020 22:47:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E6A620848 for ; Wed, 12 Feb 2020 22:47:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JrdfQj6l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PFFtJaHK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E6A620848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vDjYg6y8tDKt3IU+YEwiI2vBrPcfdia83UY/laXr/bI=; b=JrdfQj6lNRk2iN cWPyoKxVfypFBwYo5Wo8pOHjC8kzoVLnA3jccTpxFXkrYnPILygMkrInB7N7ERGjMCSaQbGxJ9SF2 HrinRXf91LDyQnl/65kn+AyWbaL50xj9XIWmNXt/zCG/tlc6KbW0L11vAWuvic5Yl/MRv5XgAdAIZ roLEB/7Pbj3qMJ+q4PXl48RXjfcbAH6TTz92oR4eFzZMCuj65hq+LbExWwYRRNWCfzdP66i5X5VRL 6x0H4TAvbkNRivuHUbh5bpCF0fgJKPBWGNJQ+T4n5besMgh8uy/pK24f2UMiEhiO+rGfrNEzdEX6N mfytG3seXYWXZjHe6V4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j20mb-0001z7-M6; Wed, 12 Feb 2020 22:47:01 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j20mX-0001y1-NG for linux-arm-kernel@lists.infradead.org; Wed, 12 Feb 2020 22:46:59 +0000 Received: by mail-lj1-x244.google.com with SMTP id q8so4254812ljj.11 for ; Wed, 12 Feb 2020 14:46:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jrYNxcmAESHKexGAddHOv9wtAKXJzgWh89e239PGRQo=; b=PFFtJaHKIrNlUKS6NsRZWetgbbjhBlkI0g7tnl2WGU5kaUqi+zNun/iNdoK/DEDDiS HNkQw6hvXdwZihxbQefigPoLmceiAnmLwudOExlfolrXpKRtXYlySM+UthcT1qsmvcW/ zbuCIaL+5o+Ap8LUBQHJ5+Xp+LEU2psM35r/B68UVaY+CMkXphIpRo3a3FgszEnO2dsf yWVpHOk5hKgOE+XnVzmh4Bv26YqiKa6cn6T0wDFLu6ZUnh5lg9aVjSNs/Ic7RI4Mpj9I Izlj168dzT7UUt+SpupM16uiM260AIE494w59HZJZTa6fTgWRVmatKFAYvMqLwd/2GKr duBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jrYNxcmAESHKexGAddHOv9wtAKXJzgWh89e239PGRQo=; b=Hgvm0C3EMv7HfybTxlFYvyVZ1uNP55BKthmBJuqciuiAM0MAUlIWAkk9+WXeiALhJc vwBytWaHaAHCWTSAwJHXplgv+h2dTqgIljcR5rjU8Yc8nJfuO7ClKb3bC89fC/OMt2ac ff6WvjldwleNugKH65H98DgmpLLSuDacYmBUCTS1kKaoLjSGGeNXsuEfZs4sVRbZUjlu Lm4CMdDCySUFZWsvuVrg84OuqbnBcZpQOfGsL7OPtq55boEPXwoXO6Hq1D+i9YrLEBCt X/YAnUEpYdljxp/gdy0OgoQYUqPArVRRy0qsQdDf9cmG7+1n2G1sEP3XRni4sO25zpIy B4ew== X-Gm-Message-State: APjAAAU0D8wvE5gaMB+BfrzHuGHL2i3YUkiYMJOGrwt1q7sUgNYWnZfZ Hw2a+XhDISJ6qHjqGBn3Qk4= X-Google-Smtp-Source: APXvYqybqDLRJg2IrAK1fX24sksSPwXxUp90d3598YjdvkPi0K1jiArVzSr4wzrM3vq8gpEnprObzw== X-Received: by 2002:a2e:7818:: with SMTP id t24mr8865749ljc.195.1581547615958; Wed, 12 Feb 2020 14:46:55 -0800 (PST) Received: from kedthinkpad ([5.20.204.163]) by smtp.gmail.com with ESMTPSA id v7sm257086ljd.12.2020.02.12.14.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 14:46:55 -0800 (PST) Date: Thu, 13 Feb 2020 00:46:53 +0200 From: Andrey Lebedev To: Maxime Ripard Subject: Re: [PATCH 1/1] Support LVDS output on Allwinner A20 Message-ID: <20200212224653.GA19494@kedthinkpad> References: <20200210195633.GA21832@kedthinkpad> <20200211072004.46tbqixn5ftilxae@gilmour.lan> <20200211204828.GA4361@kedthinkpad> <20200212125345.j6e3txfjqekuxh2s@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200212125345.j6e3txfjqekuxh2s@gilmour.lan> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200212_144657_782422_BEE92D2D X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, wens@csie.org, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 12, 2020 at 01:53:45PM +0100, Maxime Ripard wrote: > > > Side question, this will need some DT changes too, right? > > > > Hm, I agree. I think it would be reasonable to include LVDS0/1 pins > > That, but most importantly, the reset and clocks for the LVDS > block. Also from looking at it, I'm not entirely sure that the TCON1 > has a LVDS output I also have impression that LVDS is only supported on TCON0, but that's mostly from this comment in sun4i_lvds.c: /* The LVDS encoder can only work with the TCON channel 0 */ > do you have a board when you have been able to test it? Yes, I have the hardware (Cubieboard 2) at hand, but I cannot change the any physical connections on it. FWIW, it is https://openvario.org, the device we are (painfully) trying to upgrade from old kernel-3.4 with proprietary mali drivers to contemporary software. > > and sample (but disabled) lvds panel, > > That's good for the sake of the example, but it shouldn't be in the > same patch, it won't be merged. I jave just submitted version 2 of the patches - set of 2 patches this time. Addressed your comments, please take a look. -- Andrey Lebedev aka -.- . -.. -.. . .-. Software engineer Homepage: http://lebedev.lt/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA277C2BA83 for ; Thu, 13 Feb 2020 08:13:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C190E20848 for ; Thu, 13 Feb 2020 08:13:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PFFtJaHK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C190E20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C53E89190; Thu, 13 Feb 2020 08:12:54 +0000 (UTC) Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id A081B6E125 for ; Wed, 12 Feb 2020 22:46:57 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id x14so4248500ljd.13 for ; Wed, 12 Feb 2020 14:46:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jrYNxcmAESHKexGAddHOv9wtAKXJzgWh89e239PGRQo=; b=PFFtJaHKIrNlUKS6NsRZWetgbbjhBlkI0g7tnl2WGU5kaUqi+zNun/iNdoK/DEDDiS HNkQw6hvXdwZihxbQefigPoLmceiAnmLwudOExlfolrXpKRtXYlySM+UthcT1qsmvcW/ zbuCIaL+5o+Ap8LUBQHJ5+Xp+LEU2psM35r/B68UVaY+CMkXphIpRo3a3FgszEnO2dsf yWVpHOk5hKgOE+XnVzmh4Bv26YqiKa6cn6T0wDFLu6ZUnh5lg9aVjSNs/Ic7RI4Mpj9I Izlj168dzT7UUt+SpupM16uiM260AIE494w59HZJZTa6fTgWRVmatKFAYvMqLwd/2GKr duBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jrYNxcmAESHKexGAddHOv9wtAKXJzgWh89e239PGRQo=; b=sYImI+RB8dQ0WS0UQkKiaQdnaTJd8CWbfvhvZIJQr/mSoQhe8Gpr5e8mvk3ePrp6uU 3+F8s5qVx26ACMGYQ01rAAfdMTjcfga6qQLT8rFDbnm0azse47aHM6eBfg/E+1cQAM0I rNlWSLQvPuDHkkuAifqt2SLukpAnTPkwzQ1ADh4XL7LMfd9rrFX53xrNGwZqlpT6vt6o JnO3SW+nmJ4TviQxBggmTSARA53u3bmvyVHu9gwimdT8NWRnEuwHIiN4BneprjgcqtP/ bx318+R+Yk3JQbE6WcLLwJaEweJyvofl7XJ9DKmoiiO74fp0gYU8uIgL2PLHgoLynj7E nhqg== X-Gm-Message-State: APjAAAWa+/S37Y6MARGl3M4YkmToiNlLgKRpn0vL/CNDcvT7Pt7LlQAU N0m5lA6vVGfMS+mQn571C+c= X-Google-Smtp-Source: APXvYqybqDLRJg2IrAK1fX24sksSPwXxUp90d3598YjdvkPi0K1jiArVzSr4wzrM3vq8gpEnprObzw== X-Received: by 2002:a2e:7818:: with SMTP id t24mr8865749ljc.195.1581547615958; Wed, 12 Feb 2020 14:46:55 -0800 (PST) Received: from kedthinkpad ([5.20.204.163]) by smtp.gmail.com with ESMTPSA id v7sm257086ljd.12.2020.02.12.14.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 14:46:55 -0800 (PST) Date: Thu, 13 Feb 2020 00:46:53 +0200 From: Andrey Lebedev To: Maxime Ripard Subject: Re: [PATCH 1/1] Support LVDS output on Allwinner A20 Message-ID: <20200212224653.GA19494@kedthinkpad> References: <20200210195633.GA21832@kedthinkpad> <20200211072004.46tbqixn5ftilxae@gilmour.lan> <20200211204828.GA4361@kedthinkpad> <20200212125345.j6e3txfjqekuxh2s@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200212125345.j6e3txfjqekuxh2s@gilmour.lan> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Thu, 13 Feb 2020 08:12:52 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, wens@csie.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Feb 12, 2020 at 01:53:45PM +0100, Maxime Ripard wrote: > > > Side question, this will need some DT changes too, right? > > > > Hm, I agree. I think it would be reasonable to include LVDS0/1 pins > > That, but most importantly, the reset and clocks for the LVDS > block. Also from looking at it, I'm not entirely sure that the TCON1 > has a LVDS output I also have impression that LVDS is only supported on TCON0, but that's mostly from this comment in sun4i_lvds.c: /* The LVDS encoder can only work with the TCON channel 0 */ > do you have a board when you have been able to test it? Yes, I have the hardware (Cubieboard 2) at hand, but I cannot change the any physical connections on it. FWIW, it is https://openvario.org, the device we are (painfully) trying to upgrade from old kernel-3.4 with proprietary mali drivers to contemporary software. > > and sample (but disabled) lvds panel, > > That's good for the sake of the example, but it shouldn't be in the > same patch, it won't be merged. I jave just submitted version 2 of the patches - set of 2 patches this time. Addressed your comments, please take a look. -- Andrey Lebedev aka -.- . -.. -.. . .-. Software engineer Homepage: http://lebedev.lt/ _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6EA1C352A4 for ; Wed, 12 Feb 2020 22:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98D6320848 for ; Wed, 12 Feb 2020 22:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PFFtJaHK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729186AbgBLWq6 (ORCPT ); Wed, 12 Feb 2020 17:46:58 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:42052 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727692AbgBLWq6 (ORCPT ); Wed, 12 Feb 2020 17:46:58 -0500 Received: by mail-lj1-f193.google.com with SMTP id d10so4277509ljl.9 for ; Wed, 12 Feb 2020 14:46:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jrYNxcmAESHKexGAddHOv9wtAKXJzgWh89e239PGRQo=; b=PFFtJaHKIrNlUKS6NsRZWetgbbjhBlkI0g7tnl2WGU5kaUqi+zNun/iNdoK/DEDDiS HNkQw6hvXdwZihxbQefigPoLmceiAnmLwudOExlfolrXpKRtXYlySM+UthcT1qsmvcW/ zbuCIaL+5o+Ap8LUBQHJ5+Xp+LEU2psM35r/B68UVaY+CMkXphIpRo3a3FgszEnO2dsf yWVpHOk5hKgOE+XnVzmh4Bv26YqiKa6cn6T0wDFLu6ZUnh5lg9aVjSNs/Ic7RI4Mpj9I Izlj168dzT7UUt+SpupM16uiM260AIE494w59HZJZTa6fTgWRVmatKFAYvMqLwd/2GKr duBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jrYNxcmAESHKexGAddHOv9wtAKXJzgWh89e239PGRQo=; b=skLPBi6Bho1ucwtwXUgdZ5/a2MR8xFd26DjUaoeTMDOHZB0lLbsr4z1Oz07ZrcMPwX BMckSiVKxvboV7DoHeMb+PT1lnyoo8L4LbKWyyxAFDcPOvlPuNGG0bIcGrqPY95jysoT tLWolY6ENN2ziv+j6g13oEiMWOsOLm4/AA5rkfKIR3EJaltqVuQ+Bnt7N+pgLYvsSSeT 2mYkBvYfsxrFVaXeeFR5IL8A2PGXf3ISx635Fxg3pR6L5h2iQReyLRzfQJRhd6Eq2bix d+rFmITtAPKwDuZQJYwXn7TKjFthdA3hmo5dlQThAt1omnBVQyO6IMqp9dZvmNsfALK2 MkEQ== X-Gm-Message-State: APjAAAWnPRuDXQoxtlS0o+mxw1tLLEuMGVjll2mu9esxE9nCUy+mMAg/ 225S7sxXmcAVOusyyI3O0KM= X-Google-Smtp-Source: APXvYqybqDLRJg2IrAK1fX24sksSPwXxUp90d3598YjdvkPi0K1jiArVzSr4wzrM3vq8gpEnprObzw== X-Received: by 2002:a2e:7818:: with SMTP id t24mr8865749ljc.195.1581547615958; Wed, 12 Feb 2020 14:46:55 -0800 (PST) Received: from kedthinkpad ([5.20.204.163]) by smtp.gmail.com with ESMTPSA id v7sm257086ljd.12.2020.02.12.14.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 14:46:55 -0800 (PST) Date: Thu, 13 Feb 2020 00:46:53 +0200 From: Andrey Lebedev To: Maxime Ripard Cc: wens@csie.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Support LVDS output on Allwinner A20 Message-ID: <20200212224653.GA19494@kedthinkpad> References: <20200210195633.GA21832@kedthinkpad> <20200211072004.46tbqixn5ftilxae@gilmour.lan> <20200211204828.GA4361@kedthinkpad> <20200212125345.j6e3txfjqekuxh2s@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212125345.j6e3txfjqekuxh2s@gilmour.lan> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12, 2020 at 01:53:45PM +0100, Maxime Ripard wrote: > > > Side question, this will need some DT changes too, right? > > > > Hm, I agree. I think it would be reasonable to include LVDS0/1 pins > > That, but most importantly, the reset and clocks for the LVDS > block. Also from looking at it, I'm not entirely sure that the TCON1 > has a LVDS output I also have impression that LVDS is only supported on TCON0, but that's mostly from this comment in sun4i_lvds.c: /* The LVDS encoder can only work with the TCON channel 0 */ > do you have a board when you have been able to test it? Yes, I have the hardware (Cubieboard 2) at hand, but I cannot change the any physical connections on it. FWIW, it is https://openvario.org, the device we are (painfully) trying to upgrade from old kernel-3.4 with proprietary mali drivers to contemporary software. > > and sample (but disabled) lvds panel, > > That's good for the sake of the example, but it shouldn't be in the > same patch, it won't be merged. I jave just submitted version 2 of the patches - set of 2 patches this time. Addressed your comments, please take a look. -- Andrey Lebedev aka -.- . -.. -.. . .-. Software engineer Homepage: http://lebedev.lt/