From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2EI9-0005cE-9J for linux-um@lists.infradead.org; Thu, 13 Feb 2020 13:12:31 +0000 Received: by mail-wm1-f71.google.com with SMTP id d4so2318961wmd.7 for ; Thu, 13 Feb 2020 05:12:16 -0800 (PST) Date: Thu, 13 Feb 2020 08:12:11 -0500 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso Message-ID: <20200213081154-mutt-send-email-mst@kernel.org> References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> <54692f06-f687-8bd3-7a1b-3dac3e79110b@cambridgegreys.com> MIME-Version: 1.0 In-Reply-To: <54692f06-f687-8bd3-7a1b-3dac3e79110b@cambridgegreys.com> Content-Disposition: inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Anton Ivanov Cc: netdev@vger.kernel.org, Jason Wang , linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org T24gVGh1LCBGZWIgMTMsIDIwMjAgYXQgMTE6MTI6NDVBTSArMDAwMCwgQW50b24gSXZhbm92IHdy b3RlOgo+IAo+IAo+IE9uIDEzLzAyLzIwMjAgMTA6MDAsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90 ZToKPiA+IE9uIFdlZCwgRmViIDEyLCAyMDIwIGF0IDA1OjM4OjA5UE0gKzAwMDAsIEFudG9uIEl2 YW5vdiB3cm90ZToKPiA+ID4gCj4gPiA+IAo+ID4gPiBPbiAxMS8wMi8yMDIwIDEwOjM3LCBNaWNo YWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gPiA+ID4gT24gVHVlLCBGZWIgMTEsIDIwMjAgYXQgMDc6 NDI6MzdBTSArMDAwMCwgQW50b24gSXZhbm92IHdyb3RlOgo+ID4gPiA+ID4gT24gMTEvMDIvMjAy MCAwMjo1MSwgSmFzb24gV2FuZyB3cm90ZToKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IE9uIDIw MjAvMi8xMSDkuIrljYgxMjo1NSwgQW50b24gSXZhbm92IHdyb3RlOgo+ID4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IE9uIDA5LzEyLzIwMTkgMTA6NDgsIGFudG9uLml2 YW5vdkBjYW1icmlkZ2VncmV5cy5jb20gd3JvdGU6Cj4gPiA+ID4gPiA+ID4gPiBGcm9tOiBBbnRv biBJdmFub3YgPGFudG9uLml2YW5vdkBjYW1icmlkZ2VncmV5cy5jb20+Cj4gPiA+ID4gPiA+ID4g PiAKPiA+ID4gPiA+ID4gPiA+IFNvbWUgb2YgdGhlIGZyYW1lcyBtYXJrZWQgYXMgR1NPIHdoaWNo IGFycml2ZSBhdAo+ID4gPiA+ID4gPiA+ID4gdmlydGlvX25ldF9oZHJfZnJvbV9za2IoKSBoYXZl IG5vIEdTT19UWVBFLCBubwo+ID4gPiA+ID4gPiA+ID4gZnJhZ21lbnRzIChkYXRhX2xlbiA9IDAp IGFuZCBsZW5ndGggc2lnbmlmaWNhbnRseSBzaG9ydGVyCj4gPiA+ID4gPiA+ID4gPiB0aGFuIHRo ZSBNVFUgKDc1MiBpbiBteSBleHBlcmltZW50cykuCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ ID4gPiA+IFRoaXMgaXMgb2JzZXJ2ZWQgb24gcmF3IHNvY2tldHMgcmVhZGluZyBvZmYgdkV0aCBp bnRlcmZhY2VzCj4gPiA+ID4gPiA+ID4gPiBpbiBhbGwgNC54IGFuZCA1Lngga2VybmVscyBJIHRl c3RlZC4KPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gVGhlc2UgZnJhbWVzIGFyZSBy ZXBvcnRlZCBhcyBpbnZhbGlkIHdoaWxlIHRoZXkgYXJlIGluIGZhY3QKPiA+ID4gPiA+ID4gPiA+ IGdzby1sZXNzIGZyYW1lcy4KPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gVGhpcyBw YXRjaCBtYXJrcyB0aGUgdm5ldCBoZWFkZXIgYXMgbm8tR1NPIGZvciB0aGVtIGluc3RlYWQKPiA+ ID4gPiA+ID4gPiA+IG9mIHJlcG9ydGluZyBpdCBhcyBpbnZhbGlkLgo+ID4gPiA+ID4gPiA+ID4g Cj4gPiA+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBBbnRvbiBJdmFub3YgPGFudG9uLml2YW5v dkBjYW1icmlkZ2VncmV5cy5jb20+Cj4gPiA+ID4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ID4gPiA+ ICAgwqAgaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmggfCA4ICsrKysrKy0tCj4gPiA+ID4gPiA+ ID4gPiAgIMKgIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p Cj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xp bnV4L3ZpcnRpb19uZXQuaCBiL2luY2x1ZGUvbGludXgvdmlydGlvX25ldC5oCj4gPiA+ID4gPiA+ ID4gPiBpbmRleCAwZDFmZTkyOTdhYzYuLmQ5MGQ1Y2ZmMWI5YSAxMDA2NDQKPiA+ID4gPiA+ID4g PiA+IC0tLSBhL2luY2x1ZGUvbGludXgvdmlydGlvX25ldC5oCj4gPiA+ID4gPiA+ID4gPiArKysg Yi9pbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaAo+ID4gPiA+ID4gPiA+ID4gQEAgLTExMiw4ICsx MTIsMTIgQEAgc3RhdGljIGlubGluZSBpbnQKPiA+ID4gPiA+ID4gPiA+IHZpcnRpb19uZXRfaGRy X2Zyb21fc2tiKGNvbnN0IHN0cnVjdCBza19idWZmICpza2IsCj4gPiA+ID4gPiA+ID4gPiAgIMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGhkci0+Z3NvX3R5cGUgPSBWSVJUSU9fTkVUX0hEUl9H U09fVENQVjQ7Cj4gPiA+ID4gPiA+ID4gPiAgIMKgwqDCoMKgwqDCoMKgwqDCoCBlbHNlIGlmIChz aW5mby0+Z3NvX3R5cGUgJiBTS0JfR1NPX1RDUFY2KQo+ID4gPiA+ID4gPiA+ID4gICDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RD UFY2Owo+ID4gPiA+ID4gPiA+ID4gLcKgwqDCoMKgwqDCoMKgIGVsc2UKPiA+ID4gPiA+ID4gPiA+ IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+ID4gPiA+ID4gPiA+ID4g K8KgwqDCoMKgwqDCoMKgIGVsc2Ugewo+ID4gPiA+ID4gPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqAgaWYgKHNrYi0+ZGF0YV9sZW4gPT0gMCkKPiA+ID4gPiA+ID4gPiA+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSA9IFZJUlRJT19ORVRfSERSX0dTT19O T05FOwo+ID4gPiA+ID4gPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZWxzZQo+ID4gPiA+ ID4gPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsK PiA+ID4gPiA+ID4gPiA+ICvCoMKgwqDCoMKgwqDCoCB9Cj4gPiA+ID4gPiA+ID4gPiAgIMKgwqDC oMKgwqDCoMKgwqDCoCBpZiAoc2luZm8tPmdzb190eXBlICYgU0tCX0dTT19UQ1BfRUNOKQo+ID4g PiA+ID4gPiA+ID4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBoZHItPmdzb190eXBlIHw9 IFZJUlRJT19ORVRfSERSX0dTT19FQ047Cj4gPiA+ID4gPiA+ID4gPiAgIMKgwqDCoMKgwqAgfSBl bHNlCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBwaW5nLgo+ ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gRG8geW91IG1lYW4gZ3NvX3Np emUgaXMgc2V0IGJ1dCBnc29fdHlwZSBpcyBub3Q/IExvb2tzIGxpa2UgYSBidWcKPiA+ID4gPiA+ ID4gZWxzZXdoZXJlLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gVGhhbmtzCj4gPiA+ID4gPiA+ IAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+IFllcy4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gSSBjb3Vs ZCBub3QgdHJhY2UgaXQgd2hlcmUgaXQgaXMgY29taW5nIGZyb20uCj4gPiA+ID4gPiAKPiA+ID4g PiA+IEkgc2VlIGl0IHdoZW4gZG9pbmcgcmVjdm1tc2cgb24gcmF3IHNvY2tldHMgaW4gdGhlIFVN TCB2ZWN0b3IgbmV0d29yawo+ID4gPiA+ID4gZHJpdmVycy4KPiA+ID4gPiA+IAo+ID4gPiA+IAo+ ID4gPiA+IEkgdGhpbmsgd2UgbmVlZCB0byBmaW5kIHRoZSBjdWxwcml0IGFuZCBmaXggaXQgdGhl cmUsIGxvdHMgb2Ygb3RoZXIgdGhpbmdzCj4gPiA+ID4gY2FuIGJyZWFrIG90aGVyd2lzZS4KPiA+ ID4gPiBKdXN0IHByaW50aW5nIG91dCBza2ItPmRldi0+bmFtZSBzaG91bGQgZG8gdGhlIHRyaWNr LCBubz8KPiA+ID4gCj4gPiA+IFRoZSBwcmludGsgaW4gdmlydGlvX25ldF9oZHJfZnJvbV9za2Ig c2F5cyBOVUxMLgo+ID4gPiAKPiA+ID4gVGhhdCBpcyBwcm9iYWJseSBub3JtYWwgZm9yIGEgbG9j YWxseSBvcmlnaW5hdGVkIGZyYW1lLgo+ID4gPiAKPiA+ID4gSSBjYW5ub3QgcmVwcm9kdWNlIHRo aXMgd2l0aCBuZXR3b3JrIHRyYWZmaWMgYnkgdGhlIHdheSAtIGl0IGhhcHBlbnMgb25seSBpZiB0 aGUgdHJhZmZpYyBpcyBsb2NhbGx5IG9yaWdpbmF0ZWQgb24gdGhlIGhvc3QuCj4gPiA+IAo+ID4g PiBBLAo+ID4gCj4gPiBPSyBzbyBpcyBpdCBjb2RlIGluIF9fdGNwX3RyYW5zbWl0X3NrYiB0aGF0 IHNldHMgZ3NvX3NpemUgdG8gbm9uLW51bGwKPiA+IHdoZW4gZ3NvX3R5cGUgaXMgMD8KPiAKPiBJ dCBkb2VzIGxvb2sgbGlrZSB0aGF0LCBidXQgSSBjYW5ub3Qgc2VlIGl0IHdoZW4gcmVhZGluZyBp dCA6KAoKZHVtcCBza2IgcG9pbnRlciBhdCB0aGUgdHdvIGxvY2F0aW9ucyBhbmQgc2VlIHdoZXRo ZXIgaXQgbWF0Y2hlcyA6KQoKPiAKPiA+IAo+ID4gCj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4g PiAtLSAKPiA+ID4gPiA+IEFudG9uIFIuIEl2YW5vdgo+ID4gPiA+ID4gQ2FtYnJpZGdlZ3JleXMg TGltaXRlZC4gUmVnaXN0ZXJlZCBpbiBFbmdsYW5kLiBDb21wYW55IE51bWJlciAxMDI3MzY2MQo+ ID4gPiA+ID4gaHR0cHM6Ly93d3cuY2FtYnJpZGdlZ3JleXMuY29tLwo+ID4gPiA+IAo+ID4gPiA+ IAo+ID4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gPiA+ID4gbGludXgtdW0gbWFpbGluZyBsaXN0Cj4gPiA+ID4gbGludXgtdW1AbGlzdHMuaW5m cmFkZWFkLm9yZwo+ID4gPiA+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtdW0KPiA+ID4gPiAKPiA+ID4gCj4gPiA+IC0tIAo+ID4gPiBBbnRvbiBSLiBJ dmFub3YKPiA+ID4gQ2FtYnJpZGdlZ3JleXMgTGltaXRlZC4gUmVnaXN0ZXJlZCBpbiBFbmdsYW5k LiBDb21wYW55IE51bWJlciAxMDI3MzY2MQo+ID4gPiBodHRwczovL3d3dy5jYW1icmlkZ2VncmV5 cy5jb20vCj4gPiAKPiA+IAo+IAo+IC0tIAo+IEFudG9uIFIuIEl2YW5vdgo+IENhbWJyaWRnZWdy ZXlzIExpbWl0ZWQuIFJlZ2lzdGVyZWQgaW4gRW5nbGFuZC4gQ29tcGFueSBOdW1iZXIgMTAyNzM2 NjEKPiBodHRwczovL3d3dy5jYW1icmlkZ2VncmV5cy5jb20vCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4 LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC11bQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso Date: Thu, 13 Feb 2020 08:12:11 -0500 Message-ID: <20200213081154-mutt-send-email-mst@kernel.org> References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> <54692f06-f687-8bd3-7a1b-3dac3e79110b@cambridgegreys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <54692f06-f687-8bd3-7a1b-3dac3e79110b@cambridgegreys.com> Sender: netdev-owner@vger.kernel.org To: Anton Ivanov Cc: netdev@vger.kernel.org, Jason Wang , linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Thu, Feb 13, 2020 at 11:12:45AM +0000, Anton Ivanov wrote: > > > On 13/02/2020 10:00, Michael S. Tsirkin wrote: > > On Wed, Feb 12, 2020 at 05:38:09PM +0000, Anton Ivanov wrote: > > > > > > > > > On 11/02/2020 10:37, Michael S. Tsirkin wrote: > > > > On Tue, Feb 11, 2020 at 07:42:37AM +0000, Anton Ivanov wrote: > > > > > On 11/02/2020 02:51, Jason Wang wrote: > > > > > > > > > > > > On 2020/2/11 上午12:55, Anton Ivanov wrote: > > > > > > > > > > > > > > > > > > > > > On 09/12/2019 10:48, anton.ivanov@cambridgegreys.com wrote: > > > > > > > > From: Anton Ivanov > > > > > > > > > > > > > > > > Some of the frames marked as GSO which arrive at > > > > > > > > virtio_net_hdr_from_skb() have no GSO_TYPE, no > > > > > > > > fragments (data_len = 0) and length significantly shorter > > > > > > > > than the MTU (752 in my experiments). > > > > > > > > > > > > > > > > This is observed on raw sockets reading off vEth interfaces > > > > > > > > in all 4.x and 5.x kernels I tested. > > > > > > > > > > > > > > > > These frames are reported as invalid while they are in fact > > > > > > > > gso-less frames. > > > > > > > > > > > > > > > > This patch marks the vnet header as no-GSO for them instead > > > > > > > > of reporting it as invalid. > > > > > > > > > > > > > > > > Signed-off-by: Anton Ivanov > > > > > > > > --- > > > > > > > >   include/linux/virtio_net.h | 8 ++++++-- > > > > > > > >   1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > > > > > > > > index 0d1fe9297ac6..d90d5cff1b9a 100644 > > > > > > > > --- a/include/linux/virtio_net.h > > > > > > > > +++ b/include/linux/virtio_net.h > > > > > > > > @@ -112,8 +112,12 @@ static inline int > > > > > > > > virtio_net_hdr_from_skb(const struct sk_buff *skb, > > > > > > > >               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV4; > > > > > > > >           else if (sinfo->gso_type & SKB_GSO_TCPV6) > > > > > > > >               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; > > > > > > > > -        else > > > > > > > > -            return -EINVAL; > > > > > > > > +        else { > > > > > > > > +            if (skb->data_len == 0) > > > > > > > > +                hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; > > > > > > > > +            else > > > > > > > > +                return -EINVAL; > > > > > > > > +        } > > > > > > > >           if (sinfo->gso_type & SKB_GSO_TCP_ECN) > > > > > > > >               hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; > > > > > > > >       } else > > > > > > > > > > > > > > > > > > > > > > ping. > > > > > > > > > > > > > > > > > > > Do you mean gso_size is set but gso_type is not? Looks like a bug > > > > > > elsewhere. > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > Yes. > > > > > > > > > > I could not trace it where it is coming from. > > > > > > > > > > I see it when doing recvmmsg on raw sockets in the UML vector network > > > > > drivers. > > > > > > > > > > > > > I think we need to find the culprit and fix it there, lots of other things > > > > can break otherwise. > > > > Just printing out skb->dev->name should do the trick, no? > > > > > > The printk in virtio_net_hdr_from_skb says NULL. > > > > > > That is probably normal for a locally originated frame. > > > > > > I cannot reproduce this with network traffic by the way - it happens only if the traffic is locally originated on the host. > > > > > > A, > > > > OK so is it code in __tcp_transmit_skb that sets gso_size to non-null > > when gso_type is 0? > > It does look like that, but I cannot see it when reading it :( dump skb pointer at the two locations and see whether it matches :) > > > > > > > > > > > > > > > > > > -- > > > > > Anton R. Ivanov > > > > > Cambridgegreys Limited. Registered in England. Company Number 10273661 > > > > > https://www.cambridgegreys.com/ > > > > > > > > > > > > _______________________________________________ > > > > linux-um mailing list > > > > linux-um@lists.infradead.org > > > > http://lists.infradead.org/mailman/listinfo/linux-um > > > > > > > > > > -- > > > Anton R. Ivanov > > > Cambridgegreys Limited. Registered in England. Company Number 10273661 > > > https://www.cambridgegreys.com/ > > > > > > -- > Anton R. Ivanov > Cambridgegreys Limited. Registered in England. Company Number 10273661 > https://www.cambridgegreys.com/