From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Moulding <dmoulding@me.com>
Cc: linux-wireless@vger.kernel.org, johannes.berg@intel.com,
emmanuel.grumbach@intel.com, luciano.coelho@intel.com,
linuxwifi@intel.com, Dan Moulding <dmoulding@me.com>
Subject: Re: [PATCH v2 5.5] iwlwifi: mvm: Do not require PHY_SKU NVM section for 3168 devices
Date: Thu, 13 Feb 2020 10:03:40 +0000 (UTC) [thread overview]
Message-ID: <20200213100340.541F4C4479C@smtp.codeaurora.org> (raw)
In-Reply-To: <20200128093107.9740-1-dmoulding@me.com>
Dan Moulding <dmoulding@me.com> wrote:
> The logic for checking required NVM sections was recently fixed in
> commit b3f20e098293 ("iwlwifi: mvm: fix NVM check for 3168
> devices"). However, with that fixed the else is now taken for 3168
> devices and within the else clause there is a mandatory check for the
> PHY_SKU section. This causes the parsing to fail for 3168 devices.
>
> The PHY_SKU section is really only mandatory for the IWL_NVM_EXT
> layout (the phy_sku parameter of iwl_parse_nvm_data is only used when
> the NVM type is IWL_NVM_EXT). So this changes the PHY_SKU section
> check so that it's only mandatory for IWL_NVM_EXT.
>
> Fixes: b3f20e098293 ("iwlwifi: mvm: fix NVM check for 3168 devices")
> Signed-off-by: Dan Moulding <dmoulding@me.com>
Patch applied to wireless-drivers.git, thanks.
a9149d243f25 iwlwifi: mvm: Do not require PHY_SKU NVM section for 3168 devices
--
https://patchwork.kernel.org/patch/11353871/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-02-13 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 9:31 [PATCH v2 5.5] iwlwifi: mvm: Do not require PHY_SKU NVM section for 3168 devices Dan Moulding
2020-02-11 16:24 ` Dan Moulding
2020-02-12 14:46 ` Kalle Valo
2020-02-13 7:39 ` Grumbach, Emmanuel
2020-03-04 9:06 ` Luciano Coelho
2020-03-04 15:58 ` Dan Moulding
2020-02-13 10:03 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213100340.541F4C4479C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=dmoulding@me.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.