From: Kalle Valo <kvalo@codeaurora.org>
To: Yingying Tang <yintang@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: fix unsupported chip reset debugs file write
Date: Thu, 13 Feb 2020 14:21:46 +0000 (UTC) [thread overview]
Message-ID: <20200213142146.1FC37C4479C@smtp.codeaurora.org> (raw)
In-Reply-To: <1580887644-21061-1-git-send-email-yintang@codeaurora.org>
Yingying Tang <yintang@codeaurora.org> wrote:
> Before this change, after writing "warm_hw_reset" debugfs file, host
> will send chip reset command to FW even though FW do not support this
> service getting a warning print.
>
> Though there is no FW impact before this change, this patch restricts
> chip reset command sent to FW only if FW advertises the support via WMI
> service bit.
>
> Removed the redundant check and ath10k_warn() print as well.
>
> New version FW will report chip reset service bit to host. Host allow user
> to trigger WLAN chip reset only when fw report this service bit.
>
> For older NON-TLV FW, since it do not report chip reset service bit, host
> will not send chip reset command. For older TLV FW, since it report chip
> reset service bit, host will send chip reset command.
>
> Tested HW: QCA9984, WCN3990
>
> QCA9984 FW version: WLAN.BL.3.9.0.2-00042-S-1
>
> Signed-off-by: Yingying Tang <yintang@codeaurora.org>
Fails to apply:
error: patch failed: drivers/net/wireless/ath/ath10k/wmi.h:367
error: drivers/net/wireless/ath/ath10k/wmi.h: patch does not apply
stg import: Diff does not apply cleanly
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/11365857/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2020-02-13 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 7:27 [PATCH] ath10k: fix unsupported chip reset debugs file write Yingying Tang
2020-02-05 7:27 ` Yingying Tang
2020-02-13 14:21 ` Kalle Valo
2020-02-13 14:21 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213142146.1FC37C4479C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yintang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.