All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] tests/kms_big_fb: Set plane position and framebuffer dimensions before commit
Date: Thu, 13 Feb 2020 17:13:47 +0200	[thread overview]
Message-ID: <20200213151347.GG13686@intel.com> (raw)
In-Reply-To: <20200213051845.31958-2-mohammed.khajapasha@intel.com>

On Thu, Feb 13, 2020 at 10:48:45AM +0530, Mohammed Khajapasha wrote:
> Set the plane position and weight and height for small framebuffer
> before committing it in for loop.
> 
> Signed-off-by: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
> ---
>  tests/kms_big_fb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
> index eb144da9..6ba96a99 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -286,6 +286,7 @@ static bool test_plane(data_t *data)
>  		}
>  
>  		igt_plane_set_fb(plane, small_fb);
> +		igt_plane_set_position(plane, 0, 0);
>  		igt_plane_set_size(plane, data->width, data->height);
>  
>  		/*
> @@ -318,6 +319,8 @@ static bool test_plane(data_t *data)
>  		copy_pattern(data, small_fb, 0, 0, big_fb, x, y,
>  			     small_fb->width, small_fb->height);
>  
> +		igt_fb_set_size(small_fb, plane, small_fb->width, small_fb->height);
> +

igt_plane_set_fb() already does these.

>  		igt_display_commit2(&data->display, data->display.is_atomic ?
>  				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>  
> -- 
> 2.24.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-02-13 15:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  5:18 [igt-dev] [PATCH i-g-t 0/1] tests/kms_big_fb: Set plane position and framebuffer dimensions before commit Mohammed Khajapasha
2020-02-13  5:18 ` [igt-dev] [PATCH i-g-t 1/1] " Mohammed Khajapasha
2020-02-13 15:13   ` Ville Syrjälä [this message]
2020-02-13  9:58 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-17  9:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-02-12 19:05 [igt-dev] [PATCH i-g-t 0/1] " Mohammed Khajapasha
2020-02-12 19:05 ` [igt-dev] [PATCH i-g-t 1/1] " Mohammed Khajapasha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213151347.GG13686@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mohammed.khajapasha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.