From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1BEBC2BA83 for ; Thu, 13 Feb 2020 15:37:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 791D0217F4 for ; Thu, 13 Feb 2020 15:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581608243; bh=papIyfFj1qzrURl+Pra2xbV58csYt+VzN7lpJCfdmHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nSCnVVTNRZypIiQ/G4lk2hK9wI3j22h50eE0EAAGrVeRORODWaXyu+ofEJx/fSvV7 PWQQT84VnKZoFqdeKewexI+FjIKdPzapo0x9qT5A3fgZRbGY1gpc8ZGT4P0Ef/faUT WAhMYChMluNxCVLXr8nqG+ARKfA5/lZh4FT1SNEw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387869AbgBMP33 (ORCPT ); Thu, 13 Feb 2020 10:29:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:46676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728558AbgBMP0l (ORCPT ); Thu, 13 Feb 2020 10:26:41 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA79924688; Thu, 13 Feb 2020 15:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607601; bh=papIyfFj1qzrURl+Pra2xbV58csYt+VzN7lpJCfdmHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ltwqTB2SE9RL2gOZqEUCsIIx4Zsc0yYuW9WfIHpnG1SN/IDFHVXYKgHQEGIZaPVBH NIJaOk5bi2l3u6kOLQYeP3CFqUYnvch9UcsBGkNLkZNpFxsc0lhKUcdEqo41rlb51V AvLLN3ISfRr0ghi/Gdq8wPdA5n/pmuj37jXe+8tQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Kocialkowski , Alexandre Belloni Subject: [PATCH 4.19 20/52] rtc: hym8563: Return -EINVAL if the time is known to be invalid Date: Thu, 13 Feb 2020 07:21:01 -0800 Message-Id: <20200213151818.909735893@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151810.331796857@linuxfoundation.org> References: <20200213151810.331796857@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Kocialkowski commit f236a2a2ebabad0848ad0995af7ad1dc7029e895 upstream. The current code returns -EPERM when the voltage loss bit is set. Since the bit indicates that the time value is not valid, return -EINVAL instead, which is the appropriate error code for this situation. Fixes: dcaf03849352 ("rtc: add hym8563 rtc-driver") Signed-off-by: Paul Kocialkowski Link: https://lore.kernel.org/r/20191212153111.966923-1-paul.kocialkowski@bootlin.com Signed-off-by: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- drivers/rtc/rtc-hym8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -105,7 +105,7 @@ static int hym8563_rtc_read_time(struct if (!hym8563->valid) { dev_warn(&client->dev, "no valid clock/calendar values available\n"); - return -EPERM; + return -EINVAL; } ret = i2c_smbus_read_i2c_block_data(client, HYM8563_SEC, 7, buf);