From: Denton Liu <liu.denton@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Yang Zhao" <yang.zhao@skyboxlabs.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Emily Shaffer" <emilyshaffer@google.com>,
"Han-Wen Nienhuys" <hanwen@google.com>,
"Ben Keene" <seraphire@gmail.com>
Subject: Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
Date: Fri, 14 Feb 2020 00:15:05 -0500 [thread overview]
Message-ID: <20200214051505.GA16130@generichostname> (raw)
In-Reply-To: <xmqqtv3tpzto.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Thu, Feb 13, 2020 at 08:17:39PM -0800, Junio C Hamano wrote:
> Now we are running some tests under py3, we seem to be failing the
> tip of 'pu'
>
> https://travis-ci.org/git/git/jobs/650160479
>
> that is getting a SyntaxError.
>
> if message.find(separatorLine) <> -1:
This change comes from 'git-p4: restructure code in submit' in
'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
operator. In Python 2, this is valid but in Python 3, it was removed.
We can simply replace the `<>` with `!=` which is the new way of
writing "not equals".
next prev parent reply other threads:[~2020-02-14 5:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 21:58 What's cooking in git.git (Feb 2020, #03; Wed, 12) Junio C Hamano
2020-02-13 12:26 ` bw/remote-rename-update-config, was " Johannes Schindelin
2020-02-13 13:02 ` yz/p4-py3, " Johannes Schindelin
2020-02-13 16:06 ` Junio C Hamano
2020-02-13 21:18 ` Junio C Hamano
2020-02-14 4:17 ` Junio C Hamano
2020-02-14 5:15 ` Denton Liu [this message]
2020-02-14 14:39 ` Ben Keene
2020-02-14 16:18 ` Junio C Hamano
2020-02-14 17:01 ` Junio C Hamano
2020-02-14 17:05 ` Ben Keene
2020-02-14 18:10 ` Junio C Hamano
2020-03-10 17:38 ` SZEDER Gábor
2020-03-10 18:29 ` Junio C Hamano
2020-02-16 4:42 ` Elijah Newren
2020-02-17 7:38 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214051505.GA16130@generichostname \
--to=liu.denton@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
--cc=seraphire@gmail.com \
--cc=szeder.dev@gmail.com \
--cc=yang.zhao@skyboxlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.