From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Beilei Xing <beilei.xing@intel.com>
Cc: dev@dpdk.org, qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix unchecked return value
Date: Fri, 14 Feb 2020 17:45:34 +0800 [thread overview]
Message-ID: <20200214094534.GA16933@intel.com> (raw)
In-Reply-To: <1581510961-96878-1-git-send-email-beilei.xing@intel.com>
On 02/12, Beilei Xing wrote:
>This patch fixes unchecked return value
>of the i40e_xmit_cleanup function.
>
>Coverity issue: 353617
>Fixes: 4861cde46116 ("i40e: new poll mode driver")
>
>Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>---
>V2 change:
> - Use cast.
>
> drivers/net/i40e/i40e_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
>index fd1ae80..f6d23c9 100644
>--- a/drivers/net/i40e/i40e_rxtx.c
>+++ b/drivers/net/i40e/i40e_rxtx.c
>@@ -1039,7 +1039,7 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
>
> /* Check if the descriptor ring needs to be cleaned. */
> if (txq->nb_tx_free < txq->tx_free_thresh)
>- i40e_xmit_cleanup(txq);
>+ (void)i40e_xmit_cleanup(txq);
>
> for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {
> td_cmd = 0;
>--
>2.7.4
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
prev parent reply other threads:[~2020-02-14 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 19:02 [dpdk-dev] [PATCH] net/i40e: fix unchecked return value Beilei Xing
2020-02-11 11:42 ` Bruce Richardson
2020-02-12 2:33 ` Xing, Beilei
2020-02-12 12:36 ` [dpdk-dev] [PATCH v2] " Beilei Xing
2020-02-14 9:45 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214094534.GA16933@intel.com \
--to=xiaolong.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.