From: Tzung-Bi Shih <tzungbi@google.com>
To: broonie@kernel.org
Cc: tzungbi@google.com, alsa-devel@alsa-project.org,
dgreid@google.com, cychiang@google.com
Subject: [alsa-devel] [PATCH 0/3] ASoC: max98090: revert invalid fixes
Date: Fri, 14 Feb 2020 18:57:41 +0800 [thread overview]
Message-ID: <20200214105744.82258-1-tzungbi@google.com> (raw)
A critical side-effect was observed along with the commit 62d5ae4cafb7
("ASoC: max98090: save and restore SHDN when changing sensitive registers").
When keep playing something,
(e.g. sox -n -t s16 -r 48000 -c 2 - synth sine 440 vol 0.1 | \
aplay -D hw:0,0 -f S16_LE -r 48000 -c 2)
the recorded sound has chance to break (clipping).
(e.g. while [ 1 ]; do
arecord -q -f S16_LE -d 2 -r 48000 -c 2 test.raw \
sox -t s16 -r 48000 -c 2 test.raw -n stat \
...
done)
The series reverts all related commits.
I feel really sorry for the whole mess.
Tzung-Bi Shih (3):
ASoC: max98090: revert invalid fix for handling SHDN
ASoC: dapm: remove snd_soc_dapm_put_enum_double_locked
ASoC: core: remove SND_SOC_BYTES_E
include/sound/soc-dapm.h | 2 -
include/sound/soc.h | 6 -
sound/soc/codecs/max98090.c | 434 ++++++++++--------------------------
sound/soc/codecs/max98090.h | 3 +-
sound/soc/soc-dapm.c | 54 ++---
5 files changed, 137 insertions(+), 362 deletions(-)
--
2.25.0.265.gbab2e86ba0-goog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next reply other threads:[~2020-02-14 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 10:57 Tzung-Bi Shih [this message]
2020-02-14 10:57 ` [alsa-devel] [PATCH 1/3] ASoC: max98090: revert invalid fix for handling SHDN Tzung-Bi Shih
2020-02-14 20:56 ` [alsa-devel] Applied "ASoC: max98090: revert invalid fix for handling SHDN" to the asoc tree Mark Brown
2020-02-14 10:57 ` [alsa-devel] [PATCH 2/3] ASoC: dapm: remove snd_soc_dapm_put_enum_double_locked Tzung-Bi Shih
2020-02-14 20:56 ` [alsa-devel] Applied "ASoC: dapm: remove snd_soc_dapm_put_enum_double_locked" to the asoc tree Mark Brown
2020-02-14 10:57 ` [alsa-devel] [PATCH 3/3] ASoC: core: remove SND_SOC_BYTES_E Tzung-Bi Shih
2020-02-14 15:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214105744.82258-1-tzungbi@google.com \
--to=tzungbi@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cychiang@google.com \
--cc=dgreid@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.