From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: David Sterba <dsterba@suse.cz>,
Nikolay Borisov <nborisov@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
"linux-btrfs @ vger . kernel . org" <linux-btrfs@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v8 5/8] btrfs: use BIOs instead of buffer_heads from superblock writeout
Date: Fri, 14 Feb 2020 16:08:50 +0100 [thread overview]
Message-ID: <20200214150850.GY2902@twin.jikos.cz> (raw)
In-Reply-To: <20200213152436.13276-6-johannes.thumshirn@wdc.com>
On Fri, Feb 14, 2020 at 12:24:33AM +0900, Johannes Thumshirn wrote:
> + /*
> + * Directly use BIOs here instead of relying on the page-cache
> + * to do I/O, so we don't loose the ability to do integrity
> + * checking.
> + */
> + bio = bio_alloc(GFP_NOFS, 1);
> + bio_set_dev(bio, device->bdev);
> + bio->bi_iter.bi_sector = bytenr >> SECTOR_SHIFT;
> + bio->bi_private = device;
> + bio->bi_end_io = btrfs_end_super_write;
As a potential future cleanup and simplification, the per-device flush
bio can be used here and not a new one allocated. The flush bios are
sent synchronously and are free for later use by the async submit
writes.
next prev parent reply other threads:[~2020-02-14 15:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 15:24 [PATCH v8 0/8] btrfs: remove buffer heads form superblock handling Johannes Thumshirn
2020-02-13 15:24 ` [PATCH v8 1/8] btrfs: Export btrfs_release_disk_super Johannes Thumshirn
2020-02-13 15:24 ` [PATCH v8 2/8] btrfs: don't kmap() pages from block devices Johannes Thumshirn
2020-02-13 15:24 ` [PATCH v8 3/8] btrfs: reduce scope of btrfs_scratch_superblocks() Johannes Thumshirn
2020-02-18 3:14 ` Anand Jain
2020-02-13 15:24 ` [PATCH v8 4/8] btrfs: use the page-cache for super block reading Johannes Thumshirn
2020-02-14 13:59 ` David Sterba
2020-02-13 15:24 ` [PATCH v8 5/8] btrfs: use BIOs instead of buffer_heads from superblock writeout Johannes Thumshirn
2020-02-14 15:02 ` David Sterba
2020-02-14 15:08 ` David Sterba [this message]
2020-02-14 15:15 ` Johannes Thumshirn
2020-02-18 9:28 ` Anand Jain
2020-02-13 15:24 ` [PATCH v8 6/8] btrfs: remove btrfsic_submit_bh() Johannes Thumshirn
2020-02-18 9:30 ` Anand Jain
2020-02-13 15:24 ` [PATCH v8 7/8] btrfs: remove buffer_heads from btrfsic_process_written_block() Johannes Thumshirn
2020-02-13 15:24 ` [PATCH v8 8/8] btrfs: remove buffer_heads form superblock mirror integrity checking Johannes Thumshirn
2020-02-14 13:53 ` David Sterba
2020-02-14 15:43 ` David Sterba
2020-02-20 15:56 ` [PATCH v8 0/8] btrfs: remove buffer heads form superblock handling David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214150850.GY2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.