From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH AUTOSEL 4.9 134/141] reiserfs: prevent NULL pointer dereference in reiserfs_insert_item() Date: Fri, 14 Feb 2020 11:21:14 -0500 Message-ID: <20200214162122.19794-134-sashal@kernel.org> References: <20200214162122.19794-1-sashal@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581697450; bh=XuVLhXNZHPeJbyGhkNR8+oC6FyGsCGr10fM/qb0PYjg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nGsgfDinQxVUo/Rwl3xx2TQZuNC47Yw2hl8TDWHVDwsDXVS97J7hhkWeTYJwLrBP2 T1bkhfBOFPkd2wvQ+EWndvbZr7NWSMPUvz7vsatY14EY8x9GEp9oo+I3b6J/OhxISw 07+n4OttQb3XGXmcpY76LExXYDg49FAEme1kSrpc= In-Reply-To: <20200214162122.19794-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yunfeng Ye , zhengbin , Hu Shiyuan , Feilong Lin , Jan Kara , Andrew Morton , Linus Torvalds , Sasha Levin , reiserfs-devel@vger.kernel.org From: Yunfeng Ye [ Upstream commit aacee5446a2a1aa35d0a49dab289552578657fb4 ] The variable inode may be NULL in reiserfs_insert_item(), but there is no check before accessing the member of inode. Fix this by adding NULL pointer check before calling reiserfs_debug(). Link: http://lkml.kernel.org/r/79c5135d-ff25-1cc9-4e99-9f572b88cc00@huawei.com Signed-off-by: Yunfeng Ye Cc: zhengbin Cc: Hu Shiyuan Cc: Feilong Lin Cc: Jan Kara Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/reiserfs/stree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c index a97e352d05d3b..5f5fff0688776 100644 --- a/fs/reiserfs/stree.c +++ b/fs/reiserfs/stree.c @@ -2249,7 +2249,8 @@ int reiserfs_insert_item(struct reiserfs_transaction_handle *th, /* also releases the path */ unfix_nodes(&s_ins_balance); #ifdef REISERQUOTA_DEBUG - reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE, + if (inode) + reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE, "reiserquota insert_item(): freeing %u id=%u type=%c", quota_bytes, inode->i_uid, head2type(ih)); #endif -- 2.20.1