Re: [PATCH v2 5/8] serial: 8250_port: Don't use power management for kernel console

[Tony Lindgren <tony@atomide.com>]

* Andy Shevchenko <andriy.shevchenko@linux.intel.com> [200214 18:57]:
> On Fri, Feb 14, 2020 at 10:14:07AM -0800, Tony Lindgren wrote:
> > * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [200214 11:44]:
> > > --- a/drivers/tty/serial/8250/8250_core.c
> > > +++ b/drivers/tty/serial/8250/8250_core.c
> > > @@ -608,6 +608,14 @@ static int univ8250_console_setup(struct console *co, char *options)
> > >  	return retval;
> > >  }
> > >  
> > > +static int univ8250_console_exit(struct console *co)
> > > +{
> > > +	struct uart_port *port;
> > > +
> > > +	port = &serial8250_ports[co->index].port;
> > > +	return serial8250_console_exit(port);
> > > +}
> > > +
> > >  /**
> > >   *	univ8250_console_match - non-standard console matching
> > >   *	@co:	  registering console
> > > @@ -666,6 +674,7 @@ static struct console univ8250_console = {
> > >  	.write		= univ8250_console_write,
> > >  	.device		= uart_console_device,
> > >  	.setup		= univ8250_console_setup,
> > > +	.exit		= univ8250_console_exit,
> > >  	.match		= univ8250_console_match,
> > >  	.flags		= CON_PRINTBUFFER | CON_ANYTIME,
> > >  	.index		= -1,
> > 
> > You're missing adding exit to struct console or these patches
> > are based on some tree I don't have. I had to add the following
> > change to compile for you to fold into this patch.
> 
> In cover letter the [1] link answers to this.
> Can you try again with that series being applied first?

Ah OK thanks will try with that applied.

Regards,

Tony