From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28DE2C35242 for ; Fri, 14 Feb 2020 21:50:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E951A2168B for ; Fri, 14 Feb 2020 21:50:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fEpnlH3x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0Fq+suuk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E951A2168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+ixF6KaEYvEekEQWiocIwaN5z6JGO7E6M95lKW3FxP8=; b=fEpnlH3xZJqqbp TJUSBZt3utzGlfftPNK5FKyjTvM5RXI3kkYR1USKqPfqiSOm+1iofHWvIul6VsrVITt13FcTA/TSF nVpb7yiYK3x5zXU4akNzATaZWamr9fosi566XHD4mddafI7Zh2h3bfocmqsJRsXOH0L2N4ecCm3PA WNgExSi0NL5J2B+IudcT3hOJ5ZW2y7ZPxRCWoXGX9hcZGbSjp3KopxaM4o+ySG5mc8Ja2a3KPCWha hvNp15yncJPBY43Blusq2PBF/Ertd6GG79Tpit90EWEPw5prBQvsH8sGE7SlSVR4XbWbH3BctSVx3 mq9D6NVeEoXet0lpFmhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2irI-0007Zk-Iz; Fri, 14 Feb 2020 21:50:48 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2irF-0007ZI-D3 for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2020 21:50:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7iRmTIPwdVFSIEMmhYwyfw+SlQI0O1RLqb/oLphl5Ow=; b=0Fq+suukFgH9Wv9A6xtYGcRQxl x4ke43NR8rGrvA4iaY3LmvwGynr3DGHh4xKlW6C1htwXFCoqncX+xQmbu9Zr7rhxOMar1h4CNR5Jp 6rUcsoXi2w6vLaUJQUCdRcgkO5rf8DHwqu7wZ1jhQETUWbCfSsVjInrXiFJkLQLEEQ+A=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j2ir7-0002EK-Az; Fri, 14 Feb 2020 22:50:37 +0100 Date: Fri, 14 Feb 2020 22:50:37 +0100 From: Andrew Lunn To: Scott Branden Subject: Re: [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver Message-ID: <20200214215037.GR31084@lunn.ch> References: <20200214214746.10153-1-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200214214746.10153-1-scott.branden@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_135045_442136_333A26FA X-CRM114-Status: UNSURE ( 8.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Ray Jui , Arun Parameswaran , Russell King , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, "David S . Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 14, 2020 at 01:47:46PM -0800, Scott Branden wrote: > From: Arun Parameswaran > > The mii management register in iproc mdio block > does not have a retention register so it is lost on suspend. > Save and restore value of register while resuming from suspend. You actually just reconfigure, you don't save it. But that is minor. Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D8F8C35242 for ; Fri, 14 Feb 2020 21:50:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47E692168B for ; Fri, 14 Feb 2020 21:50:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0Fq+suuk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730514AbgBNVur (ORCPT ); Fri, 14 Feb 2020 16:50:47 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47284 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729294AbgBNVur (ORCPT ); Fri, 14 Feb 2020 16:50:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7iRmTIPwdVFSIEMmhYwyfw+SlQI0O1RLqb/oLphl5Ow=; b=0Fq+suukFgH9Wv9A6xtYGcRQxl x4ke43NR8rGrvA4iaY3LmvwGynr3DGHh4xKlW6C1htwXFCoqncX+xQmbu9Zr7rhxOMar1h4CNR5Jp 6rUcsoXi2w6vLaUJQUCdRcgkO5rf8DHwqu7wZ1jhQETUWbCfSsVjInrXiFJkLQLEEQ+A=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j2ir7-0002EK-Az; Fri, 14 Feb 2020 22:50:37 +0100 Date: Fri, 14 Feb 2020 22:50:37 +0100 From: Andrew Lunn To: Scott Branden Cc: Florian Fainelli , Heiner Kallweit , Russell King , "David S . Miller" , Ray Jui , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arun Parameswaran Subject: Re: [PATCH v2] net: phy: restore mdio regs in the iproc mdio driver Message-ID: <20200214215037.GR31084@lunn.ch> References: <20200214214746.10153-1-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214214746.10153-1-scott.branden@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 14, 2020 at 01:47:46PM -0800, Scott Branden wrote: > From: Arun Parameswaran > > The mii management register in iproc mdio block > does not have a retention register so it is lost on suspend. > Save and restore value of register while resuming from suspend. You actually just reconfigure, you don't save it. But that is minor. Reviewed-by: Andrew Lunn Andrew