From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] mt76: mt7615: remove rx_mask in mt7615_eeprom_parse_hw_cap
Date: Sat, 15 Feb 2020 04:38:31 +0800 [thread overview]
Message-ID: <202002150402.3eKyPXcB%lkp@intel.com> (raw)
In-Reply-To: <496a58e997ab842d912c5b5352fa6593dc7cc00f.1581455625.git.lorenzo@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 4710 bytes --]
Hi Lorenzo,
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master v5.6-rc1 next-20200214]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/mt76-mt7615-remove-rx_mask-in-mt7615_eeprom_parse_hw_cap/20200215-021915
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c: In function 'mt7615_eeprom_parse_hw_cap':
>> drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c:123:39: error: 'rx_mask' undeclared (first use in this function); did you mean 'tx_mask'?
dev->mt76.chainmask = tx_mask << 8 | rx_mask;
^~~~~~~
tx_mask
drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c:123:39: note: each undeclared identifier is reported only once for each function it appears in
vim +123 drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
f9461a687928df2 Lorenzo Bianconi 2019-05-17 92
c988a77f1de523e Lorenzo Bianconi 2019-05-17 93 static void mt7615_eeprom_parse_hw_cap(struct mt7615_dev *dev)
c988a77f1de523e Lorenzo Bianconi 2019-05-17 94 {
d08f3010f4a32ee Lorenzo Bianconi 2020-02-07 95 u8 *eeprom = dev->mt76.eeprom.data;
30ec8d836cb0539 Lorenzo Bianconi 2020-02-11 96 u8 tx_mask, max_nss;
d08f3010f4a32ee Lorenzo Bianconi 2020-02-07 97 u32 val;
c988a77f1de523e Lorenzo Bianconi 2019-05-17 98
c988a77f1de523e Lorenzo Bianconi 2019-05-17 99 val = FIELD_GET(MT_EE_NIC_WIFI_CONF_BAND_SEL,
c988a77f1de523e Lorenzo Bianconi 2019-05-17 100 eeprom[MT_EE_WIFI_CONF]);
c988a77f1de523e Lorenzo Bianconi 2019-05-17 101 switch (val) {
c988a77f1de523e Lorenzo Bianconi 2019-05-17 102 case MT_EE_5GHZ:
c988a77f1de523e Lorenzo Bianconi 2019-05-17 103 dev->mt76.cap.has_5ghz = true;
c988a77f1de523e Lorenzo Bianconi 2019-05-17 104 break;
c988a77f1de523e Lorenzo Bianconi 2019-05-17 105 case MT_EE_2GHZ:
c988a77f1de523e Lorenzo Bianconi 2019-05-17 106 dev->mt76.cap.has_2ghz = true;
c988a77f1de523e Lorenzo Bianconi 2019-05-17 107 break;
c988a77f1de523e Lorenzo Bianconi 2019-05-17 108 default:
c988a77f1de523e Lorenzo Bianconi 2019-05-17 109 dev->mt76.cap.has_2ghz = true;
c988a77f1de523e Lorenzo Bianconi 2019-05-17 110 dev->mt76.cap.has_5ghz = true;
c988a77f1de523e Lorenzo Bianconi 2019-05-17 111 break;
c988a77f1de523e Lorenzo Bianconi 2019-05-17 112 }
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 113
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 114 /* read tx-rx mask from eeprom */
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 115 val = mt76_rr(dev, MT_TOP_STRAP_STA);
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 116 max_nss = val & MT_TOP_3NSS ? 3 : 4;
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 117
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 118 tx_mask = FIELD_GET(MT_EE_NIC_CONF_TX_MASK,
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 119 eeprom[MT_EE_NIC_CONF_0]);
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 120 if (!tx_mask || tx_mask > max_nss)
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 121 tx_mask = max_nss;
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 122
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 @123 dev->mt76.chainmask = tx_mask << 8 | rx_mask;
acf5457fd99db6c Lorenzo Bianconi 2019-11-14 124 dev->mt76.antenna_mask = BIT(tx_mask) - 1;
c988a77f1de523e Lorenzo Bianconi 2019-05-17 125 }
c988a77f1de523e Lorenzo Bianconi 2019-05-17 126
:::::: The code at line 123 was first introduced by commit
:::::: acf5457fd99db6c9a42ef280494dfee949ee1e09 mt76: mt7615: read {tx,rx} mask from eeprom
:::::: TO: Lorenzo Bianconi <lorenzo@kernel.org>
:::::: CC: Felix Fietkau <nbd@nbd.name>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 56548 bytes --]
prev parent reply other threads:[~2020-02-14 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 21:20 [PATCH] mt76: mt7615: remove rx_mask in mt7615_eeprom_parse_hw_cap Lorenzo Bianconi
2020-02-14 20:38 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202002150402.3eKyPXcB%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.