From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D214C3F68F for ; Sat, 15 Feb 2020 05:36:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13A6C2086A for ; Sat, 15 Feb 2020 05:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cIxrqNRp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725774AbgBOFgK (ORCPT ); Sat, 15 Feb 2020 00:36:10 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35753 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgBOFgK (ORCPT ); Sat, 15 Feb 2020 00:36:10 -0500 Received: by mail-pg1-f193.google.com with SMTP id v23so2721105pgk.2 for ; Fri, 14 Feb 2020 21:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=umSLSqFdcTUcW15IlOni/Tuec1i7imfq7Q7J9RYYX4g=; b=cIxrqNRp65WCtK+fiYn9g3PVPZKXWCeUB0uFKNIzbK215QX3Al36Ke7lSPKliczQPG zRn7Bi6DqLKPjlqWNiNyIv1hfnOjroG9dJAo7zBVoxdcOscAu96nnIAHZ0M1KbXjm0Sl ZR04ZlFB/h9Rx1G6+2XpmHZ6qc00E2hKTf9RBjGMhvM/S7iYiuAY2TTttm/rFAuLs3bq Tl4EPCrQfsVTe0Oz0o9vN+XxWzhv+LiQ+CYz/xTgBuLMVClebtR7iuNxNAyHBtWlm0Wp bHYgpgS19tzczImghBSGzs7yS4YbFHy+7+42F6gNr1Xyalax7P6gX0gNY6JBKTkCYKiJ SqhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=umSLSqFdcTUcW15IlOni/Tuec1i7imfq7Q7J9RYYX4g=; b=sa2nPj5D7s/ybrrDDrPwC+EfG5bwd3qUs54R1gZjEHlkZYMV7V2pgVPTMiievIy/H7 3D8LiJYepnnAlKNWzpz5opS+NJB1UQupQSe9OoAULvE+FT2DzDnWB3T3DulbHJYwnWvJ VPY2+O/90tB6jgQ3LzwV8XKLiHHl2ftBAknwhmg8CrxN0rYlcUGrMXGUmujf2shPB9iR 8KYD1SHYZde2h0BU9KUlP0sdP/m8/V7Bz2X4An3ISktcC4M5ZpZge4Iwicp/YWeKzGYL IuVGt4hEHSa92kMxKIbmIpMboICZB2QxxmOYFRTfgk4/f7XBpxfNsA8mPvIJhvoRODjp rhlA== X-Gm-Message-State: APjAAAUYsNGgUGQJRtpCsgzZRAFD2zmN3uWlctoDQZiRz7LPqCS3D4ja Mg2xkJ70W6mZLbC9qAVFXi8tJQ== X-Google-Smtp-Source: APXvYqzk4mzSWnD3eisseNOAoKEFSWYJ3iXu/MnMV3x1ieUnd9jyOy7C/UGmCSr9X/1fRkBJKg6m3w== X-Received: by 2002:a62:6842:: with SMTP id d63mr6945184pfc.113.1581744969478; Fri, 14 Feb 2020 21:36:09 -0800 (PST) Received: from ripper (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id q12sm8411743pfh.158.2020.02.14.21.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 21:36:08 -0800 (PST) Date: Fri, 14 Feb 2020 21:35:17 -0800 From: Bjorn Andersson To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Linus Walleij , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sean Wang , Matthias Brugger , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Chen-Yu Tsai , Paul Cercueil , Neil Armstrong , Heiko Stuebner , Geert Uytterhoeven , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Andy Gross , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-oxnas@groups.io, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Message-ID: <20200215053517.GN955802@ripper> References: <20191112141819.GA22076@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112141819.GA22076@localhost.localdomain> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 763da0be10d6..8844ca1261d5 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) > > val = msm_readl_ctl(pctrl, g); > > - /* 0 = output, 1 = input */ > - return val & BIT(g->oe_bit) ? 0 : 1; > + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT : > + GPIO_LINE_DIRECTION_IN; For pinctrl-msm: Reviewed-by: Bjorn Andersson > } Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64699C352A3 for ; Sat, 15 Feb 2020 05:36:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 347202067D for ; Sat, 15 Feb 2020 05:36:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RgjCE6Fq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cIxrqNRp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 347202067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ceEe/gWI44FZeXTS/sUq/L83L61SlXSgwX8kZcWmLD8=; b=RgjCE6FqeS0dCU 96TnPC/Qm3oh8G6egvOMXdjDi7APycEw5oow9XGiH7NljtOC5A3Gfo16D8pUpL+BiaJk3l2FI4dHD kONwhEQ8XBGtGDDqpHGMPDBwPpDuAjUTkLm6rajTqukKlN/Ox82/t7ORChe+YegGuXo4GfJkViDsz Xdw/q4J5MU6jlmbJ8uYWZUZ8v3wrGzbOLIAS8N+h3n08a8lUB0Iy6Uo8D6gAt2BZSZsmzFQYZf3zl I4PjkqXk5AZYc8dNqxIgGjrq0eNOvPWVlEzdIqNONH/7VbPs1pDUrysGmQqewPGjt9o+Uh3Aso0J+ oYZEF4wX9Ee/lncELndw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2q7p-0004OS-Bh; Sat, 15 Feb 2020 05:36:21 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2q7f-0004Fi-3c for linux-mediatek@lists.infradead.org; Sat, 15 Feb 2020 05:36:13 +0000 Received: by mail-pg1-x541.google.com with SMTP id j4so6130281pgi.1 for ; Fri, 14 Feb 2020 21:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=umSLSqFdcTUcW15IlOni/Tuec1i7imfq7Q7J9RYYX4g=; b=cIxrqNRp65WCtK+fiYn9g3PVPZKXWCeUB0uFKNIzbK215QX3Al36Ke7lSPKliczQPG zRn7Bi6DqLKPjlqWNiNyIv1hfnOjroG9dJAo7zBVoxdcOscAu96nnIAHZ0M1KbXjm0Sl ZR04ZlFB/h9Rx1G6+2XpmHZ6qc00E2hKTf9RBjGMhvM/S7iYiuAY2TTttm/rFAuLs3bq Tl4EPCrQfsVTe0Oz0o9vN+XxWzhv+LiQ+CYz/xTgBuLMVClebtR7iuNxNAyHBtWlm0Wp bHYgpgS19tzczImghBSGzs7yS4YbFHy+7+42F6gNr1Xyalax7P6gX0gNY6JBKTkCYKiJ SqhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=umSLSqFdcTUcW15IlOni/Tuec1i7imfq7Q7J9RYYX4g=; b=pMC2Xz9fARoniqi4c0xMS4qSWCtTEJsuRTjt6rdAt0hn5gAXSiBBbzysJ6g+Xnxzsj mftgeYNzPzDoXoMCXNypUe1Cvgg1MaahgDQD7W0AE481lXC3Kfl0NDny+K1tdNIXkE/x pggkAVO8pyboHoWooFzued7RbrgtVaCzwES0jzMltn+jy0WrPRvp6benxS2oR6NZwpgA apo8BJ4Jg/b7IwgMAQ0de0AuAw9NDWXaTLIWsjirphuYH6ypUh6LcF+KJ2QEU5T3PPdk 8UG+C0EUWZr5bIOuYii/KXoxFfWQEnWVqn4Cw0by0dUiQBVs60zmz2OawStJpsYOOBv6 PMyg== X-Gm-Message-State: APjAAAWzs8HAGSu8EpF3eGwysTRUpCrJQqFXoOy1Em1dBskhD+rj0WrP sSHvGLsEOxIDBBio95eX1bc2Hw== X-Google-Smtp-Source: APXvYqzk4mzSWnD3eisseNOAoKEFSWYJ3iXu/MnMV3x1ieUnd9jyOy7C/UGmCSr9X/1fRkBJKg6m3w== X-Received: by 2002:a62:6842:: with SMTP id d63mr6945184pfc.113.1581744969478; Fri, 14 Feb 2020 21:36:09 -0800 (PST) Received: from ripper (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id q12sm8411743pfh.158.2020.02.14.21.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 21:36:08 -0800 (PST) Date: Fri, 14 Feb 2020 21:35:17 -0800 From: Bjorn Andersson To: Matti Vaittinen Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Message-ID: <20200215053517.GN955802@ripper> References: <20191112141819.GA22076@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191112141819.GA22076@localhost.localdomain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_213611_147927_9F7CEC3D X-CRM114-Status: GOOD ( 11.25 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Alexandre Belloni , Heiko Stuebner , Geert Uytterhoeven , Neil Armstrong , Linus Walleij , Patrice Chotard , Paul Cercueil , Eric Anholt , linux-stm32@st-md-mailman.stormreply.com, Alexandre Torgue , Florian Fainelli , Gregory Clement , Chen-Yu Tsai , linux-rockchip@lists.infradead.org, Ludovic Desroches , Andy Gross , bcm-kernel-feedback-list@broadcom.com, linux-arm-msm@vger.kernel.org, Sebastian Hesselbarth , Jason Cooper , mazziesaccount@gmail.com, Ray Jui , linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Scott Branden , Sean Wang , Nicolas Ferre , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Stefan Wahren , Maxime Coquelin , linux-oxnas@groups.io Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 763da0be10d6..8844ca1261d5 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) > > val = msm_readl_ctl(pctrl, g); > > - /* 0 = output, 1 = input */ > - return val & BIT(g->oe_bit) ? 0 : 1; > + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT : > + GPIO_LINE_DIRECTION_IN; For pinctrl-msm: Reviewed-by: Bjorn Andersson > } Regards, Bjorn _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Date: Fri, 14 Feb 2020 21:35:17 -0800 Message-ID: <20200215053517.GN955802@ripper> References: <20191112141819.GA22076@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191112141819.GA22076@localhost.localdomain> Sender: linux-renesas-soc-owner@vger.kernel.org To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Linus Walleij , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sean Wang , Matthias Brugger , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Chen-Yu Tsai , Paul Cercueil , Neil List-Id: linux-rockchip.vger.kernel.org On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 763da0be10d6..8844ca1261d5 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) > > val = msm_readl_ctl(pctrl, g); > > - /* 0 = output, 1 = input */ > - return val & BIT(g->oe_bit) ? 0 : 1; > + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT : > + GPIO_LINE_DIRECTION_IN; For pinctrl-msm: Reviewed-by: Bjorn Andersson > } Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE3BC352A3 for ; Sat, 15 Feb 2020 05:36:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74F6D2067D for ; Sat, 15 Feb 2020 05:36:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LLMp+YWq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cIxrqNRp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74F6D2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XMg25IZHmoeiM/wJdaPZT1f5GihrfM3t+Jy9K31PmLk=; b=LLMp+YWqG+himm ful9zcIBTSAwW6Dm98LgHrYBoQ1fu9THuwpuWu6DsHxS3g3KdVuEb+gIiuakyEG2uiOmOGJ4T9Jh2 pnVPIjlNewOadBnMvHjwFkk7jxTcWHFoqcCHfDFyHIQ1sJr3yJFOOj5T+kqE2MxY7MjEYq49iIhHS 4vS8yNOdTGo7bCNI4VIXsSeDSazCGMRklRj9w+ideUtkJ4ChJiqmzg3CGyiW1Qvio4YmKoA61RSWt mWDfv/gS+Bc4JQV3Sdp4vR8T6IOc1b4D0tfwDlNbW/h1/aNUrjj/cFLpbx8iieK5iNKqdTXu3mjUI bebId3buO8jhlvs0hygQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2q7i-0004Gs-79; Sat, 15 Feb 2020 05:36:14 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2q7e-0004Fj-Pt for linux-arm-kernel@lists.infradead.org; Sat, 15 Feb 2020 05:36:12 +0000 Received: by mail-pg1-x544.google.com with SMTP id 6so6132085pgk.0 for ; Fri, 14 Feb 2020 21:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=umSLSqFdcTUcW15IlOni/Tuec1i7imfq7Q7J9RYYX4g=; b=cIxrqNRp65WCtK+fiYn9g3PVPZKXWCeUB0uFKNIzbK215QX3Al36Ke7lSPKliczQPG zRn7Bi6DqLKPjlqWNiNyIv1hfnOjroG9dJAo7zBVoxdcOscAu96nnIAHZ0M1KbXjm0Sl ZR04ZlFB/h9Rx1G6+2XpmHZ6qc00E2hKTf9RBjGMhvM/S7iYiuAY2TTttm/rFAuLs3bq Tl4EPCrQfsVTe0Oz0o9vN+XxWzhv+LiQ+CYz/xTgBuLMVClebtR7iuNxNAyHBtWlm0Wp bHYgpgS19tzczImghBSGzs7yS4YbFHy+7+42F6gNr1Xyalax7P6gX0gNY6JBKTkCYKiJ SqhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=umSLSqFdcTUcW15IlOni/Tuec1i7imfq7Q7J9RYYX4g=; b=oKzscZ+eBltwNDAU25exvaLeoxzoamUmjVGOB4yZ+7SXx/S45lInov40dmgQEHDiL0 puO1hlLlx2xtNtmcSZjgcLsUbFwZNIZVZ5Hka7mpltuYgSyrbjMWMMv9CapwqKWjj/0S Ju9C816V+yD26t3Om9/j3miOzYnZLomyD+zzcMi9SWCAp4xr/Khc9oV7NGWHMdRNMcYE mPQde89uLUFoxzrL8/i0y0GcQTTToxrKKoSSLa/u3jp9IzxkCKyunSjtLWclSIS9Vqhw RTSULM7uXQ3Gyqfrvad1oeu254la9aE2Yz4yMdxta7hUQM+vCsjmPsg66GRfUzSyj9U9 PcUA== X-Gm-Message-State: APjAAAV/rLLdx8n8qB0twgK7riJKJGDn41SVUoyoc9XslCOd22f7NMDa sptcZu3jsY0CBOf63mmVNlla/A== X-Google-Smtp-Source: APXvYqzk4mzSWnD3eisseNOAoKEFSWYJ3iXu/MnMV3x1ieUnd9jyOy7C/UGmCSr9X/1fRkBJKg6m3w== X-Received: by 2002:a62:6842:: with SMTP id d63mr6945184pfc.113.1581744969478; Fri, 14 Feb 2020 21:36:09 -0800 (PST) Received: from ripper (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id q12sm8411743pfh.158.2020.02.14.21.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 21:36:08 -0800 (PST) Date: Fri, 14 Feb 2020 21:35:17 -0800 From: Bjorn Andersson To: Matti Vaittinen Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Message-ID: <20200215053517.GN955802@ripper> References: <20191112141819.GA22076@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191112141819.GA22076@localhost.localdomain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_213610_851206_5F9522E8 X-CRM114-Status: GOOD ( 12.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Alexandre Belloni , Heiko Stuebner , Geert Uytterhoeven , Neil Armstrong , Linus Walleij , Patrice Chotard , Paul Cercueil , Eric Anholt , linux-stm32@st-md-mailman.stormreply.com, Alexandre Torgue , Florian Fainelli , Gregory Clement , Chen-Yu Tsai , linux-rockchip@lists.infradead.org, Ludovic Desroches , Andy Gross , bcm-kernel-feedback-list@broadcom.com, linux-arm-msm@vger.kernel.org, Sebastian Hesselbarth , Jason Cooper , mazziesaccount@gmail.com, Ray Jui , linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Scott Branden , Sean Wang , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Stefan Wahren , Maxime Coquelin , linux-oxnas@groups.io Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 763da0be10d6..8844ca1261d5 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) > > val = msm_readl_ctl(pctrl, g); > > - /* 0 = output, 1 = input */ > - return val & BIT(g->oe_bit) ? 0 : 1; > + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT : > + GPIO_LINE_DIRECTION_IN; For pinctrl-msm: Reviewed-by: Bjorn Andersson > } Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel