All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Sean Paul <seanpaul@chromium.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v1 1/1] drm: drop unused drm_display_mode.private
Date: Sat, 15 Feb 2020 21:08:27 +0100	[thread overview]
Message-ID: <20200215200827.GA9276@ravnborg.org> (raw)
In-Reply-To: <CAKMK7uFp5AzCxSeRg=ZibVnD0e8EhrsxYnuLeicUgp3gCr3Lpg@mail.gmail.com>

Hi Daniel.

> > I also checked private_flags - it is used in a few modules.
> > And it looked legit.
> >
> Iirc i915 used this, before we went full overdrive with entire atomic
> state structure subclassing :-)

$ git grep -l private_flags
gma500/psb_intel_drv.h
i915/display/intel_display.c
i915/display/intel_display_types.h
i915/display/intel_tv.c
i915/display/vlv_dsi.c
i915/i915_irq.c
msm/disp/dpu1/dpu_encoder.c
msm/disp/dpu1/dpu_trace.h <= false hit

i915 still has a few uses of private_flags.
Likewise msm and gma500

Looks doable to address this, but not on my TODO list.

	Sam

> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks - applied.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-02-15 20:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-15 18:35 [PATCH v1 1/1] drm: drop unused drm_display_mode.private Sam Ravnborg
2020-02-15 19:11 ` Daniel Vetter
2020-02-15 20:08   ` Sam Ravnborg [this message]
2020-02-16 12:46     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200215200827.GA9276@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.