From: Dave Chinner <david@fromorbit.com>
To: Pavel Reichl <preichl@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v5 1/4] xfs: Refactor xfs_isilocked()
Date: Mon, 17 Feb 2020 09:36:12 +1100 [thread overview]
Message-ID: <20200216223612.GA10776@dread.disaster.area> (raw)
In-Reply-To: <20200214185942.1147742-1-preichl@redhat.com>
On Fri, Feb 14, 2020 at 07:59:39PM +0100, Pavel Reichl wrote:
> Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked().
> __xfs_rwsem_islocked() is a helper function which encapsulates checking
> state of rw_semaphores hold by inode.
>
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
> Suggested-by: Dave Chinner <dchinner@redhat.com>
> Suggested-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/xfs/xfs_inode.c | 54 ++++++++++++++++++++++++++++++++--------------
> fs/xfs/xfs_inode.h | 2 +-
> 2 files changed, 39 insertions(+), 17 deletions(-)
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-02-16 22:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 18:59 [PATCH v5 1/4] xfs: Refactor xfs_isilocked() Pavel Reichl
2020-02-14 18:59 ` [PATCH v5 2/4] xfs: clean up whitespace in xfs_isilocked() calls Pavel Reichl
2020-02-16 22:36 ` Dave Chinner
2020-02-17 13:33 ` Christoph Hellwig
2020-02-14 18:59 ` [PATCH v5 3/4] xfs: xfs_isilocked() can only check a single lock type Pavel Reichl
2020-02-16 22:37 ` Dave Chinner
2020-02-17 13:34 ` Christoph Hellwig
2020-02-14 18:59 ` [PATCH v5 4/4] xfs: replace mrlock_t with rw_semaphores Pavel Reichl
2020-02-16 22:39 ` Dave Chinner
2020-02-17 13:35 ` Christoph Hellwig
2020-02-15 1:38 ` [PATCH v5 1/4] xfs: Refactor xfs_isilocked() Chaitanya Kulkarni
2020-02-17 10:55 ` Pavel Reichl
2020-02-20 16:25 ` Chaitanya Kulkarni
2020-02-16 22:36 ` Dave Chinner [this message]
2020-02-17 13:35 ` Christoph Hellwig
2020-02-19 4:48 ` Darrick J. Wong
2020-02-19 17:31 ` Pavel Reichl
2020-02-19 18:40 ` Christoph Hellwig
2020-02-19 20:16 ` Eric Sandeen
2020-02-20 16:30 ` Pavel Reichl
2020-02-20 16:32 ` Christoph Hellwig
2020-02-20 17:26 ` Eric Sandeen
2020-02-20 17:27 ` Darrick J. Wong
2020-02-21 17:49 ` Pavel Reichl
2020-02-21 20:28 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216223612.GA10776@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.