From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb-storage: Use const to reduce object data size
Date: Mon, 17 Feb 2020 10:40:36 +0100 [thread overview]
Message-ID: <20200217094036.GA47231@kroah.com> (raw)
In-Reply-To: <60559197a1af9e0af7f329cc3427989e5756846f.camel@perches.com>
On Fri, Feb 14, 2020 at 10:15:57AM -0800, Joe Perches wrote:
> Make structs const to reduce data size ~20KB.
>
> Change function arguments and prototypes as necessary to compile.
>
> $ size (x86-64 defconfig pre)
> text data bss dec hex filename
> 12281 10948 480 23709 5c9d ./drivers/usb/storage/usb.o
> 111 10528 8 10647 2997 ./drivers/usb/storage/usual-tables.o
>
> $ size (x86-64 defconfig post)
> text data bss dec hex filename
> 22809 420 480 23709 5c9d drivers/usb/storage/usb.o
> 10551 0 0 10551 2937 drivers/usb/storage/usual-tables.o
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> compile tested only
>
> drivers/usb/storage/usb.c | 10 +++++-----
> drivers/usb/storage/usb.h | 5 +++--
> drivers/usb/storage/usual-tables.c | 6 +++---
> include/linux/usb_usual.h | 2 +-
> 4 files changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
> index 9a79cd..94a6472 100644
> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -121,12 +121,12 @@ MODULE_PARM_DESC(quirks, "supplemental list of
> device IDs and their quirks");
> .initFunction = init_function, \
> }
>
> -static struct us_unusual_dev us_unusual_dev_list[] = {
> +static const struct us_unusual_dev us_unusual_dev_list[] = {
> # include "unusual_devs.h"
> { } /* Terminating entry */
> };
>
> -static struct us_unusual_dev for_dynamic_ids =
> +static const struct us_unusual_dev for_dynamic_ids =
> USUAL_DEV(USB_SC_SCSI, USB_PR_BULK);
>
> #undef UNUSUAL_DEV
> @@ -583,7 +583,7 @@ EXPORT_SYMBOL_GPL(usb_stor_adjust_quirks);
>
> /* Get the unusual_devs entries and the string descriptors */
> static int get_device_info(struct us_data *us, const struct
> usb_device_id *id,
Patch is line-wrapped and does not apply at all :(
next prev parent reply other threads:[~2020-02-17 9:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 18:15 [PATCH] usb-storage: Use const to reduce object data size Joe Perches
2020-02-14 22:01 ` Alan Stern
2020-02-17 9:40 ` Greg Kroah-Hartman [this message]
2020-02-18 0:59 ` [PATCH V2] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217094036.GA47231@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.