From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sudeep Dutt <sudeep.dutt@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
Allison Randal <allison@lohutok.net>,
Richard Fontana <rfontana@redhat.com>
Subject: Re: [PATCH 4/5] mm/vma: Replace all remaining open encodings with vma_set_anonymous()
Date: Mon, 17 Feb 2020 13:27:27 +0300 [thread overview]
Message-ID: <20200217102727.cmd74il6nxfgzvkh@box> (raw)
In-Reply-To: <1581915833-21984-5-git-send-email-anshuman.khandual@arm.com>
On Mon, Feb 17, 2020 at 10:33:52AM +0530, Anshuman Khandual wrote:
> This replaces all remaining open encodings with vma_set_anonymous().
>
> Cc: Sudeep Dutt <sudeep.dutt@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Kate Stewart <kstewart@linuxfoundation.org>
> Cc: Allison Randal <allison@lohutok.net>
> Cc: Richard Fontana <rfontana@redhat.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> drivers/misc/mic/scif/scif_mmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mic/scif/scif_mmap.c b/drivers/misc/mic/scif/scif_mmap.c
> index a151d416f39c..1f0dec5df994 100644
> --- a/drivers/misc/mic/scif/scif_mmap.c
> +++ b/drivers/misc/mic/scif/scif_mmap.c
> @@ -580,7 +580,7 @@ static void scif_munmap(struct vm_area_struct *vma)
> * The kernel probably zeroes these out but we still want
> * to clean up our own mess just in case.
> */
> - vma->vm_ops = NULL;
> + vma_set_anonymous(vma);
> vma->vm_private_data = NULL;
> kref_put(&vmapvt->ref, vma_pvt_release);
> scif_delete_vma(ep, vma);
This is misleading. The VMA doesn't become anonymous here. This is undo of
the previously overwritten vm_ops. I think we should leave it opencodded.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2020-02-17 10:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 5:03 [PATCH 0/5] mm/vma: Use available wrappers when possible Anshuman Khandual
2020-02-17 5:15 ` Anshuman Khandual
2020-02-17 5:03 ` Anshuman Khandual
2020-02-17 5:03 ` [PATCH 1/5] mm/vma: Add missing VMA flag readable name for VM_SYNC Anshuman Khandual
2020-02-17 5:03 ` [PATCH 2/5] mm/vma: Make vma_is_accessible() available for general use Anshuman Khandual
2020-02-17 5:15 ` Anshuman Khandual
2020-02-17 5:03 ` Anshuman Khandual
2020-02-17 7:36 ` Geert Uytterhoeven
2020-02-17 7:36 ` Geert Uytterhoeven
2020-02-17 7:36 ` Geert Uytterhoeven
2020-02-17 9:28 ` Anshuman Khandual
2020-02-17 9:40 ` Anshuman Khandual
2020-02-17 9:28 ` Anshuman Khandual
2020-02-18 2:21 ` Guo Ren
2020-02-18 2:21 ` Guo Ren
2020-02-18 2:21 ` Guo Ren
2020-02-17 5:03 ` [PATCH 3/5] mm/vma: Replace all remaining open encodings with is_vm_hugetlb_page() Anshuman Khandual
2020-02-17 5:15 ` Anshuman Khandual
2020-02-17 5:03 ` Anshuman Khandual
2020-02-17 9:21 ` Anshuman Khandual
2020-02-17 9:33 ` Anshuman Khandual
2020-02-17 9:21 ` Anshuman Khandual
2020-02-19 1:14 ` kbuild test robot
2020-02-19 1:14 ` kbuild test robot
2020-02-24 2:21 ` Anshuman Khandual
2020-02-24 2:21 ` Anshuman Khandual
2020-02-17 5:03 ` [PATCH 4/5] mm/vma: Replace all remaining open encodings with vma_set_anonymous() Anshuman Khandual
2020-02-17 10:27 ` Kirill A. Shutemov [this message]
2020-02-17 11:56 ` Anshuman Khandual
2020-03-18 10:24 ` Greg Kroah-Hartman
2020-03-18 10:41 ` Anshuman Khandual
2020-02-17 5:03 ` [PATCH 5/5] mm/vma: Replace all remaining open encodings with vma_is_anonymous() Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217102727.cmd74il6nxfgzvkh@box \
--to=kirill@shutemov.name \
--cc=allison@lohutok.net \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=ashutosh.dixit@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rfontana@redhat.com \
--cc=sudeep.dutt@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.