From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-6749-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id DF0D098432C for ; Mon, 17 Feb 2020 10:02:27 +0000 (UTC) Date: Mon, 17 Feb 2020 11:02:22 +0100 From: Boris Brezillon Message-ID: <20200217110222.2c4f2bef@collabora.com> In-Reply-To: References: <20200207182842.770bfb27@collabora.com> MIME-Version: 1.0 Subject: [virtio-dev] Re: [RFC] Upstreaming virtio-wayland (or an alternative) Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable To: David Stevens Cc: Gerd Hoffmann , Stefan Hajnoczi , Zach Reizner , =?UTF-8?B?U3Q=?= =?UTF-8?B?w6lwaGFuZQ==?= Marchesin , Tomeu Vizoso , Tomasz Figa , virtio-dev@lists.oasis-open.org, Alexandros Frantzis List-ID: Hi David, On Mon, 10 Feb 2020 14:06:21 +0900 David Stevens wrote: > > FD <-> VFD mappings would have to be created > > by the subsystem in charge of the object backing the FD (virtio-gpu for > > exported GEM buffers, virtio-vdec for video buffers, vsock for unix > > sockets if we decide to bridge unix and vsock sockets to make it > > transparent, ...). The FD <-> VFD mapping would also have to be created > > on the host side, probably by the virtio device implementation > > (virglrenderer for GEM bufs for instance), which means host and guest > > need a way to inform the other end that a new FD <-> VFD mapping has > > been created so the other end can create a similar mapping (I guess thi= s > > requires extra device-specific commands to work). =20 >=20 > My recent proposal for cross device resource sharing seems like it > could be relevant here: https://markmail.org/thread/jsaoqy7phrqdcpqu. Thanks for sharing this link. I had a quick look at this proposal, and,=20 maybe I'm wrong, but I'm not sure it actually addresses Tomasz' concern [1] if we keep letting a userspace proxy do the FD <-> UUID conversion and sending the UUID through the VSOCK. To me, a UUID only guarantees that 2 buffers will get different UUIDs (assuming they use the same algorithm to generate this UUID), but nothing prevents a malicious app from opening a connection to the host proxy and sending valid wayland messages with forged UUIDs, in the hope that one of them will match an already exported resource. Regards, Boris [1]https://www.spinics.net/lists/kvm/msg185688.html --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org