From: Quentin Perret <qperret@google.com>
To: masahiroy@kernel.org, nico@fluxnic.net
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
maennich@google.com, kernel-team@android.com, jeyu@kernel.org,
hch@infradead.org
Subject: Re: [PATCH v4 1/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS
Date: Mon, 17 Feb 2020 14:23:22 +0000 [thread overview]
Message-ID: <20200217142322.GA183353@google.com> (raw)
In-Reply-To: <20200212202140.138092-2-qperret@google.com>
On Wednesday 12 Feb 2020 at 20:21:38 (+0000), Quentin Perret wrote:
> diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
> index a904bf1f5e67..93f4d10e66e6 100755
> --- a/scripts/adjust_autoksyms.sh
> +++ b/scripts/adjust_autoksyms.sh
> @@ -38,6 +38,10 @@ esac
> # We need access to CONFIG_ symbols
> . include/config/auto.conf
>
> +# Use 'eval' to expand the whitelist path and check if it is relative
> +eval ksym_wl="${CONFIG_UNUSED_KSYMS_WHITELIST:-/dev/null}"
> +[ "${ksym_wl:0:1}" = "/" ] || ksym_wl="$abs_srctree/$ksym_wl"
Our internal CI just informed me that this is *still* not quite POSIX
compliant ... I believe that the following should (finally) solve this
issue:
[ "${ksym_wl}" != "${ksym_wl#/}" ] || ksym_wl="$abs_srctree/$ksym_wl"
The above seems to work with bash, zsh, dash, posh and, IIUC, complies
with https://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html.
I'll try other shells and stare at the doc some more, but if there is a
preferred pattern in the kernel I'm happy to change it.
Thanks,
Quentin
next prev parent reply other threads:[~2020-02-17 14:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 20:21 [PATCH v4 0/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYM Quentin Perret
2020-02-12 20:21 ` [PATCH v4 1/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS Quentin Perret
2020-02-17 14:23 ` Quentin Perret [this message]
2020-02-17 15:22 ` Matthias Maennich
2020-02-17 15:30 ` Quentin Perret
2020-02-17 16:00 ` Nicolas Pitre
2020-02-17 16:35 ` Matthias Maennich
2020-02-12 20:21 ` [PATCH v4 2/3] kbuild: split adjust_autoksyms.sh in two parts Quentin Perret
2020-02-17 15:37 ` Matthias Maennich
2020-02-12 20:21 ` [PATCH v4 3/3] kbuild: generate autoksyms.h early Quentin Perret
2020-02-17 16:34 ` Matthias Maennich
2020-02-12 20:48 ` [PATCH v4 0/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYM Nicolas Pitre
2020-02-12 20:53 ` Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217142322.GA183353@google.com \
--to=qperret@google.com \
--cc=hch@infradead.org \
--cc=jeyu@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=masahiroy@kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.