All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Conor Culhane <conor.culhane@silvaco.com>
Cc: linux-i3c@lists.infradead.org, bbrezillon@kernel.org
Subject: Re: [PATCH] Add a driver for Silvaco I3C Dual-Role Master IP
Date: Mon, 17 Feb 2020 15:34:31 +0100	[thread overview]
Message-ID: <20200217153431.06d695d0@collabora.com> (raw)
In-Reply-To: <20200211154332.21764-1-conor.culhane@silvaco.com>

Hello Conor,

On Tue, 11 Feb 2020 10:43:32 -0500
Conor Culhane <conor.culhane@silvaco.com> wrote:

Can you add a commit message here?


> Signed-off-by: Conor Culhane <conor.culhane@silvaco.com>
> ---
>  drivers/i3c/master/Kconfig          |    8 +
>  drivers/i3c/master/Makefile         |    1 +
>  drivers/i3c/master/svc-i3c-master.c | 2863 +++++++++++++++++++++++++++

There are several coding-style issues (camel case, use of typedefs,
...). Can you please run 'scripts/checkpatch.pl --strict' on your patch
and post a new version with all those coding-style issues fixed?

Thanks,

Boris

_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

      reply	other threads:[~2020-02-17 14:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 15:43 [PATCH] Add a driver for Silvaco I3C Dual-Role Master IP Conor Culhane
2020-02-17 14:34 ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200217153431.06d695d0@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=bbrezillon@kernel.org \
    --cc=conor.culhane@silvaco.com \
    --cc=linux-i3c@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.