From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: brouer@redhat.com, lorenzo@kernel.org, netdev@vger.kernel.org,
ilias.apalodimas@linaro.org, dsahern@kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] net: mvneta: introduce xdp counters to ethtool
Date: Mon, 17 Feb 2020 23:38:37 +0100 [thread overview]
Message-ID: <20200217223837.GA5669@lore-desk-wlan> (raw)
In-Reply-To: <20200217.141850.2134390863127670308.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
> From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Date: Mon, 17 Feb 2020 11:25:50 +0100
>
> > yes, I think it is definitely better. So to follow up:
> > - rename current "xdp_tx" counter in "xdp_xmit" and increment it for
> > XDP_TX verdict and for ndo_xdp_xmit
> > - introduce a new "xdp_tx" counter only for XDP_TX verdict.
> >
> > If we agree I can post a follow-up patch.
>
> What names do other drivers use? Consistency is important. I noticed
> while reviewing these patches that mellanox drivers export similar
> statistics in the exact same way.
According to David's suggestion, I am following mellanox implementation
adding "rx_" prefix for xdp actions on rx path and, based on Jesper's comment,
I am differentiating between XDP_TX and ndo_xdp_xmit.
So, to follow up:
XDP_TX: rx_xdp_tx_xmit
XDP_DROP: rx_xdp_drop
XDP_PASS: rx_xdp_pass
XDP_REDIRECT: rx_xdp_redirect
ndo_xdp_xmit: tx_xdp_xmit
I will post a RFC patch soon.
Regards,
Lorenzo
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-02-17 22:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 21:07 [PATCH net-next 0/5] add xdp ethtool stats to mvneta driver Lorenzo Bianconi
2020-02-16 21:07 ` [PATCH net-next 1/5] net: mvneta: move refill_err and skb_alloc_err in per-cpu stats Lorenzo Bianconi
2020-02-16 21:07 ` [PATCH net-next 2/5] net: mvneta: rely on open-coding updating stats for non-xdp and tx path Lorenzo Bianconi
2020-02-16 21:07 ` [PATCH net-next 3/5] net: mvneta: rely on struct mvneta_stats in mvneta_update_stats routine Lorenzo Bianconi
2020-02-16 21:07 ` [PATCH net-next 4/5] net: mvneta: introduce xdp counters to ethtool Lorenzo Bianconi
2020-02-17 10:17 ` Jesper Dangaard Brouer
2020-02-17 10:25 ` Lorenzo Bianconi
2020-02-17 10:32 ` Jesper Dangaard Brouer
2020-02-17 13:05 ` Andrew Lunn
2020-02-17 14:51 ` Jesper Dangaard Brouer
2020-02-17 18:17 ` David Ahern
2020-02-17 22:18 ` David Miller
2020-02-17 22:38 ` Lorenzo Bianconi [this message]
2020-02-16 21:07 ` [PATCH net-next 5/5] net: mvneta: get rid of xdp_ret in mvneta_swbm_rx_frame Lorenzo Bianconi
2020-02-17 4:04 ` [PATCH net-next 0/5] add xdp ethtool stats to mvneta driver David Miller
2020-02-17 9:58 ` Jesper Dangaard Brouer
2020-02-17 22:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217223837.GA5669@lore-desk-wlan \
--to=lorenzo.bianconi@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.