From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/3] Redesign TST_RETRY_FUNC()
Date: Tue, 18 Feb 2020 09:05:58 +0100 [thread overview]
Message-ID: <20200218080558.GA19384@dell5510> (raw)
In-Reply-To: <0090dabb-76fa-ea3d-2f96-4c4e50146bba@suse.cz>
Hi Martin,
> On 2/8/20 7:35 AM, Li Wang wrote:
> > 1. We need to update the doc/test-writing-guidelines.txt?too.
> Right. I'll resubmit in a moment.
Thanks!
> > 2. Maybe better to let the shell version is consistent with this new?
> That doesn't make much sense. Shell programs and functions have much
> simpler call conventions than C functions. If you really need to test a
> more complex result than a single return value in shell, writing a
> wrapper function is much easier than writing a validator function.
> In C, it's the other way around. Writing a wrapper function would often
> be a ton of work compared to writing a simple retval validator macro.
+1.
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-18 8:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 11:22 [LTP] [PATCH v2 1/3] Redesign TST_RETRY_FUNC() Martin Doucha
2020-02-07 11:22 ` [LTP] [PATCH v2 2/3] Split off executable code from bpf/bpf_common.h Martin Doucha
2020-02-07 11:22 ` [LTP] [PATCH v2 3/3] Fix BPF test program loading issues Martin Doucha
2020-02-07 11:29 ` [LTP] [PATCH v2 1/3] Redesign TST_RETRY_FUNC() Martin Doucha
2020-02-08 6:35 ` Li Wang
2020-02-17 14:16 ` Martin Doucha
2020-02-18 8:05 ` Petr Vorel [this message]
2020-02-18 8:10 ` Li Wang
2020-02-17 14:16 ` [LTP] [PATCH v3 " Martin Doucha
2020-02-17 14:16 ` [LTP] [PATCH v3 2/3] Split off executable code from bpf/bpf_common.h Martin Doucha
2020-02-18 8:15 ` Li Wang
2020-02-18 8:44 ` Martin Doucha
2020-02-18 8:49 ` Li Wang
2020-02-18 8:53 ` Petr Vorel
2020-02-18 9:43 ` Martin Doucha
2020-02-18 8:55 ` Petr Vorel
2020-02-17 14:16 ` [LTP] [PATCH v3 3/3] Fix BPF test program loading issues Martin Doucha
2020-02-18 8:07 ` Petr Vorel
2020-02-18 8:58 ` Petr Vorel
2020-02-18 8:06 ` [LTP] [PATCH v3 1/3] Redesign TST_RETRY_FUNC() Petr Vorel
2020-02-18 9:45 ` [LTP] [PATCH v4 2/3] Split off executable code from bpf/bpf_common.h Martin Doucha
2020-02-18 9:45 ` [LTP] [PATCH v4 3/3] Fix BPF test program loading issues Martin Doucha
2020-02-18 15:14 ` [LTP] [PATCH v3 1/3] Redesign TST_RETRY_FUNC() Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218080558.GA19384@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.