From: Shawn Guo <shawnguo@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
wg@grandegger.com, netdev@vger.kernel.org,
linux-can@vger.kernel.org, Pankaj Bansal <pankaj.bansal@nxp.com>
Subject: Re: [PATCH 0/8] can: flexcan: add CAN FD support for NXP Flexcan
Date: Tue, 18 Feb 2020 17:33:51 +0800 [thread overview]
Message-ID: <20200218093346.GC6075@dragon> (raw)
In-Reply-To: <0d02f6cee0d3a680f246e8fea40f6699@walle.cc>
On Mon, Feb 17, 2020 at 09:48:36AM +0100, Michael Walle wrote:
> > My opinion is that all compatibles should be defined explicitly in
> > bindings doc. In above example, the possible values of <processor>
> > should be given. This must be done anyway, as we are moving to
> > json-schema bindings.
>
> But if they are listed in the document, they also have to be in the
> of_device_id table, correct?
I do not think so. Documenting compatibles used in DTS now doesn't
necessarily mean we need to use it in kernel driver right away.
Bindings doc is a specification for device tree, not kernel. With the
compatible in DTS and bindings, kernel can start using it at any time
when there is a need, like dealing with SoC quirks or bugs found later.
Shawn
> Which somehow contradicts the talk Pankaj
> mentioned [1,2]. Eg.
>
> compatible = "fsl,ls1028ar1-flexcan","fsl,lx2160ar1-flexcan";
>
> Doesn't make any sense, because the "fsl,ls1028ar1-flexcan" is alreay
> in the driver and the fallback "fsl,lx2160ar1-flexcan" isn't needed.
>
> OTOH the talk is already 2 to 3 years old and things might have changed
> since then.
>
> -michael
>
> [1] https://elinux.org/images/0/0e/OSELAS.Presentation-ELCE2017-DT.pdf
> [2] https://www.youtube.com/watch?v=6iguKSJJfxo
next prev parent reply other threads:[~2020-02-18 9:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 8:02 [PATCH 0/8] can: flexcan: add CAN FD support for NXP Flexcan Joakim Zhang
2019-07-12 8:02 ` [PATCH 1/8] can: flexcan: allocate skb in flexcan_mailbox_read Joakim Zhang
2019-07-12 8:02 ` [PATCH 2/8] can: flexcan: use struct canfd_frame for CAN classic frame Joakim Zhang
2019-07-12 8:02 ` [PATCH 3/8] can: flexcan: add CAN FD mode support Joakim Zhang
2019-07-12 8:02 ` [PATCH 4/8] can: flexcan: add CANFD BRS support Joakim Zhang
2019-07-12 8:02 ` [PATCH 5/8] can: flexcan: add ISO CAN FD feature support Joakim Zhang
2019-07-12 8:02 ` [PATCH 6/8] can: flexcan: add Transceiver Delay Compensation suopport Joakim Zhang
2019-07-12 8:02 ` [PATCH 7/8] can: flexcan: add imx8qm support Joakim Zhang
2019-07-12 8:03 ` [PATCH 8/8] can: flexcan: add lx2160ar1 support Joakim Zhang
2019-07-25 7:38 ` [PATCH 0/8] can: flexcan: add CAN FD support for NXP Flexcan Joakim Zhang
2019-07-25 7:53 ` Marc Kleine-Budde
2019-07-25 10:37 ` Marc Kleine-Budde
2019-07-26 1:25 ` Joakim Zhang
2020-02-13 19:20 ` Michael Walle
2020-02-14 1:55 ` Joakim Zhang
2020-02-14 8:42 ` Michael Walle
2020-02-14 9:18 ` Joakim Zhang
2020-02-14 9:33 ` Michael Walle
2020-02-14 9:56 ` Joakim Zhang
2020-02-14 10:02 ` Michael Walle
2020-02-17 7:13 ` Shawn Guo
2020-02-17 8:48 ` Michael Walle
2020-02-18 9:33 ` Shawn Guo [this message]
2020-02-14 10:01 ` Pankaj Bansal
2020-02-14 10:18 ` Michael Walle
2020-02-24 9:58 ` Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218093346.GC6075@dragon \
--to=shawnguo@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=michael@walle.cc \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
--cc=qiangqing.zhang@nxp.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.