From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"
Date: Tue, 18 Feb 2020 11:36:55 +0200 [thread overview]
Message-ID: <20200218093655.GG10400@smile.fi.intel.com> (raw)
In-Reply-To: <CAK7LNAQhepu3u80zdDxCZ6rWkh_H1B1UuUwTy+vVjPdrfQv9JA@mail.gmail.com>
On Tue, Feb 18, 2020 at 09:45:34AM +0900, Masahiro Yamada wrote:
> On Tue, Feb 18, 2020 at 12:30 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > This reverts commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12.
> >
> > As real hardware testing (*) shows the above mentioned commit
> > breaks U-Boot on it. Revert for the upcoming release. We may get
> > more information in the future and optimize the code accordingly.
> >
> > (*) om Intel Edison board.
> Reverting arch/x86/cpu/start.S is enough, isn't it?
Had you tested on real hardware?
Since Qemu ~= "no test" for the available hardware, I can't answer to this.
> arch/x86/cpu/start16.S is not compiled for the
> Edison board.
>
> start16.S is the start of the Real Mode,
> and we are sure no program was running before
> U-Boot.
To be on the safer side I prefer to revert completely. Then you may come up
with a new patch with better commit message and testing. To me it sounds fair.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-02-18 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 15:30 [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code" Andy Shevchenko
2020-02-18 0:24 ` Bin Meng
2020-02-18 9:37 ` Andy Shevchenko
2020-02-20 13:43 ` Bin Meng
2020-02-18 0:45 ` Masahiro Yamada
2020-02-18 9:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218093655.GG10400@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.