From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D611EC34026 for ; Tue, 18 Feb 2020 10:46:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9A7F206E2 for ; Tue, 18 Feb 2020 10:46:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AepwB2Ry" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9A7F206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tonyv9QwxvrOOiA6SjdE5CHZwr71Xu/aZBJHnKtAq54=; b=AepwB2RyyEOOoC S3hrH9/Ab0VM451KkaduPdrGRafYqv6j7K3HUVmrSLEw31FUK7M9fb8DtYslKZrPvSUQF8h9fWbsS NeaM4Cu6K5Ui+L7UmAUBBEh0vHn5kN4sFd58rn8qfazHJn3iCWOpCAEtU5B+ijEgn8L2wq6vZb92T Q4Hzns7kBkkR94L/JFfnJrzd3Gl/ezcxdyQspCCt1L/cV3qu8FoKnEM5C5ih8dTc31YVrjc8pcMnf OAkhWnbQBmERSrpABHb8Lah/NMgCsG9T+nG781hHUo8oM6QOlhRR37PSTR5TZ8q+0+oLaIec2z9vb i6T48oVw9mPCDD9UhZUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j40OL-0004ac-Df; Tue, 18 Feb 2020 10:46:13 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j40OG-0004ZO-UK for linux-mtd@lists.infradead.org; Tue, 18 Feb 2020 10:46:10 +0000 X-Originating-IP: 90.76.211.102 Received: from xps13 (lfbn-tou-1-1151-102.w90-76.abo.wanadoo.fr [90.76.211.102]) (Authenticated sender: miquel.raynal@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id B9E5140017; Tue, 18 Feb 2020 10:45:53 +0000 (UTC) Date: Tue, 18 Feb 2020 11:45:53 +0100 From: Miquel Raynal To: Piotr Sroka Subject: Re: [PATCH 2/4] mtd: rawnand: cadence: fix calculating avaialble oob size Message-ID: <20200218114537.723436b3@xps13> In-Reply-To: <1581328530-29966-2-git-send-email-piotrs@cadence.com> References: <1581328530-29966-1-git-send-email-piotrs@cadence.com> <1581328530-29966-2-git-send-email-piotrs@cadence.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200218_024609_113900_29C86020 X-CRM114-Status: GOOD ( 14.10 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Richard Weinberger , linux-kernel@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse , Kazuhiro Kasai Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgUGlvdHIsCgpQaW90ciBTcm9rYSA8cGlvdHJzQGNhZGVuY2UuY29tPiB3cm90ZSBvbiBNb24s IDEwIEZlYiAyMDIwIDEwOjU1OjI2CiswMTAwOgoKVGhlcmUgaXMgYSB0eXBvIGluIHRoZSB0aXRs ZSAoYXZhaWxhYmxlKS4KCj4gUHJldmlvdXNseSBlY2Nfc2VjdG9yIHNpemUgd2FzIHVzZWQgZm9y IGNhbGN1bGF0aW9uIGJ1dCBpdHMgdmFsdWUKPiB3YXMgbm90IHlldCBrbm93bi4KCkNhbiB3ZSBy ZXdvcmsgYSBsaXR0bGUgYml0IHRoaXM/IFdoYXQgYWJvdXQ6CgoJVGhlIHZhbHVlIG9mIGNkbnNf Y2hpcC0+c2VjdG9yX2NvdW50IGlzIG5vdCBrbm93biBhdCB0aGUgbW9tZW50CglvZiB0aGUgZGVy aXZhdGlvbiBvZiBlY2Nfc2l6ZSwgbGVhZGluZyB0byBhIHplcm8gdmFsdWUuIEZpeAoJdGhpcyBi eSBhc3NpZ25pbmcgZWNjX3NpemUgbGF0ZXIgaW4gdGhlIGNvZGUuCgpBbHNvLCBJIHRoaW5rIGl0 IGRlc2VydmVzIGEgRml4ZXMvQ2M6c3RhYmxlIHRhZyEKCj4gCj4gU2lnbmVkLW9mZi1ieTogUGlv dHIgU3Jva2EgPHBpb3Ryc0BjYWRlbmNlLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9y YXcvY2FkZW5jZS1uYW5kLWNvbnRyb2xsZXIuYyB8IDMgKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAy IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9t dGQvbmFuZC9yYXcvY2FkZW5jZS1uYW5kLWNvbnRyb2xsZXIuYyBiL2RyaXZlcnMvbXRkL25hbmQv cmF3L2NhZGVuY2UtbmFuZC1jb250cm9sbGVyLmMKPiBpbmRleCA1MDYzYThiNDkzYTQuLjJlYmZk MDkzNDczOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9jYWRlbmNlLW5hbmQt Y29udHJvbGxlci5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvY2FkZW5jZS1uYW5kLWNv bnRyb2xsZXIuYwo+IEBAIC0yNTk1LDcgKzI1OTUsNyBAQCBpbnQgY2FkZW5jZV9uYW5kX2F0dGFj aF9jaGlwKHN0cnVjdCBuYW5kX2NoaXAgKmNoaXApCj4gIHsKPiAgCXN0cnVjdCBjZG5zX25hbmRf Y3RybCAqY2Ruc19jdHJsID0gdG9fY2Ruc19uYW5kX2N0cmwoY2hpcC0+Y29udHJvbGxlcik7Cj4g IAlzdHJ1Y3QgY2Ruc19uYW5kX2NoaXAgKmNkbnNfY2hpcCA9IHRvX2NkbnNfbmFuZF9jaGlwKGNo aXApOwo+IC0JdTMyIGVjY19zaXplID0gY2Ruc19jaGlwLT5zZWN0b3JfY291bnQgKiBjaGlwLT5l Y2MuYnl0ZXM7Cj4gKwl1MzIgZWNjX3NpemU7Cj4gIAlzdHJ1Y3QgbXRkX2luZm8gKm10ZCA9IG5h bmRfdG9fbXRkKGNoaXApOwo+ICAJaW50IHJldDsKPiAgCj4gQEAgLTI2MzQsNiArMjYzNCw3IEBA IGludCBjYWRlbmNlX25hbmRfYXR0YWNoX2NoaXAoc3RydWN0IG5hbmRfY2hpcCAqY2hpcCkKPiAg CS8qIEVycm9yIGNvcnJlY3Rpb24gY29uZmlndXJhdGlvbi4gKi8KPiAgCWNkbnNfY2hpcC0+c2Vj dG9yX3NpemUgPSBjaGlwLT5lY2Muc2l6ZTsKPiAgCWNkbnNfY2hpcC0+c2VjdG9yX2NvdW50ID0g bXRkLT53cml0ZXNpemUgLyBjZG5zX2NoaXAtPnNlY3Rvcl9zaXplOwo+ICsJZWNjX3NpemUgPSBj ZG5zX2NoaXAtPnNlY3Rvcl9jb3VudCAqIGNoaXAtPmVjYy5ieXRlczsKPiAgCj4gIAljZG5zX2No aXAtPmF2YWlsX29vYl9zaXplID0gbXRkLT5vb2JzaXplIC0gZWNjX3NpemU7Cj4gIAoKVGhhbmtz LApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DFB0C34035 for ; Tue, 18 Feb 2020 10:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D206206E2 for ; Tue, 18 Feb 2020 10:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbgBRKp4 convert rfc822-to-8bit (ORCPT ); Tue, 18 Feb 2020 05:45:56 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:59775 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgBRKpz (ORCPT ); Tue, 18 Feb 2020 05:45:55 -0500 X-Originating-IP: 90.76.211.102 Received: from xps13 (lfbn-tou-1-1151-102.w90-76.abo.wanadoo.fr [90.76.211.102]) (Authenticated sender: miquel.raynal@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id B9E5140017; Tue, 18 Feb 2020 10:45:53 +0000 (UTC) Date: Tue, 18 Feb 2020 11:45:53 +0100 From: Miquel Raynal To: Piotr Sroka Cc: Kazuhiro Kasai , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Vignesh Raghavendra , , Subject: Re: [PATCH 2/4] mtd: rawnand: cadence: fix calculating avaialble oob size Message-ID: <20200218114537.723436b3@xps13> In-Reply-To: <1581328530-29966-2-git-send-email-piotrs@cadence.com> References: <1581328530-29966-1-git-send-email-piotrs@cadence.com> <1581328530-29966-2-git-send-email-piotrs@cadence.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Piotr, Piotr Sroka wrote on Mon, 10 Feb 2020 10:55:26 +0100: There is a typo in the title (available). > Previously ecc_sector size was used for calculation but its value > was not yet known. Can we rework a little bit this? What about: The value of cdns_chip->sector_count is not known at the moment of the derivation of ecc_size, leading to a zero value. Fix this by assigning ecc_size later in the code. Also, I think it deserves a Fixes/Cc:stable tag! > > Signed-off-by: Piotr Sroka > --- > drivers/mtd/nand/raw/cadence-nand-controller.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c > index 5063a8b493a4..2ebfd0934739 100644 > --- a/drivers/mtd/nand/raw/cadence-nand-controller.c > +++ b/drivers/mtd/nand/raw/cadence-nand-controller.c > @@ -2595,7 +2595,7 @@ int cadence_nand_attach_chip(struct nand_chip *chip) > { > struct cdns_nand_ctrl *cdns_ctrl = to_cdns_nand_ctrl(chip->controller); > struct cdns_nand_chip *cdns_chip = to_cdns_nand_chip(chip); > - u32 ecc_size = cdns_chip->sector_count * chip->ecc.bytes; > + u32 ecc_size; > struct mtd_info *mtd = nand_to_mtd(chip); > int ret; > > @@ -2634,6 +2634,7 @@ int cadence_nand_attach_chip(struct nand_chip *chip) > /* Error correction configuration. */ > cdns_chip->sector_size = chip->ecc.size; > cdns_chip->sector_count = mtd->writesize / cdns_chip->sector_size; > + ecc_size = cdns_chip->sector_count * chip->ecc.bytes; > > cdns_chip->avail_oob_size = mtd->oobsize - ecc_size; > Thanks, Miquèl