From: Jason Gunthorpe <jgg@ziepe.ca>
To: Lang Cheng <chenglang@huawei.com>
Cc: dledford@redhat.com, leon@kernel.org, davem@davemloft.net,
salil.mehta@huawei.com, yisen.zhuang@huawei.com,
linuxarm@huawei.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [RFC rdma-next] RDMA/core: Add attribute WQ_MEM_RECLAIM to workqueue "infiniband"
Date: Tue, 18 Feb 2020 11:31:56 -0400 [thread overview]
Message-ID: <20200218153156.GD31668@ziepe.ca> (raw)
In-Reply-To: <1581996935-46507-1-git-send-email-chenglang@huawei.com>
On Tue, Feb 18, 2020 at 11:35:35AM +0800, Lang Cheng wrote:
> The hns3 driver sets "hclge_service_task" workqueue with
> WQ_MEM_RECLAIM flag in order to guarantee forward progress
> under memory pressure.
Don't do that. WQ_MEM_RECLAIM is only to be used by things interlinked
with reclaimed processing.
Work on queues marked with WQ_MEM_RECLAIM can't use GFP_KERNEL
allocations, can't do certain kinds of sleeps, can't hold certain
kinds of locks, etc.
Jason
next prev parent reply other threads:[~2020-02-18 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 3:35 [RFC rdma-next] RDMA/core: Add attribute WQ_MEM_RECLAIM to workqueue "infiniband" Lang Cheng
2020-02-18 15:31 ` Jason Gunthorpe [this message]
2020-02-19 1:13 ` Yunsheng Lin
2020-02-19 6:45 ` Leon Romanovsky
2020-02-19 7:40 ` Yunsheng Lin
2020-02-19 11:07 ` Leon Romanovsky
2020-02-20 1:16 ` Yunsheng Lin
2020-02-19 13:04 ` Jason Gunthorpe
2020-02-20 1:06 ` Yunsheng Lin
2020-02-20 17:46 ` Alexander Duyck
2020-02-21 1:44 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218153156.GD31668@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=chenglang@huawei.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.