From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v1] usb: core: Make use of acpi_evaluate_object() status
Date: Tue, 18 Feb 2020 20:33:47 +0200 [thread overview]
Message-ID: <20200218183347.GL10400@smile.fi.intel.com> (raw)
In-Reply-To: <511c8750-b188-82a1-e839-6b136e5c727c@cogentembedded.com>
On Tue, Feb 18, 2020 at 09:17:47PM +0300, Sergei Shtylyov wrote:
> On 02/18/2020 07:09 PM, Andy Shevchenko wrote:
...
> > + if (!upc || (upc->type != ACPI_TYPE_PACKAGE) || upc->package.count != 4) {
> > goto out;
> > }
>
> I'd drop {} here, while at it.
Yep, makes sense, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-02-18 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 16:09 [PATCH v1] usb: core: Make use of acpi_evaluate_object() status Andy Shevchenko
2020-02-18 18:17 ` Sergei Shtylyov
2020-02-18 18:33 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218183347.GL10400@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.