From: Mark Brown <broonie@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: Applied "ASoC: core: ensure component names are unique" to the asoc tree
Date: Tue, 18 Feb 2020 19:03:14 +0000 [thread overview]
Message-ID: <20200218190314.GM4232@sirena.org.uk> (raw)
In-Reply-To: <1jblpvraho.fsf@starbuckisacylon.baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On Tue, Feb 18, 2020 at 07:55:31PM +0100, Jerome Brunet wrote:
> 1) Multiple components :
> I found out that in fact it is common for linux devices to register
> multiple components. For most, it is a combination of the dmaengine
> generic and the actual device component, but other register more
> component. Ex:
> - vc4-hdmi
> - atmel-classd
> - atmel-pdmic
> - cros-ec-codec
> - mtXXXX-afe-pcm
> I suspect these trigger the debugfs warning
> Even dummy register two components :D
I hadn't realized we have so many - I'd have expected the debugfs
complaints would've been noticable to people, I was hoping based on the
initial discussion that it was just a couple of quick fixed needed.
Guess not :/
Anyway, I agree that a revert is probably sensible for the time being
and getting this done is more involved - can you send patches doing the
revert with a changelog explaining the rationale please?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-02-18 19:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:47 [alsa-devel] [PATCH RFC] ASoC: core: ensure component names are unique Jerome Brunet
2020-02-14 13:47 ` Jerome Brunet
2020-02-14 20:56 ` [alsa-devel] Applied "ASoC: core: ensure component names are unique" to the asoc tree Mark Brown
2020-02-14 20:56 ` Mark Brown
2020-02-17 12:13 ` [alsa-devel] " Marek Szyprowski
2020-02-17 12:13 ` Marek Szyprowski
2020-02-17 13:18 ` [alsa-devel] " Jerome Brunet
2020-02-17 13:18 ` Jerome Brunet
2020-02-17 14:36 ` [alsa-devel] " Marek Szyprowski
2020-02-17 14:36 ` Marek Szyprowski
2020-02-17 17:23 ` [alsa-devel] " Stefan Wahren
2020-02-17 17:23 ` Stefan Wahren
2020-02-17 18:06 ` [RFT/DONTMERGE] ASoC: devm_snd_soc_register_component fixup Jerome Brunet
2020-02-17 18:06 ` Jerome Brunet
2020-02-18 6:47 ` Marek Szyprowski
2020-02-18 6:47 ` Marek Szyprowski
2020-02-18 9:32 ` Jerome Brunet
2020-02-18 9:32 ` Jerome Brunet
2020-02-17 13:22 ` [alsa-devel] Applied "ASoC: core: ensure component names are unique" to the asoc tree Peter Ujfalusi
2020-02-17 13:22 ` Peter Ujfalusi
2020-02-18 18:55 ` Jerome Brunet
2020-02-18 19:03 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218190314.GM4232@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jbrunet@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.