From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Date: Wed, 19 Feb 2020 08:26:52 +1100 Subject: [Cluster-devel] [PATCH v6 00/19] Change readahead API In-Reply-To: <20200218134230.GN7778@bombadil.infradead.org> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> Message-ID: <20200218212652.GR10776@dread.disaster.area> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Feb 18, 2020 at 05:42:30AM -0800, Matthew Wilcox wrote: > On Tue, Feb 18, 2020 at 03:56:33PM +1100, Dave Chinner wrote: > > Latest version in your git tree: > > > > $ ? glo -n 5 willy/readahead > > 4be497096c04 mm: Use memalloc_nofs_save in readahead path > > ff63497fcb98 iomap: Convert from readpages to readahead > > 26aee60e89b5 iomap: Restructure iomap_readpages_actor > > 8115bcca7312 fuse: Convert from readpages to readahead > > 3db3d10d9ea1 f2fs: Convert from readpages to readahead > > $ > > > > merged into a 5.6-rc2 tree fails at boot on my test vm: > > > > [ 2.423116] ------------[ cut here ]------------ > > [ 2.424957] list_add double add: new=ffffea000efff4c8, prev=ffff8883bfffee60, next=ffffea000efff4c8. > > [ 2.428259] WARNING: CPU: 4 PID: 1 at lib/list_debug.c:29 __list_add_valid+0x67/0x70 > > [ 2.457484] Call Trace: > > [ 2.458171] __pagevec_lru_add_fn+0x15f/0x2c0 > > [ 2.459376] pagevec_lru_move_fn+0x87/0xd0 > > [ 2.460500] ? pagevec_move_tail_fn+0x2d0/0x2d0 > > [ 2.461712] lru_add_drain_cpu+0x8d/0x160 > > [ 2.462787] lru_add_drain+0x18/0x20 > > Are you sure that was 4be497096c04 ? I ask because there was a Yes, because it's the only version I've actually merged into my working tree, compiled and tried to run. :P > version pushed to that git tree that did contain a list double-add > (due to a mismerge when shuffling patches). I noticed it and fixed > it, and 4be497096c04 doesn't have that problem. I also test with > CONFIG_DEBUG_LIST turned on, but this problem you hit is going to be > probabilistic because it'll depend on the timing between whatever other > list is being used and the page actually being added to the LRU. I'll see if I can reproduce it. Cheers, Dave. -- Dave Chinner david at fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B726C34031 for ; Tue, 18 Feb 2020 21:27:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E3602173E for ; Tue, 18 Feb 2020 21:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727761AbgBRV06 (ORCPT ); Tue, 18 Feb 2020 16:26:58 -0500 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:50224 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbgBRV06 (ORCPT ); Tue, 18 Feb 2020 16:26:58 -0500 Received: from dread.disaster.area (pa49-179-138-28.pa.nsw.optusnet.com.au [49.179.138.28]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 0B3B97EA1A6; Wed, 19 Feb 2020 08:26:54 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j4AOK-0003K5-Rm; Wed, 19 Feb 2020 08:26:52 +1100 Date: Wed, 19 Feb 2020 08:26:52 +1100 From: Dave Chinner To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH v6 00/19] Change readahead API Message-ID: <20200218212652.GR10776@dread.disaster.area> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200218134230.GN7778@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=zAxSp4fFY/GQY8/esVNjqw==:117 a=zAxSp4fFY/GQY8/esVNjqw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=l697ptgUJYAA:10 a=7-415B0cAAAA:8 a=13k90lvrXjaGpILklQQA:9 a=QEXdDO2ut3YA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Feb 18, 2020 at 05:42:30AM -0800, Matthew Wilcox wrote: > On Tue, Feb 18, 2020 at 03:56:33PM +1100, Dave Chinner wrote: > > Latest version in your git tree: > > > > $ ▶ glo -n 5 willy/readahead > > 4be497096c04 mm: Use memalloc_nofs_save in readahead path > > ff63497fcb98 iomap: Convert from readpages to readahead > > 26aee60e89b5 iomap: Restructure iomap_readpages_actor > > 8115bcca7312 fuse: Convert from readpages to readahead > > 3db3d10d9ea1 f2fs: Convert from readpages to readahead > > $ > > > > merged into a 5.6-rc2 tree fails at boot on my test vm: > > > > [ 2.423116] ------------[ cut here ]------------ > > [ 2.424957] list_add double add: new=ffffea000efff4c8, prev=ffff8883bfffee60, next=ffffea000efff4c8. > > [ 2.428259] WARNING: CPU: 4 PID: 1 at lib/list_debug.c:29 __list_add_valid+0x67/0x70 > > [ 2.457484] Call Trace: > > [ 2.458171] __pagevec_lru_add_fn+0x15f/0x2c0 > > [ 2.459376] pagevec_lru_move_fn+0x87/0xd0 > > [ 2.460500] ? pagevec_move_tail_fn+0x2d0/0x2d0 > > [ 2.461712] lru_add_drain_cpu+0x8d/0x160 > > [ 2.462787] lru_add_drain+0x18/0x20 > > Are you sure that was 4be497096c04 ? I ask because there was a Yes, because it's the only version I've actually merged into my working tree, compiled and tried to run. :P > version pushed to that git tree that did contain a list double-add > (due to a mismerge when shuffling patches). I noticed it and fixed > it, and 4be497096c04 doesn't have that problem. I also test with > CONFIG_DEBUG_LIST turned on, but this problem you hit is going to be > probabilistic because it'll depend on the timing between whatever other > list is being used and the page actually being added to the LRU. I'll see if I can reproduce it. Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB1DC34031 for ; Tue, 18 Feb 2020 21:27:12 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22C782173E for ; Tue, 18 Feb 2020 21:27:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22C782173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48MYpQ19Z8zDqMX for ; Wed, 19 Feb 2020 08:27:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=mail104.syd.optusnet.com.au (client-ip=211.29.132.246; helo=mail104.syd.optusnet.com.au; envelope-from=david@fromorbit.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lists.ozlabs.org (Postfix) with ESMTP id 48MYp92GMSzDq6M for ; Wed, 19 Feb 2020 08:26:57 +1100 (AEDT) Received: from dread.disaster.area (pa49-179-138-28.pa.nsw.optusnet.com.au [49.179.138.28]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 0B3B97EA1A6; Wed, 19 Feb 2020 08:26:54 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j4AOK-0003K5-Rm; Wed, 19 Feb 2020 08:26:52 +1100 Date: Wed, 19 Feb 2020 08:26:52 +1100 From: Dave Chinner To: Matthew Wilcox Subject: Re: [PATCH v6 00/19] Change readahead API Message-ID: <20200218212652.GR10776@dread.disaster.area> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200218134230.GN7778@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=zAxSp4fFY/GQY8/esVNjqw==:117 a=zAxSp4fFY/GQY8/esVNjqw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=l697ptgUJYAA:10 a=7-415B0cAAAA:8 a=13k90lvrXjaGpILklQQA:9 a=QEXdDO2ut3YA:10 a=biEYGPWJfzWAr4FL6Ov7:22 X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Tue, Feb 18, 2020 at 05:42:30AM -0800, Matthew Wilcox wrote: > On Tue, Feb 18, 2020 at 03:56:33PM +1100, Dave Chinner wrote: > > Latest version in your git tree: > > > > $ ▶ glo -n 5 willy/readahead > > 4be497096c04 mm: Use memalloc_nofs_save in readahead path > > ff63497fcb98 iomap: Convert from readpages to readahead > > 26aee60e89b5 iomap: Restructure iomap_readpages_actor > > 8115bcca7312 fuse: Convert from readpages to readahead > > 3db3d10d9ea1 f2fs: Convert from readpages to readahead > > $ > > > > merged into a 5.6-rc2 tree fails at boot on my test vm: > > > > [ 2.423116] ------------[ cut here ]------------ > > [ 2.424957] list_add double add: new=ffffea000efff4c8, prev=ffff8883bfffee60, next=ffffea000efff4c8. > > [ 2.428259] WARNING: CPU: 4 PID: 1 at lib/list_debug.c:29 __list_add_valid+0x67/0x70 > > [ 2.457484] Call Trace: > > [ 2.458171] __pagevec_lru_add_fn+0x15f/0x2c0 > > [ 2.459376] pagevec_lru_move_fn+0x87/0xd0 > > [ 2.460500] ? pagevec_move_tail_fn+0x2d0/0x2d0 > > [ 2.461712] lru_add_drain_cpu+0x8d/0x160 > > [ 2.462787] lru_add_drain+0x18/0x20 > > Are you sure that was 4be497096c04 ? I ask because there was a Yes, because it's the only version I've actually merged into my working tree, compiled and tried to run. :P > version pushed to that git tree that did contain a list double-add > (due to a mismerge when shuffling patches). I noticed it and fixed > it, and 4be497096c04 doesn't have that problem. I also test with > CONFIG_DEBUG_LIST turned on, but this problem you hit is going to be > probabilistic because it'll depend on the timing between whatever other > list is being used and the page actually being added to the LRU. I'll see if I can reproduce it. Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BBB0C3404B for ; Tue, 18 Feb 2020 21:27:09 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B6302173E; Tue, 18 Feb 2020 21:27:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="DMc/sAL2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="hak00XjU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B6302173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1j4AOa-00073N-W8; Tue, 18 Feb 2020 21:27:09 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j4AOZ-00073D-6C for linux-f2fs-devel@lists.sourceforge.net; Tue, 18 Feb 2020 21:27:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Iu53jqs89fowoiedueVwZEvsfpQdTKl39hLZDNjuIDs=; b=DMc/sAL20SqEnvNeohc7qS0NmO 2AMptxlaIaN2DORewXodqz3M2D60sWKLj75t9dzErpYW4xPc/15thrkTp26Z/PLefref7rjG8l70M i0A1NAJChMXea2M4g3dvUaQgTVikyFG2Xa5/QD/WIh9RxGW9pnOw6JMeAyuUWqa6GcwQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Iu53jqs89fowoiedueVwZEvsfpQdTKl39hLZDNjuIDs=; b=hak00XjU2LDU1qP4n+efihrXsM F+9UqrrgMeqVlI01VX9Ik98Gs4Ge8BKG0RU8iTJlizuZsn3nL5yy9iF5Bn4AcPNhbuqcPktAIJ8tJ kaetuk1gEENOR+Nw/qUr62IbXyVFJLgWPUN2Hhuo1BgCPVLj0fXRQTdShP+x0IY+lFdY=; Received: from mail104.syd.optusnet.com.au ([211.29.132.246]) by sfi-mx-1.v28.lw.sourceforge.com with esmtp (Exim 4.92.2) id 1j4AOX-00GwxU-El for linux-f2fs-devel@lists.sourceforge.net; Tue, 18 Feb 2020 21:27:06 +0000 Received: from dread.disaster.area (pa49-179-138-28.pa.nsw.optusnet.com.au [49.179.138.28]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 0B3B97EA1A6; Wed, 19 Feb 2020 08:26:54 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j4AOK-0003K5-Rm; Wed, 19 Feb 2020 08:26:52 +1100 Date: Wed, 19 Feb 2020 08:26:52 +1100 From: Dave Chinner To: Matthew Wilcox Message-ID: <20200218212652.GR10776@dread.disaster.area> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200218134230.GN7778@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=zAxSp4fFY/GQY8/esVNjqw==:117 a=zAxSp4fFY/GQY8/esVNjqw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=l697ptgUJYAA:10 a=7-415B0cAAAA:8 a=13k90lvrXjaGpILklQQA:9 a=QEXdDO2ut3YA:10 a=biEYGPWJfzWAr4FL6Ov7:22 X-Headers-End: 1j4AOX-00GwxU-El Subject: Re: [f2fs-dev] [PATCH v6 00/19] Change readahead API X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gVHVlLCBGZWIgMTgsIDIwMjAgYXQgMDU6NDI6MzBBTSAtMDgwMCwgTWF0dGhldyBXaWxjb3gg d3JvdGU6Cj4gT24gVHVlLCBGZWIgMTgsIDIwMjAgYXQgMDM6NTY6MzNQTSArMTEwMCwgRGF2ZSBD aGlubmVyIHdyb3RlOgo+ID4gTGF0ZXN0IHZlcnNpb24gaW4geW91ciBnaXQgdHJlZToKPiA+IAo+ ID4gJCDilrYgZ2xvIC1uIDUgd2lsbHkvcmVhZGFoZWFkCj4gPiA0YmU0OTcwOTZjMDQgbW06IFVz ZSBtZW1hbGxvY19ub2ZzX3NhdmUgaW4gcmVhZGFoZWFkIHBhdGgKPiA+IGZmNjM0OTdmY2I5OCBp b21hcDogQ29udmVydCBmcm9tIHJlYWRwYWdlcyB0byByZWFkYWhlYWQKPiA+IDI2YWVlNjBlODli NSBpb21hcDogUmVzdHJ1Y3R1cmUgaW9tYXBfcmVhZHBhZ2VzX2FjdG9yCj4gPiA4MTE1YmNjYTcz MTIgZnVzZTogQ29udmVydCBmcm9tIHJlYWRwYWdlcyB0byByZWFkYWhlYWQKPiA+IDNkYjNkMTBk OWVhMSBmMmZzOiBDb252ZXJ0IGZyb20gcmVhZHBhZ2VzIHRvIHJlYWRhaGVhZAo+ID4gJAo+ID4g Cj4gPiBtZXJnZWQgaW50byBhIDUuNi1yYzIgdHJlZSBmYWlscyBhdCBib290IG9uIG15IHRlc3Qg dm06Cj4gPiAKPiA+IFsgICAgMi40MjMxMTZdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0t LS0tLS0tLQo+ID4gWyAgICAyLjQyNDk1N10gbGlzdF9hZGQgZG91YmxlIGFkZDogbmV3PWZmZmZl YTAwMGVmZmY0YzgsIHByZXY9ZmZmZjg4ODNiZmZmZWU2MCwgbmV4dD1mZmZmZWEwMDBlZmZmNGM4 Lgo+ID4gWyAgICAyLjQyODI1OV0gV0FSTklORzogQ1BVOiA0IFBJRDogMSBhdCBsaWIvbGlzdF9k ZWJ1Zy5jOjI5IF9fbGlzdF9hZGRfdmFsaWQrMHg2Ny8weDcwCj4gPiBbICAgIDIuNDU3NDg0XSBD YWxsIFRyYWNlOgo+ID4gWyAgICAyLjQ1ODE3MV0gIF9fcGFnZXZlY19scnVfYWRkX2ZuKzB4MTVm LzB4MmMwCj4gPiBbICAgIDIuNDU5Mzc2XSAgcGFnZXZlY19scnVfbW92ZV9mbisweDg3LzB4ZDAK PiA+IFsgICAgMi40NjA1MDBdICA/IHBhZ2V2ZWNfbW92ZV90YWlsX2ZuKzB4MmQwLzB4MmQwCj4g PiBbICAgIDIuNDYxNzEyXSAgbHJ1X2FkZF9kcmFpbl9jcHUrMHg4ZC8weDE2MAo+ID4gWyAgICAy LjQ2Mjc4N10gIGxydV9hZGRfZHJhaW4rMHgxOC8weDIwCj4gCj4gQXJlIHlvdSBzdXJlIHRoYXQg d2FzIDRiZTQ5NzA5NmMwNCA/ICBJIGFzayBiZWNhdXNlIHRoZXJlIHdhcyBhCgpZZXMsIGJlY2F1 c2UgaXQncyB0aGUgb25seSB2ZXJzaW9uIEkndmUgYWN0dWFsbHkgbWVyZ2VkIGludG8gbXkKd29y a2luZyB0cmVlLCBjb21waWxlZCBhbmQgdHJpZWQgdG8gcnVuLiA6UAoKPiB2ZXJzaW9uIHB1c2hl ZCB0byB0aGF0IGdpdCB0cmVlIHRoYXQgZGlkIGNvbnRhaW4gYSBsaXN0IGRvdWJsZS1hZGQKPiAo ZHVlIHRvIGEgbWlzbWVyZ2Ugd2hlbiBzaHVmZmxpbmcgcGF0Y2hlcykuICBJIG5vdGljZWQgaXQg YW5kIGZpeGVkCj4gaXQsIGFuZCA0YmU0OTcwOTZjMDQgZG9lc24ndCBoYXZlIHRoYXQgcHJvYmxl bS4gIEkgYWxzbyB0ZXN0IHdpdGgKPiBDT05GSUdfREVCVUdfTElTVCB0dXJuZWQgb24sIGJ1dCB0 aGlzIHByb2JsZW0geW91IGhpdCBpcyBnb2luZyB0byBiZQo+IHByb2JhYmlsaXN0aWMgYmVjYXVz ZSBpdCdsbCBkZXBlbmQgb24gdGhlIHRpbWluZyBiZXR3ZWVuIHdoYXRldmVyIG90aGVyCj4gbGlz dCBpcyBiZWluZyB1c2VkIGFuZCB0aGUgcGFnZSBhY3R1YWxseSBiZWluZyBhZGRlZCB0byB0aGUg TFJVLgoKSSdsbCBzZWUgaWYgSSBjYW4gcmVwcm9kdWNlIGl0LgoKQ2hlZXJzLAoKRGF2ZS4KLS0g CkRhdmUgQ2hpbm5lcgpkYXZpZEBmcm9tb3JiaXQuY29tCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QK TGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3Vy Y2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Date: Wed, 19 Feb 2020 08:26:52 +1100 Subject: [Ocfs2-devel] [PATCH v6 00/19] Change readahead API In-Reply-To: <20200218134230.GN7778@bombadil.infradead.org> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> Message-ID: <20200218212652.GR10776@dread.disaster.area> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org On Tue, Feb 18, 2020 at 05:42:30AM -0800, Matthew Wilcox wrote: > On Tue, Feb 18, 2020 at 03:56:33PM +1100, Dave Chinner wrote: > > Latest version in your git tree: > > > > $ ? glo -n 5 willy/readahead > > 4be497096c04 mm: Use memalloc_nofs_save in readahead path > > ff63497fcb98 iomap: Convert from readpages to readahead > > 26aee60e89b5 iomap: Restructure iomap_readpages_actor > > 8115bcca7312 fuse: Convert from readpages to readahead > > 3db3d10d9ea1 f2fs: Convert from readpages to readahead > > $ > > > > merged into a 5.6-rc2 tree fails at boot on my test vm: > > > > [ 2.423116] ------------[ cut here ]------------ > > [ 2.424957] list_add double add: new=ffffea000efff4c8, prev=ffff8883bfffee60, next=ffffea000efff4c8. > > [ 2.428259] WARNING: CPU: 4 PID: 1 at lib/list_debug.c:29 __list_add_valid+0x67/0x70 > > [ 2.457484] Call Trace: > > [ 2.458171] __pagevec_lru_add_fn+0x15f/0x2c0 > > [ 2.459376] pagevec_lru_move_fn+0x87/0xd0 > > [ 2.460500] ? pagevec_move_tail_fn+0x2d0/0x2d0 > > [ 2.461712] lru_add_drain_cpu+0x8d/0x160 > > [ 2.462787] lru_add_drain+0x18/0x20 > > Are you sure that was 4be497096c04 ? I ask because there was a Yes, because it's the only version I've actually merged into my working tree, compiled and tried to run. :P > version pushed to that git tree that did contain a list double-add > (due to a mismerge when shuffling patches). I noticed it and fixed > it, and 4be497096c04 doesn't have that problem. I also test with > CONFIG_DEBUG_LIST turned on, but this problem you hit is going to be > probabilistic because it'll depend on the timing between whatever other > list is being used and the page actually being added to the LRU. I'll see if I can reproduce it. Cheers, Dave. -- Dave Chinner david at fromorbit.com