From: Borislav Petkov <bp@alien8.de>
To: Kim Phillips <kim.phillips@amd.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Babu Moger" <babu.moger@amd.com>,
"Fenghua Yu" <fenghua.yu@intel.com>,
"Frank van der Linden" <fllinden@amazon.com>,
"H . Peter Anvin" <hpa@zytor.com>,
"Huang Rui" <ray.huang@amd.com>,
"Janakarajan Natarajan" <Janakarajan.Natarajan@amd.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Josh Poimboeuf" <jpoimboe@redhat.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Luwei Kang" <luwei.kang@intel.com>,
"Martin Liška" <mliska@suse.cz>,
"Matt Fleming" <matt@codeblueprint.co.uk>,
"Michael Petlan" <mpetlan@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Pawan Gupta" <pawan.kumar.gupta@linux.intel.com>,
"Suravee Suthikulpanit" <Suravee.Suthikulpanit@amd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3] x86/cpu/amd: Enable the fixed Instructions Retired counter IRPERF
Date: Tue, 18 Feb 2020 22:54:11 +0100 [thread overview]
Message-ID: <20200218215411.GU14449@zn.tnic> (raw)
In-Reply-To: <15f0ff78-1a94-cfa7-297b-c226cb98d10f@amd.com>
On Tue, Feb 18, 2020 at 03:35:25PM -0600, Kim Phillips wrote:
> The only reason to have it show in /proc/cpuinfo is for userspace,
> but they can check for a nonzero count prior to using, instead.
How is userspace going to check it? perf tool or people *can* check it?
If perf is going to check it then I'm fine with having the bug bit in
/proc/cpuinfo along with a patch for perf adding usage for it.
If not and people in userspace can maybe check it but they probably
won't then adding that bug bit would be a waste of bit.
> Let me know if you'd like me to send a v4, or if you will just apply
> this version of yours.
I can take the simpler version for now. If you still want to have perf
tool check the bit, you could submit a new patch adding that bug bit
along with a perf tool patch using it...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-02-18 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 20:18 [PATCH v3] x86/cpu/amd: Enable the fixed Instructions Retired counter IRPERF Kim Phillips
2020-02-18 11:20 ` Borislav Petkov
2020-02-18 21:35 ` Kim Phillips
2020-02-18 21:54 ` Borislav Petkov [this message]
2020-02-19 19:07 ` [tip: x86/urgent] " tip-bot2 for Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218215411.GU14449@zn.tnic \
--to=bp@alien8.de \
--cc=Janakarajan.Natarajan@amd.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=fllinden@amazon.com \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ray.huang@amd.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.