From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laine Stump <laine@redhat.com>
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Julia Suvorova" <jusual@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH] pcie_root_port: Add disable_hotplug option
Date: Tue, 18 Feb 2020 22:47:05 -0500 [thread overview]
Message-ID: <20200218223104-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <9ea6a6b9-778d-78a8-1909-dce1ed98a24d@redhat.com>
On Tue, Feb 18, 2020 at 10:02:19PM -0500, Laine Stump wrote:
> Also, is there a rhyme/reason for some options having true/false, and some
> being off/on? disable-acs seems to be true/false, but disable-modern is
> on/off. Doesn't make any difference to me in the end, but just thought I'd
> bring it up in case there might be a reason to use on/off instead of
> true/false for this one.
Some places accept on/off, some true/false, some on/off/true/false
others on/off/yes/no and others on/off/true/false/yes/no.
In this case both user visitor machinery. Which I *think*
means on/off is the safe choice and true/false can be
broken in some places.
We really should clean up this mess ... Julia, what do you think?
Let's make them all support all options?
--
MST
next prev parent reply other threads:[~2020-02-19 3:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 16:17 [PATCH] pcie_root_port: Add disable_hotplug option Julia Suvorova
2020-02-18 17:15 ` Igor Mammedov
2020-02-18 17:18 ` Laine Stump
2020-02-18 18:40 ` Julia Suvorova
2020-02-19 3:02 ` Laine Stump
2020-02-19 3:47 ` Michael S. Tsirkin [this message]
2020-02-19 12:21 ` Julia Suvorova
2020-02-21 15:45 ` Michael S. Tsirkin
2020-02-21 12:03 ` Daniel P. Berrangé
2020-02-18 17:24 ` Ján Tomko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218223104-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jusual@redhat.com \
--cc=laine@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.