From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3960BC3404C for ; Wed, 19 Feb 2020 00:42:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 087F124658 for ; Wed, 19 Feb 2020 00:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582072972; bh=nlaeLL8xue00YFpb+IYOkigg6HcB3WAdxvf0CGGXDHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tUtg5v0YN+QpPhvVKe9mGOvys8kHW9he+BLK5+r8VFD3H1ahEOjT2EIoTJ8YYtNZH 5deiWComqpvogFOe8U2lhA1ogQjrWUmduFYeJ4+UrCcRCtOb1DTasG/A78v6m3Mvuq iVKL0On4V0EzzZ9T6Y6lBpXtSwjvzh3MAYNYGqpE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726698AbgBSAmv (ORCPT ); Tue, 18 Feb 2020 19:42:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:60550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726641AbgBSAmv (ORCPT ); Tue, 18 Feb 2020 19:42:51 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A782E24654; Wed, 19 Feb 2020 00:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582072970; bh=nlaeLL8xue00YFpb+IYOkigg6HcB3WAdxvf0CGGXDHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IPXaoMELi6V1+iB27IpdjCLWUtBak7s6ArLSgAKZN54tSiZ9hvw7yroPwI7bdmouG +O+ybdJNT0HEuGgarIkvO4aX7dM8M8vw43ilGjyM9+JUnZOChBncUmOYq6fxdzEu1N 3zck1HxU3qetrKMF7l22R44sTg3+qL8WEjAcHZ6A= Date: Tue, 18 Feb 2020 16:42:49 -0800 From: Eric Biggers To: Kiwoong Kim Cc: 'Christoph Hellwig' , linux-scsi@vger.kernel.org, 'Alim Akhtar' , 'Avri Altman' Subject: Re: [PATCH 1/2] ufshcd: remove unused quirks Message-ID: <20200219004248.GB213946@gmail.com> References: <20200218234450.69412-1-hch@lst.de> <20200218234450.69412-2-hch@lst.de> <0afd01d5e6b7$988cddf0$c9a699d0$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0afd01d5e6b7$988cddf0$c9a699d0$@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, Feb 19, 2020 at 09:00:26AM +0900, Kiwoong Kim wrote: > > Exynos specific driver sets and is using the following quirks but the driver > is not updated > yet. I'll do upstream it in the future. > - UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR > - UFSHCD_QUIRK_PRDT_BYTE_GRAN > - UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR These quirks have been there for 2-3 years without the driver that needs them even being posted to the mailing list since 2017. Since we don't keep unused code in the upstream kernel, I support the removal of these quirks. If you don't want them to be removed, you need to get your driver upstream. - Eric