From: Suraj Jitindar Singh <surajjs@amazon.com>
To: <linux-ext4@vger.kernel.org>
Cc: <tytso@mit.edu>, <sblbir@amazon.com>, <sjitindarsingh@gmail.com>,
"Suraj Jitindar Singh" <surajjs@amazon.com>
Subject: [PATCH 0/3] ext4: Fix potential races when performing online resizing
Date: Tue, 18 Feb 2020 19:08:48 -0800 [thread overview]
Message-ID: <20200219030851.2678-1-surajjs@amazon.com> (raw)
This patch series fixes 2 additional races between array resizing and
array element access when performing online resizing of the arrays
s_group_info and s_flex_groups.
These patches apply on top of the patch:
[PATCH RFC] ext4: fix potential race between online resizing and write operations
The macro sbi_array_rcu_deref() is introduced for simplicity but can be
removed if undesired.
Tested by performing the following:
truncate -s 100G /tmp/foo
sudo bash -c 'while true; do dd if=/dev/zero of=/mnt/xxx bs=1M count=1; sync; \
rm /mnt/xxx; done' &
while true; do mkfs.ext4 -b 1024 -E resize=26213883 /tmp/foo 2096635 -F; \
sudo mount -o loop /tmp/foo /mnt; sudo resize2fs /dev/loop0 26213883; \
sudo umount /mnt; done
Suraj Jitindar Singh (3):
ext4: introduce macro sbi_array_rcu_deref() to access rcu protected
fields
ext4: fix potential race between s_group_info online resizing and
access
ext4: fix potential race between s_flex_groups online resizing and
access
fs/ext4/balloc.c | 11 +++++-----
fs/ext4/ext4.h | 25 +++++++++++++++++----
fs/ext4/ialloc.c | 21 +++++++++++-------
fs/ext4/mballoc.c | 19 ++++++++++------
fs/ext4/resize.c | 4 ++--
fs/ext4/super.c | 56 ++++++++++++++++++++++++++++++++---------------
6 files changed, 91 insertions(+), 45 deletions(-)
--
2.17.1
next reply other threads:[~2020-02-19 3:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 3:08 Suraj Jitindar Singh [this message]
2020-02-19 3:08 ` [PATCH 1/3] ext4: introduce macro sbi_array_rcu_deref() to access rcu protected fields Suraj Jitindar Singh
2020-02-19 3:16 ` Jitindar SIngh, Suraj
2020-02-19 3:34 ` Singh, Balbir
2020-02-20 5:04 ` Theodore Y. Ts'o
2020-02-19 3:08 ` [PATCH 2/3] ext4: fix potential race between s_group_info online resizing and access Suraj Jitindar Singh
2020-02-19 20:20 ` Singh, Balbir
2020-02-20 5:13 ` Theodore Y. Ts'o
2020-02-19 3:08 ` [PATCH 3/3] ext4: fix potential race between s_flex_groups " Suraj Jitindar Singh
2020-02-20 6:14 ` [PATCH 0/3] ext4: Fix potential races when performing online resizing Theodore Y. Ts'o
2020-02-21 0:07 ` Jitindar SIngh, Suraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219030851.2678-1-surajjs@amazon.com \
--to=surajjs@amazon.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sblbir@amazon.com \
--cc=sjitindarsingh@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.