From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Date: Wed, 19 Feb 2020 14:57:20 +1100 Subject: [Cluster-devel] [PATCH v6 00/19] Change readahead API In-Reply-To: <20200219034832.GL24185@bombadil.infradead.org> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> <20200218212652.GR10776@dread.disaster.area> <20200219034525.GH10776@dread.disaster.area> <20200219034832.GL24185@bombadil.infradead.org> Message-ID: <20200219035720.GI10776@dread.disaster.area> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Feb 18, 2020 at 07:48:32PM -0800, Matthew Wilcox wrote: > On Wed, Feb 19, 2020 at 02:45:25PM +1100, Dave Chinner wrote: > > On Wed, Feb 19, 2020 at 08:26:52AM +1100, Dave Chinner wrote: > > > On Tue, Feb 18, 2020 at 05:42:30AM -0800, Matthew Wilcox wrote: > > > > On Tue, Feb 18, 2020 at 03:56:33PM +1100, Dave Chinner wrote: > > > > > Latest version in your git tree: > > > > > > > > > > $ ? glo -n 5 willy/readahead > > > > > 4be497096c04 mm: Use memalloc_nofs_save in readahead path > > > > > ff63497fcb98 iomap: Convert from readpages to readahead > > > > > 26aee60e89b5 iomap: Restructure iomap_readpages_actor > > > > > 8115bcca7312 fuse: Convert from readpages to readahead > > > > > 3db3d10d9ea1 f2fs: Convert from readpages to readahead > > > > > $ > > > > > > > > > > merged into a 5.6-rc2 tree fails at boot on my test vm: > > > > > > > > > > [ 2.423116] ------------[ cut here ]------------ > > > > > [ 2.424957] list_add double add: new=ffffea000efff4c8, prev=ffff8883bfffee60, next=ffffea000efff4c8. > > > > > [ 2.428259] WARNING: CPU: 4 PID: 1 at lib/list_debug.c:29 __list_add_valid+0x67/0x70 > > > > > [ 2.457484] Call Trace: > > > > > [ 2.458171] __pagevec_lru_add_fn+0x15f/0x2c0 > > > > > [ 2.459376] pagevec_lru_move_fn+0x87/0xd0 > > > > > [ 2.460500] ? pagevec_move_tail_fn+0x2d0/0x2d0 > > > > > [ 2.461712] lru_add_drain_cpu+0x8d/0x160 > > > > > [ 2.462787] lru_add_drain+0x18/0x20 > > > > > > > > Are you sure that was 4be497096c04 ? I ask because there was a > > > > > > Yes, because it's the only version I've actually merged into my > > > working tree, compiled and tried to run. :P > > > > > > > version pushed to that git tree that did contain a list double-add > > > > (due to a mismerge when shuffling patches). I noticed it and fixed > > > > it, and 4be497096c04 doesn't have that problem. I also test with > > > > CONFIG_DEBUG_LIST turned on, but this problem you hit is going to be > > > > probabilistic because it'll depend on the timing between whatever other > > > > list is being used and the page actually being added to the LRU. > > > > > > I'll see if I can reproduce it. > > > > Just updated to a current TOT Linus kernel and your latest branch, > > and so far this is 100% reproducable. > > > > Not sure how I'm going to debug it yet, because it's init that is > > triggering it.... > > Eric found it ... Yeah, just saw that and am applying his patch to test it... > still not sure why I don't see it. No readahead configured on your device? Cheers, Dave. -- Dave Chinner david at fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C28BC3402F for ; Wed, 19 Feb 2020 03:57:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C5C6208E4 for ; Wed, 19 Feb 2020 03:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbgBSD52 (ORCPT ); Tue, 18 Feb 2020 22:57:28 -0500 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:36781 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbgBSD51 (ORCPT ); Tue, 18 Feb 2020 22:57:27 -0500 Received: from dread.disaster.area (pa49-179-138-28.pa.nsw.optusnet.com.au [49.179.138.28]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id A8BC07EB672; Wed, 19 Feb 2020 14:57:21 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j4GUC-0005gh-AV; Wed, 19 Feb 2020 14:57:20 +1100 Date: Wed, 19 Feb 2020 14:57:20 +1100 From: Dave Chinner To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH v6 00/19] Change readahead API Message-ID: <20200219035720.GI10776@dread.disaster.area> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> <20200218212652.GR10776@dread.disaster.area> <20200219034525.GH10776@dread.disaster.area> <20200219034832.GL24185@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200219034832.GL24185@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=W5xGqiek c=1 sm=1 tr=0 a=zAxSp4fFY/GQY8/esVNjqw==:117 a=zAxSp4fFY/GQY8/esVNjqw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=l697ptgUJYAA:10 a=7-415B0cAAAA:8 a=4gE3ddVfANxGN4fhDGwA:9 a=QEXdDO2ut3YA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Feb 18, 2020 at 07:48:32PM -0800, Matthew Wilcox wrote: > On Wed, Feb 19, 2020 at 02:45:25PM +1100, Dave Chinner wrote: > > On Wed, Feb 19, 2020 at 08:26:52AM +1100, Dave Chinner wrote: > > > On Tue, Feb 18, 2020 at 05:42:30AM -0800, Matthew Wilcox wrote: > > > > On Tue, Feb 18, 2020 at 03:56:33PM +1100, Dave Chinner wrote: > > > > > Latest version in your git tree: > > > > > > > > > > $ ▶ glo -n 5 willy/readahead > > > > > 4be497096c04 mm: Use memalloc_nofs_save in readahead path > > > > > ff63497fcb98 iomap: Convert from readpages to readahead > > > > > 26aee60e89b5 iomap: Restructure iomap_readpages_actor > > > > > 8115bcca7312 fuse: Convert from readpages to readahead > > > > > 3db3d10d9ea1 f2fs: Convert from readpages to readahead > > > > > $ > > > > > > > > > > merged into a 5.6-rc2 tree fails at boot on my test vm: > > > > > > > > > > [ 2.423116] ------------[ cut here ]------------ > > > > > [ 2.424957] list_add double add: new=ffffea000efff4c8, prev=ffff8883bfffee60, next=ffffea000efff4c8. > > > > > [ 2.428259] WARNING: CPU: 4 PID: 1 at lib/list_debug.c:29 __list_add_valid+0x67/0x70 > > > > > [ 2.457484] Call Trace: > > > > > [ 2.458171] __pagevec_lru_add_fn+0x15f/0x2c0 > > > > > [ 2.459376] pagevec_lru_move_fn+0x87/0xd0 > > > > > [ 2.460500] ? pagevec_move_tail_fn+0x2d0/0x2d0 > > > > > [ 2.461712] lru_add_drain_cpu+0x8d/0x160 > > > > > [ 2.462787] lru_add_drain+0x18/0x20 > > > > > > > > Are you sure that was 4be497096c04 ? I ask because there was a > > > > > > Yes, because it's the only version I've actually merged into my > > > working tree, compiled and tried to run. :P > > > > > > > version pushed to that git tree that did contain a list double-add > > > > (due to a mismerge when shuffling patches). I noticed it and fixed > > > > it, and 4be497096c04 doesn't have that problem. I also test with > > > > CONFIG_DEBUG_LIST turned on, but this problem you hit is going to be > > > > probabilistic because it'll depend on the timing between whatever other > > > > list is being used and the page actually being added to the LRU. > > > > > > I'll see if I can reproduce it. > > > > Just updated to a current TOT Linus kernel and your latest branch, > > and so far this is 100% reproducable. > > > > Not sure how I'm going to debug it yet, because it's init that is > > triggering it.... > > Eric found it ... Yeah, just saw that and am applying his patch to test it... > still not sure why I don't see it. No readahead configured on your device? Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA2CC3404D for ; Wed, 19 Feb 2020 03:57:29 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CACA24656 for ; Wed, 19 Feb 2020 03:57:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CACA24656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48MkSl4J3yzDqjg for ; Wed, 19 Feb 2020 14:57:27 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=mail104.syd.optusnet.com.au (client-ip=211.29.132.246; helo=mail104.syd.optusnet.com.au; envelope-from=david@fromorbit.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lists.ozlabs.org (Postfix) with ESMTP id 48MkSf6ZRGzDqfK for ; Wed, 19 Feb 2020 14:57:22 +1100 (AEDT) Received: from dread.disaster.area (pa49-179-138-28.pa.nsw.optusnet.com.au [49.179.138.28]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id A8BC07EB672; Wed, 19 Feb 2020 14:57:21 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j4GUC-0005gh-AV; Wed, 19 Feb 2020 14:57:20 +1100 Date: Wed, 19 Feb 2020 14:57:20 +1100 From: Dave Chinner To: Matthew Wilcox Subject: Re: [PATCH v6 00/19] Change readahead API Message-ID: <20200219035720.GI10776@dread.disaster.area> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> <20200218212652.GR10776@dread.disaster.area> <20200219034525.GH10776@dread.disaster.area> <20200219034832.GL24185@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200219034832.GL24185@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=W5xGqiek c=1 sm=1 tr=0 a=zAxSp4fFY/GQY8/esVNjqw==:117 a=zAxSp4fFY/GQY8/esVNjqw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=l697ptgUJYAA:10 a=7-415B0cAAAA:8 a=4gE3ddVfANxGN4fhDGwA:9 a=QEXdDO2ut3YA:10 a=biEYGPWJfzWAr4FL6Ov7:22 X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Tue, Feb 18, 2020 at 07:48:32PM -0800, Matthew Wilcox wrote: > On Wed, Feb 19, 2020 at 02:45:25PM +1100, Dave Chinner wrote: > > On Wed, Feb 19, 2020 at 08:26:52AM +1100, Dave Chinner wrote: > > > On Tue, Feb 18, 2020 at 05:42:30AM -0800, Matthew Wilcox wrote: > > > > On Tue, Feb 18, 2020 at 03:56:33PM +1100, Dave Chinner wrote: > > > > > Latest version in your git tree: > > > > > > > > > > $ ▶ glo -n 5 willy/readahead > > > > > 4be497096c04 mm: Use memalloc_nofs_save in readahead path > > > > > ff63497fcb98 iomap: Convert from readpages to readahead > > > > > 26aee60e89b5 iomap: Restructure iomap_readpages_actor > > > > > 8115bcca7312 fuse: Convert from readpages to readahead > > > > > 3db3d10d9ea1 f2fs: Convert from readpages to readahead > > > > > $ > > > > > > > > > > merged into a 5.6-rc2 tree fails at boot on my test vm: > > > > > > > > > > [ 2.423116] ------------[ cut here ]------------ > > > > > [ 2.424957] list_add double add: new=ffffea000efff4c8, prev=ffff8883bfffee60, next=ffffea000efff4c8. > > > > > [ 2.428259] WARNING: CPU: 4 PID: 1 at lib/list_debug.c:29 __list_add_valid+0x67/0x70 > > > > > [ 2.457484] Call Trace: > > > > > [ 2.458171] __pagevec_lru_add_fn+0x15f/0x2c0 > > > > > [ 2.459376] pagevec_lru_move_fn+0x87/0xd0 > > > > > [ 2.460500] ? pagevec_move_tail_fn+0x2d0/0x2d0 > > > > > [ 2.461712] lru_add_drain_cpu+0x8d/0x160 > > > > > [ 2.462787] lru_add_drain+0x18/0x20 > > > > > > > > Are you sure that was 4be497096c04 ? I ask because there was a > > > > > > Yes, because it's the only version I've actually merged into my > > > working tree, compiled and tried to run. :P > > > > > > > version pushed to that git tree that did contain a list double-add > > > > (due to a mismerge when shuffling patches). I noticed it and fixed > > > > it, and 4be497096c04 doesn't have that problem. I also test with > > > > CONFIG_DEBUG_LIST turned on, but this problem you hit is going to be > > > > probabilistic because it'll depend on the timing between whatever other > > > > list is being used and the page actually being added to the LRU. > > > > > > I'll see if I can reproduce it. > > > > Just updated to a current TOT Linus kernel and your latest branch, > > and so far this is 100% reproducable. > > > > Not sure how I'm going to debug it yet, because it's init that is > > triggering it.... > > Eric found it ... Yeah, just saw that and am applying his patch to test it... > still not sure why I don't see it. No readahead configured on your device? Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E13FC34022 for ; Wed, 19 Feb 2020 03:57:32 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34292206DB; Wed, 19 Feb 2020 03:57:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="j17fUn1D"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="JFXxTsuP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34292206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1j4GUN-0003UD-RF; Wed, 19 Feb 2020 03:57:31 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j4GUM-0003Ty-2r for linux-f2fs-devel@lists.sourceforge.net; Wed, 19 Feb 2020 03:57:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6UGsKUfklF+XxwPnTtZqjA1giwm2crvQxVLfc+LHshE=; b=j17fUn1DBlbfMoYdbTGWn18CdF HAi5Whx4h7FaNtNnCObs6Y+CBM3Irmv/+/RxW9DeJqZR0hATrw7iYhljlqstTgXVJUcY50nUTHwUu t3zV4H/bb1ZXkjDgXoIla8ecZgtWDWEg61Rrcn/9PW5ozG7vipcyRl1xV0OFQIiTrOJc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6UGsKUfklF+XxwPnTtZqjA1giwm2crvQxVLfc+LHshE=; b=JFXxTsuPYlyJkr3ZwMoVtlthBV lJTIfE3eCfX91o2BUbClUUIIvYNLTXzSWbMeOJhdTY8iUok8Md8xbnO4p18DHiIPpg+xJSl1//4Qf T8krwI79SWyd5C40F7xQjqvrc8kLN2YGqdGdNew6eeLJw1R29zJzP54pMPZUf0t+EcPI=; Received: from mail104.syd.optusnet.com.au ([211.29.132.246]) by sfi-mx-4.v28.lw.sourceforge.com with esmtp (Exim 4.92.2) id 1j4GUK-007XGA-FV for linux-f2fs-devel@lists.sourceforge.net; Wed, 19 Feb 2020 03:57:30 +0000 Received: from dread.disaster.area (pa49-179-138-28.pa.nsw.optusnet.com.au [49.179.138.28]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id A8BC07EB672; Wed, 19 Feb 2020 14:57:21 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j4GUC-0005gh-AV; Wed, 19 Feb 2020 14:57:20 +1100 Date: Wed, 19 Feb 2020 14:57:20 +1100 From: Dave Chinner To: Matthew Wilcox Message-ID: <20200219035720.GI10776@dread.disaster.area> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> <20200218212652.GR10776@dread.disaster.area> <20200219034525.GH10776@dread.disaster.area> <20200219034832.GL24185@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200219034832.GL24185@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=W5xGqiek c=1 sm=1 tr=0 a=zAxSp4fFY/GQY8/esVNjqw==:117 a=zAxSp4fFY/GQY8/esVNjqw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=l697ptgUJYAA:10 a=7-415B0cAAAA:8 a=4gE3ddVfANxGN4fhDGwA:9 a=QEXdDO2ut3YA:10 a=biEYGPWJfzWAr4FL6Ov7:22 X-Headers-End: 1j4GUK-007XGA-FV Subject: Re: [f2fs-dev] [PATCH v6 00/19] Change readahead API X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gVHVlLCBGZWIgMTgsIDIwMjAgYXQgMDc6NDg6MzJQTSAtMDgwMCwgTWF0dGhldyBXaWxjb3gg d3JvdGU6Cj4gT24gV2VkLCBGZWIgMTksIDIwMjAgYXQgMDI6NDU6MjVQTSArMTEwMCwgRGF2ZSBD aGlubmVyIHdyb3RlOgo+ID4gT24gV2VkLCBGZWIgMTksIDIwMjAgYXQgMDg6MjY6NTJBTSArMTEw MCwgRGF2ZSBDaGlubmVyIHdyb3RlOgo+ID4gPiBPbiBUdWUsIEZlYiAxOCwgMjAyMCBhdCAwNTo0 MjozMEFNIC0wODAwLCBNYXR0aGV3IFdpbGNveCB3cm90ZToKPiA+ID4gPiBPbiBUdWUsIEZlYiAx OCwgMjAyMCBhdCAwMzo1NjozM1BNICsxMTAwLCBEYXZlIENoaW5uZXIgd3JvdGU6Cj4gPiA+ID4g PiBMYXRlc3QgdmVyc2lvbiBpbiB5b3VyIGdpdCB0cmVlOgo+ID4gPiA+ID4gCj4gPiA+ID4gPiAk IOKWtiBnbG8gLW4gNSB3aWxseS9yZWFkYWhlYWQKPiA+ID4gPiA+IDRiZTQ5NzA5NmMwNCBtbTog VXNlIG1lbWFsbG9jX25vZnNfc2F2ZSBpbiByZWFkYWhlYWQgcGF0aAo+ID4gPiA+ID4gZmY2MzQ5 N2ZjYjk4IGlvbWFwOiBDb252ZXJ0IGZyb20gcmVhZHBhZ2VzIHRvIHJlYWRhaGVhZAo+ID4gPiA+ ID4gMjZhZWU2MGU4OWI1IGlvbWFwOiBSZXN0cnVjdHVyZSBpb21hcF9yZWFkcGFnZXNfYWN0b3IK PiA+ID4gPiA+IDgxMTViY2NhNzMxMiBmdXNlOiBDb252ZXJ0IGZyb20gcmVhZHBhZ2VzIHRvIHJl YWRhaGVhZAo+ID4gPiA+ID4gM2RiM2QxMGQ5ZWExIGYyZnM6IENvbnZlcnQgZnJvbSByZWFkcGFn ZXMgdG8gcmVhZGFoZWFkCj4gPiA+ID4gPiAkCj4gPiA+ID4gPiAKPiA+ID4gPiA+IG1lcmdlZCBp bnRvIGEgNS42LXJjMiB0cmVlIGZhaWxzIGF0IGJvb3Qgb24gbXkgdGVzdCB2bToKPiA+ID4gPiA+ IAo+ID4gPiA+ID4gWyAgICAyLjQyMzExNl0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0t LS0tLS0tCj4gPiA+ID4gPiBbICAgIDIuNDI0OTU3XSBsaXN0X2FkZCBkb3VibGUgYWRkOiBuZXc9 ZmZmZmVhMDAwZWZmZjRjOCwgcHJldj1mZmZmODg4M2JmZmZlZTYwLCBuZXh0PWZmZmZlYTAwMGVm ZmY0YzguCj4gPiA+ID4gPiBbICAgIDIuNDI4MjU5XSBXQVJOSU5HOiBDUFU6IDQgUElEOiAxIGF0 IGxpYi9saXN0X2RlYnVnLmM6MjkgX19saXN0X2FkZF92YWxpZCsweDY3LzB4NzAKPiA+ID4gPiA+ IFsgICAgMi40NTc0ODRdIENhbGwgVHJhY2U6Cj4gPiA+ID4gPiBbICAgIDIuNDU4MTcxXSAgX19w YWdldmVjX2xydV9hZGRfZm4rMHgxNWYvMHgyYzAKPiA+ID4gPiA+IFsgICAgMi40NTkzNzZdICBw YWdldmVjX2xydV9tb3ZlX2ZuKzB4ODcvMHhkMAo+ID4gPiA+ID4gWyAgICAyLjQ2MDUwMF0gID8g cGFnZXZlY19tb3ZlX3RhaWxfZm4rMHgyZDAvMHgyZDAKPiA+ID4gPiA+IFsgICAgMi40NjE3MTJd ICBscnVfYWRkX2RyYWluX2NwdSsweDhkLzB4MTYwCj4gPiA+ID4gPiBbICAgIDIuNDYyNzg3XSAg bHJ1X2FkZF9kcmFpbisweDE4LzB4MjAKPiA+ID4gPiAKPiA+ID4gPiBBcmUgeW91IHN1cmUgdGhh dCB3YXMgNGJlNDk3MDk2YzA0ID8gIEkgYXNrIGJlY2F1c2UgdGhlcmUgd2FzIGEKPiA+ID4gCj4g PiA+IFllcywgYmVjYXVzZSBpdCdzIHRoZSBvbmx5IHZlcnNpb24gSSd2ZSBhY3R1YWxseSBtZXJn ZWQgaW50byBteQo+ID4gPiB3b3JraW5nIHRyZWUsIGNvbXBpbGVkIGFuZCB0cmllZCB0byBydW4u IDpQCj4gPiA+IAo+ID4gPiA+IHZlcnNpb24gcHVzaGVkIHRvIHRoYXQgZ2l0IHRyZWUgdGhhdCBk aWQgY29udGFpbiBhIGxpc3QgZG91YmxlLWFkZAo+ID4gPiA+IChkdWUgdG8gYSBtaXNtZXJnZSB3 aGVuIHNodWZmbGluZyBwYXRjaGVzKS4gIEkgbm90aWNlZCBpdCBhbmQgZml4ZWQKPiA+ID4gPiBp dCwgYW5kIDRiZTQ5NzA5NmMwNCBkb2Vzbid0IGhhdmUgdGhhdCBwcm9ibGVtLiAgSSBhbHNvIHRl c3Qgd2l0aAo+ID4gPiA+IENPTkZJR19ERUJVR19MSVNUIHR1cm5lZCBvbiwgYnV0IHRoaXMgcHJv YmxlbSB5b3UgaGl0IGlzIGdvaW5nIHRvIGJlCj4gPiA+ID4gcHJvYmFiaWxpc3RpYyBiZWNhdXNl IGl0J2xsIGRlcGVuZCBvbiB0aGUgdGltaW5nIGJldHdlZW4gd2hhdGV2ZXIgb3RoZXIKPiA+ID4g PiBsaXN0IGlzIGJlaW5nIHVzZWQgYW5kIHRoZSBwYWdlIGFjdHVhbGx5IGJlaW5nIGFkZGVkIHRv IHRoZSBMUlUuCj4gPiA+IAo+ID4gPiBJJ2xsIHNlZSBpZiBJIGNhbiByZXByb2R1Y2UgaXQuCj4g PiAKPiA+IEp1c3QgdXBkYXRlZCB0byBhIGN1cnJlbnQgVE9UIExpbnVzIGtlcm5lbCBhbmQgeW91 ciBsYXRlc3QgYnJhbmNoLAo+ID4gYW5kIHNvIGZhciB0aGlzIGlzIDEwMCUgcmVwcm9kdWNhYmxl Lgo+ID4gCj4gPiBOb3Qgc3VyZSBob3cgSSdtIGdvaW5nIHRvIGRlYnVnIGl0IHlldCwgYmVjYXVz ZSBpdCdzIGluaXQgdGhhdCBpcwo+ID4gdHJpZ2dlcmluZyBpdC4uLi4KPiAKPiBFcmljIGZvdW5k IGl0IC4uLgoKWWVhaCwganVzdCBzYXcgdGhhdCBhbmQgYW0gYXBwbHlpbmcgaGlzIHBhdGNoIHRv IHRlc3QgaXQuLi4KCj4gc3RpbGwgbm90IHN1cmUgd2h5IEkgZG9uJ3Qgc2VlIGl0LgoKTm8gcmVh ZGFoZWFkIGNvbmZpZ3VyZWQgb24geW91ciBkZXZpY2U/CgoKQ2hlZXJzLAoKRGF2ZS4KLS0gCkRh dmUgQ2hpbm5lcgpkYXZpZEBmcm9tb3JiaXQuY29tCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGlu dXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vm b3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Date: Wed, 19 Feb 2020 14:57:20 +1100 Subject: [Ocfs2-devel] [PATCH v6 00/19] Change readahead API In-Reply-To: <20200219034832.GL24185@bombadil.infradead.org> References: <20200217184613.19668-1-willy@infradead.org> <20200218045633.GH10776@dread.disaster.area> <20200218134230.GN7778@bombadil.infradead.org> <20200218212652.GR10776@dread.disaster.area> <20200219034525.GH10776@dread.disaster.area> <20200219034832.GL24185@bombadil.infradead.org> Message-ID: <20200219035720.GI10776@dread.disaster.area> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org On Tue, Feb 18, 2020 at 07:48:32PM -0800, Matthew Wilcox wrote: > On Wed, Feb 19, 2020 at 02:45:25PM +1100, Dave Chinner wrote: > > On Wed, Feb 19, 2020 at 08:26:52AM +1100, Dave Chinner wrote: > > > On Tue, Feb 18, 2020 at 05:42:30AM -0800, Matthew Wilcox wrote: > > > > On Tue, Feb 18, 2020 at 03:56:33PM +1100, Dave Chinner wrote: > > > > > Latest version in your git tree: > > > > > > > > > > $ ? glo -n 5 willy/readahead > > > > > 4be497096c04 mm: Use memalloc_nofs_save in readahead path > > > > > ff63497fcb98 iomap: Convert from readpages to readahead > > > > > 26aee60e89b5 iomap: Restructure iomap_readpages_actor > > > > > 8115bcca7312 fuse: Convert from readpages to readahead > > > > > 3db3d10d9ea1 f2fs: Convert from readpages to readahead > > > > > $ > > > > > > > > > > merged into a 5.6-rc2 tree fails at boot on my test vm: > > > > > > > > > > [ 2.423116] ------------[ cut here ]------------ > > > > > [ 2.424957] list_add double add: new=ffffea000efff4c8, prev=ffff8883bfffee60, next=ffffea000efff4c8. > > > > > [ 2.428259] WARNING: CPU: 4 PID: 1 at lib/list_debug.c:29 __list_add_valid+0x67/0x70 > > > > > [ 2.457484] Call Trace: > > > > > [ 2.458171] __pagevec_lru_add_fn+0x15f/0x2c0 > > > > > [ 2.459376] pagevec_lru_move_fn+0x87/0xd0 > > > > > [ 2.460500] ? pagevec_move_tail_fn+0x2d0/0x2d0 > > > > > [ 2.461712] lru_add_drain_cpu+0x8d/0x160 > > > > > [ 2.462787] lru_add_drain+0x18/0x20 > > > > > > > > Are you sure that was 4be497096c04 ? I ask because there was a > > > > > > Yes, because it's the only version I've actually merged into my > > > working tree, compiled and tried to run. :P > > > > > > > version pushed to that git tree that did contain a list double-add > > > > (due to a mismerge when shuffling patches). I noticed it and fixed > > > > it, and 4be497096c04 doesn't have that problem. I also test with > > > > CONFIG_DEBUG_LIST turned on, but this problem you hit is going to be > > > > probabilistic because it'll depend on the timing between whatever other > > > > list is being used and the page actually being added to the LRU. > > > > > > I'll see if I can reproduce it. > > > > Just updated to a current TOT Linus kernel and your latest branch, > > and so far this is 100% reproducable. > > > > Not sure how I'm going to debug it yet, because it's init that is > > triggering it.... > > Eric found it ... Yeah, just saw that and am applying his patch to test it... > still not sure why I don't see it. No readahead configured on your device? Cheers, Dave. -- Dave Chinner david at fromorbit.com