From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A3F8C34022 for ; Wed, 19 Feb 2020 08:08:43 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55E852464E for ; Wed, 19 Feb 2020 08:08:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55E852464E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48Mr2d6QQVzDqcn for ; Wed, 19 Feb 2020 19:08:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.189; helo=huawei.com; envelope-from=gaoxiang25@huawei.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48Mr063ZzCzDqjQ for ; Wed, 19 Feb 2020 19:06:27 +1100 (AEDT) Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id 9B368CBC75E280C9FAF4; Wed, 19 Feb 2020 16:06:16 +0800 (CST) Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by DGGEMM404-HUB.china.huawei.com (10.3.20.212) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Feb 2020 16:06:15 +0800 Received: from architecture4 (10.160.196.180) by dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 19 Feb 2020 16:06:15 +0800 Date: Wed, 19 Feb 2020 16:04:57 +0800 From: Gao Xiang To: Chao Yu Subject: Re: [PATCH v2] erofs: convert workstn to XArray Message-ID: <20200219080456.GA126843@architecture4> References: <20200217033042.137855-1-gaoxiang25@huawei.com> <58f1ff26-e1f8-96a4-fa7b-ee86f972b0aa@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <58f1ff26-e1f8-96a4-fa7b-ee86f972b0aa@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.160.196.180] X-ClientProxiedBy: dggeme708-chm.china.huawei.com (10.1.199.104) To dggeme762-chm.china.huawei.com (10.3.19.108) X-CFilter-Loop: Reflected X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miao Xie , linux-erofs@lists.ozlabs.org, LKML , Matthew Wilcox Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" Hi Chao, On Wed, Feb 19, 2020 at 03:46:16PM +0800, Chao Yu wrote: > On 2020/2/17 11:30, Gao Xiang wrote: [] > > - return err; > > + sbi = EROFS_SB(sb); > > +repeat: > > + xa_lock(&sbi->managed_pslots); > > + pre = __xa_cmpxchg(&sbi->managed_pslots, grp->index, > > + NULL, grp, GFP_NOFS); > > + if (pre) { > > It looks __xa_cmpxchg() could return negative value in case of failure, e.g. > no memory case. We'd better handle that case and old valid workgroup separately? Thanks, that is a quite good catch! To be honest, I'm not quite sure whether __xa_cmpxchg could fail due to no memory here (as a quick scan, it will do __xas_nomem loop interally.) But anyway, it needs bailing out all potential errors by using xa_is_err(). Will do some research and send v3 then. Thanks, Gao Xiang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C395BC34022 for ; Wed, 19 Feb 2020 08:06:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96A1321D56 for ; Wed, 19 Feb 2020 08:06:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbgBSIGY (ORCPT ); Wed, 19 Feb 2020 03:06:24 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:2584 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726163AbgBSIGX (ORCPT ); Wed, 19 Feb 2020 03:06:23 -0500 Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id 9B368CBC75E280C9FAF4; Wed, 19 Feb 2020 16:06:16 +0800 (CST) Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by DGGEMM404-HUB.china.huawei.com (10.3.20.212) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Feb 2020 16:06:15 +0800 Received: from architecture4 (10.160.196.180) by dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 19 Feb 2020 16:06:15 +0800 Date: Wed, 19 Feb 2020 16:04:57 +0800 From: Gao Xiang To: Chao Yu CC: , Matthew Wilcox , LKML , Miao Xie Subject: Re: [PATCH v2] erofs: convert workstn to XArray Message-ID: <20200219080456.GA126843@architecture4> References: <20200217033042.137855-1-gaoxiang25@huawei.com> <58f1ff26-e1f8-96a4-fa7b-ee86f972b0aa@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <58f1ff26-e1f8-96a4-fa7b-ee86f972b0aa@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.160.196.180] X-ClientProxiedBy: dggeme708-chm.china.huawei.com (10.1.199.104) To dggeme762-chm.china.huawei.com (10.3.19.108) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chao, On Wed, Feb 19, 2020 at 03:46:16PM +0800, Chao Yu wrote: > On 2020/2/17 11:30, Gao Xiang wrote: [] > > - return err; > > + sbi = EROFS_SB(sb); > > +repeat: > > + xa_lock(&sbi->managed_pslots); > > + pre = __xa_cmpxchg(&sbi->managed_pslots, grp->index, > > + NULL, grp, GFP_NOFS); > > + if (pre) { > > It looks __xa_cmpxchg() could return negative value in case of failure, e.g. > no memory case. We'd better handle that case and old valid workgroup separately? Thanks, that is a quite good catch! To be honest, I'm not quite sure whether __xa_cmpxchg could fail due to no memory here (as a quick scan, it will do __xas_nomem loop interally.) But anyway, it needs bailing out all potential errors by using xa_is_err(). Will do some research and send v3 then. Thanks, Gao Xiang