From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-comment-return-1068-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id EB26B985EAC for ; Wed, 19 Feb 2020 14:23:16 +0000 (UTC) Date: Wed, 19 Feb 2020 09:23:08 -0500 From: "Michael S. Tsirkin" Message-ID: <20200219092244-mutt-send-email-mst@kernel.org> References: <20200219075337.23191-1-yuri.benditovich@daynix.com> <20200219075337.23191-2-yuri.benditovich@daynix.com> <86420fd1-cbb4-0105-4114-ca2d6cb3b8ff@redhat.com> MIME-Version: 1.0 In-Reply-To: <86420fd1-cbb4-0105-4114-ca2d6cb3b8ff@redhat.com> Subject: Re: [virtio-comment] [PATCH v4 1/1] virtio-net: Define per-packet hash reporting feature Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline To: Jason Wang Cc: Yuri Benditovich , virtio-comment@lists.oasis-open.org List-ID: On Wed, Feb 19, 2020 at 08:27:10PM +0800, Jason Wang wrote: >=20 > On 2020/2/19 =E4=B8=8B=E5=8D=883:53, Yuri Benditovich wrote: > > The device MUST set \field{rss_max_indirection_table_length} to at le= ast 128, if it offers > > VIRTIO_NET_F_RSS. > > @@ -3195,6 +3180,8 @@ \subsection{Device Operation}\label{sec:Device Ty= pes / Network Device / Device O > > le16 csum_start; > > le16 csum_offset; > > le16 num_buffers; > > + le32 hash_value; (Only if VIRTIO_NET_F_HASH_REPORT negotiated) > > + le16 hash_type; (Only if VIRTIO_NET_F_HASH_REPORT negotiated) > > }; > > \end{lstlisting} >=20 >=20 > A question here: >=20 > Consider we introduce VIRTIO_NET_F_FEATURE_INFORMATION in the future: >=20 > le32 hash_type; // VIRTIO_NET_F_HASH_REPORT > le32 feature_information; // VIRTIO_NET_F_FEATURE_INFORMATION >=20 > What happens if HASH_REPORT is not negotiated, I believe we expect a stab= le > ABI(offset) here for feature_information? >=20 > Thanks >=20 We'll have to decide at that point ... any better ideas? --=20 MST This publicly archived list offers a means to provide input to the=0D OASIS Virtual I/O Device (VIRTIO) TC.=0D =0D In order to verify user consent to the Feedback License terms and=0D to minimize spam in the list archive, subscription is required=0D before posting.=0D =0D Subscribe: virtio-comment-subscribe@lists.oasis-open.org=0D Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org=0D List help: virtio-comment-help@lists.oasis-open.org=0D List archive: https://lists.oasis-open.org/archives/virtio-comment/=0D Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf= =0D List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lis= ts=0D Committee: https://www.oasis-open.org/committees/virtio/=0D Join OASIS: https://www.oasis-open.org/join/