From: Johan Hovold <johan@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Johan Hovold <johan@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, linux-serial@vger.kernel.org
Subject: Re: [PATCH v6 4/4] leds: trigger: implement a tty trigger
Date: Wed, 19 Feb 2020 13:48:59 +0100 [thread overview]
Message-ID: <20200219124859.GC32540@localhost> (raw)
In-Reply-To: <20200219111913.GB32540@localhost>
On Wed, Feb 19, 2020 at 12:19:13PM +0100, Johan Hovold wrote:
> On Wed, Feb 19, 2020 at 12:03:06PM +0100, Uwe Kleine-König wrote:
> > On Wed, Feb 19, 2020 at 11:52:39AM +0100, Johan Hovold wrote:
> > If I understand correctly calling tty_kopen_shared() doesn't open the
> > device, just keep it referenced which prevents it to disappear. Unless I
> > miss something it doesn't result in the tty's .open() being called.
>
> So tty_kopen_shared() is something you added. Judging from a quick look
> it seems you can only attach a trigger to an already open port, but the
> trigger will then keep the port open (again, consider modem control,
> power).
Sorry, my bad; this reference shouldn't prevent the port from being
closed.
The fact that you need the port to be open before you can attach a
trigger does sound like a problem though (e.g. consider udev rules).
Johan
next prev parent reply other threads:[~2020-02-19 12:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 9:15 [PATCH v6 0/4] leds: trigger: implement a tty trigger Uwe Kleine-König
2020-02-13 9:15 ` [PATCH v6 1/4] lib: new helper kstrtodev_t() Uwe Kleine-König
2020-02-19 19:50 ` Andy Shevchenko
2020-02-20 7:49 ` Uwe Kleine-König
2020-02-20 10:22 ` Andy Shevchenko
2020-02-20 10:57 ` Uwe Kleine-König
2020-02-20 11:46 ` Andy Shevchenko
2020-02-20 11:57 ` Andy Shevchenko
2020-02-20 14:01 ` Uwe Kleine-König
2020-02-21 8:42 ` Andy Shevchenko
2020-02-21 10:53 ` Uwe Kleine-König
2020-04-25 7:07 ` Pavel Machek
2020-02-13 9:15 ` [PATCH v6 2/4] tty: rename tty_kopen() and add new function tty_kopen_shared() Uwe Kleine-König
2020-02-19 13:21 ` Johan Hovold
2020-02-19 16:37 ` Uwe Kleine-König
2020-02-19 17:17 ` Johan Hovold
2020-02-20 11:04 ` Uwe Kleine-König
2020-02-25 8:55 ` Johan Hovold
2020-02-25 9:05 ` Uwe Kleine-König
2020-02-13 9:15 ` [PATCH v6 3/4] tty: new helper function tty_get_icount() Uwe Kleine-König
2020-02-13 9:16 ` [PATCH v6 4/4] leds: trigger: implement a tty trigger Uwe Kleine-König
2020-02-19 10:52 ` Johan Hovold
2020-02-19 11:03 ` Uwe Kleine-König
2020-02-19 11:19 ` Johan Hovold
2020-02-19 12:48 ` Johan Hovold [this message]
2020-02-19 10:40 ` [PATCH v6 0/4] " Greg Kroah-Hartman
2020-02-26 14:02 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219124859.GC32540@localhost \
--to=johan@kernel.org \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.