From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6330C34047 for ; Wed, 19 Feb 2020 15:28:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A0FC24654 for ; Wed, 19 Feb 2020 15:28:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SwuUYcaW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbgBSP23 (ORCPT ); Wed, 19 Feb 2020 10:28:29 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:37230 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726682AbgBSP23 (ORCPT ); Wed, 19 Feb 2020 10:28:29 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7190452B; Wed, 19 Feb 2020 16:28:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582126107; bh=S3hwt9TMlVU5HobaEOMv2lev0QevEyU32s/7zeGqV60=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SwuUYcaWCm3YnE//Co/L6TqBj4PgYw+ftIDyWbzrq0jRZi90EJNqALCUFa6rRyl4j ei2wh/Ch+LjBo00a+jgwl8k+pdFrEPzyhJoYCUS9SacAWr1DqGLDoEg5G38ksZb1L8 q/pYiUl23hrjNle51MAmeMmv555nbLHAX/kKvqpA= Date: Wed, 19 Feb 2020 17:28:08 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Magnus Damm , Kieran Bingham , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/4] ARM: dts: rzg1: Add reset control properties for display Message-ID: <20200219152808.GS5070@pendragon.ideasonboard.com> References: <20200218133019.22299-1-geert+renesas@glider.be> <20200218133019.22299-3-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200218133019.22299-3-geert+renesas@glider.be> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, Thank you for the patch. On Tue, Feb 18, 2020 at 02:30:17PM +0100, Geert Uytterhoeven wrote: > Add reset control properties to the devices node for the Display Units > on all supported RZ/G1 SoCs. Note that on these SoCs, there is only a > single reset for all DU channels. > > Join the clocks lines while at it, to increase uniformity. > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - New. > --- > arch/arm/boot/dts/r8a7743.dtsi | 5 +++-- > arch/arm/boot/dts/r8a7744.dtsi | 5 +++-- > arch/arm/boot/dts/r8a7745.dtsi | 2 ++ > arch/arm/boot/dts/r8a77470.dtsi | 5 +++-- > 4 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 1cd19a569bd0fb66..e8b340bb99bc3031 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -1669,9 +1669,10 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = , > ; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > + resets = <&cpg 724>; > + reset-names = "du.0"; Same comment as for 1/4. > status = "disabled"; > > ports { > diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi > index 1c82dd0abd76c4c9..def840b8b2d3c0c4 100644 > --- a/arch/arm/boot/dts/r8a7744.dtsi > +++ b/arch/arm/boot/dts/r8a7744.dtsi > @@ -1655,9 +1655,10 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = , > ; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > + resets = <&cpg 724>; > + reset-names = "du.0"; > status = "disabled"; > > ports { > diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi > index 3b413658eb8d8fac..7ab58d8bb74010d6 100644 > --- a/arch/arm/boot/dts/r8a7745.dtsi > +++ b/arch/arm/boot/dts/r8a7745.dtsi > @@ -1510,6 +1510,8 @@ > ; > clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > + resets = <&cpg 724>; > + reset-names = "du.0"; > status = "disabled"; > > ports { > diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi > index 6efcef1670e15a95..f5515319227609a4 100644 > --- a/arch/arm/boot/dts/r8a77470.dtsi > +++ b/arch/arm/boot/dts/r8a77470.dtsi > @@ -942,9 +942,10 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = , > ; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > + resets = <&cpg 724>; > + reset-names = "du.0"; > status = "disabled"; > > ports { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101DEC34047 for ; Wed, 19 Feb 2020 15:28:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D15B224654 for ; Wed, 19 Feb 2020 15:28:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XQUSDCSo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SwuUYcaW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D15B224654 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=veyWecPIzwO4SbCtxK1O24OqDIRKTLl6QUIl4fV1nJk=; b=XQUSDCSodcMJcS jxRhkLqiJswqDc/wTncAfHhojnHJ8c0rQLzvWcYpIK5ONwLzaZdp0Sb7SZJSuuq5CGNJ47KAM8BdA O6LAKuIWy+we+QVeTK7uciVvnLQ0vuk9V71V33VopVJJ0QO8LWi58L5XbprALBlWXIwn0wqKqNFwo OJyW6vHncqD/VHjdylTk9bBhmO0z93m4OdOcBetpI2n0tUxsV/TFUHjksNM+k+v/NN7TdRH5lzCak cL82GnhNqKCxKr/qcIkVlmIIPz0TLrhBME++EUMtCEHVrnwEbRsiauO//LPWKFcmyg34N3+hc40fH 4RL4AEB5RgyPw8itlqRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4RH7-00017E-Fe; Wed, 19 Feb 2020 15:28:33 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4RH4-00016r-B7 for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 15:28:31 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7190452B; Wed, 19 Feb 2020 16:28:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582126107; bh=S3hwt9TMlVU5HobaEOMv2lev0QevEyU32s/7zeGqV60=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SwuUYcaWCm3YnE//Co/L6TqBj4PgYw+ftIDyWbzrq0jRZi90EJNqALCUFa6rRyl4j ei2wh/Ch+LjBo00a+jgwl8k+pdFrEPzyhJoYCUS9SacAWr1DqGLDoEg5G38ksZb1L8 q/pYiUl23hrjNle51MAmeMmv555nbLHAX/kKvqpA= Date: Wed, 19 Feb 2020 17:28:08 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Subject: Re: [PATCH v2 2/4] ARM: dts: rzg1: Add reset control properties for display Message-ID: <20200219152808.GS5070@pendragon.ideasonboard.com> References: <20200218133019.22299-1-geert+renesas@glider.be> <20200218133019.22299-3-geert+renesas@glider.be> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200218133019.22299-3-geert+renesas@glider.be> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_072830_530849_535198F9 X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-renesas-soc@vger.kernel.org, Kieran Bingham , Magnus Damm , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, Thank you for the patch. On Tue, Feb 18, 2020 at 02:30:17PM +0100, Geert Uytterhoeven wrote: > Add reset control properties to the devices node for the Display Units > on all supported RZ/G1 SoCs. Note that on these SoCs, there is only a > single reset for all DU channels. > > Join the clocks lines while at it, to increase uniformity. > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - New. > --- > arch/arm/boot/dts/r8a7743.dtsi | 5 +++-- > arch/arm/boot/dts/r8a7744.dtsi | 5 +++-- > arch/arm/boot/dts/r8a7745.dtsi | 2 ++ > arch/arm/boot/dts/r8a77470.dtsi | 5 +++-- > 4 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 1cd19a569bd0fb66..e8b340bb99bc3031 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -1669,9 +1669,10 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = , > ; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > + resets = <&cpg 724>; > + reset-names = "du.0"; Same comment as for 1/4. > status = "disabled"; > > ports { > diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi > index 1c82dd0abd76c4c9..def840b8b2d3c0c4 100644 > --- a/arch/arm/boot/dts/r8a7744.dtsi > +++ b/arch/arm/boot/dts/r8a7744.dtsi > @@ -1655,9 +1655,10 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = , > ; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > + resets = <&cpg 724>; > + reset-names = "du.0"; > status = "disabled"; > > ports { > diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi > index 3b413658eb8d8fac..7ab58d8bb74010d6 100644 > --- a/arch/arm/boot/dts/r8a7745.dtsi > +++ b/arch/arm/boot/dts/r8a7745.dtsi > @@ -1510,6 +1510,8 @@ > ; > clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > + resets = <&cpg 724>; > + reset-names = "du.0"; > status = "disabled"; > > ports { > diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi > index 6efcef1670e15a95..f5515319227609a4 100644 > --- a/arch/arm/boot/dts/r8a77470.dtsi > +++ b/arch/arm/boot/dts/r8a77470.dtsi > @@ -942,9 +942,10 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = , > ; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > + resets = <&cpg 724>; > + reset-names = "du.0"; > status = "disabled"; > > ports { -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel