From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6664C34047 for ; Wed, 19 Feb 2020 16:07:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BB9024670 for ; Wed, 19 Feb 2020 16:07:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VrkdB72G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726756AbgBSQHB (ORCPT ); Wed, 19 Feb 2020 11:07:01 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:37544 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726715AbgBSQHB (ORCPT ); Wed, 19 Feb 2020 11:07:01 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9778A52B; Wed, 19 Feb 2020 17:06:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582128418; bh=rJBM2Gnp8sGsg4UIZMvUb7h2wsW/k0LNeeSa2VfEEa4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VrkdB72GClhJCGPFukl1RsMjTQgw+Uz3H/bdlKKwOevD1SmVjL/yq0IItfutggc1Y npftcZQMgILD6IbF+Xcwtfw7XSq1/Y9PKw36ig7W0hkLlLaQhZUKFDWK4JgbPub+3g SjTC+SMHv04cVImPMuHlNIlvZvjO7f0PfL24RWeo= Date: Wed, 19 Feb 2020 18:06:40 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Magnus Damm , Kieran Bingham , Linux-Renesas , Linux ARM Subject: Re: [PATCH v2 3/4] arm64: dts: renesas: rcar-gen3: Add reset control properties for display Message-ID: <20200219160640.GY5070@pendragon.ideasonboard.com> References: <20200218133019.22299-1-geert+renesas@glider.be> <20200218133019.22299-4-geert+renesas@glider.be> <20200219153339.GT5070@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, On Wed, Feb 19, 2020 at 04:55:52PM +0100, Geert Uytterhoeven wrote: > On Wed, Feb 19, 2020 at 4:33 PM Laurent Pinchart wrote: > > On Tue, Feb 18, 2020 at 02:30:18PM +0100, Geert Uytterhoeven wrote: > > > Add reset control properties to the device nodes for the Display Units > > > on all supported R-Car Gen3 SoCs. Note that on these SoCs, there is > > > only a single reset for each pair of DU channels. > > > > > > The display nodes on R-Car V3M and V3H already had "resets" properties, > > > but lacked the corresponding "reset-names" properties. > > > > > > Join the clocks lines while at it, to increase uniformity. > > > > > > Signed-off-by: Geert Uytterhoeven > > > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > @@ -2503,10 +2503,11 @@ > > > interrupts = , > > > , > > > ; > > > - clocks = <&cpg CPG_MOD 724>, > > > - <&cpg CPG_MOD 723>, > > > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > > > <&cpg CPG_MOD 721>; > > > clock-names = "du.0", "du.1", "du.3"; > > > + resets = <&cpg 724>, <&cpg 722>; > > > + reset-names = "du.0", "du.3"; > > > > I wonder if this should be du.2, especially given that 722 corresponds > > to the non-existing DU2 channel. It's a bit of a mess at the hardware > > Just following the bindings: "du.3" is the lowest channel that is affected > by the reset. Yes I was looking at that, and replied to the DT bindings patch. If the outcome of the discussion there is to keep the bindings as-is, you can have my Reviewed-by: Laurent Pinchart for this whole series. > > level :-S > > Note that supporting R-Car H3-N will make your^H^H^H^Hthe rcar-du device > driver writer's life even more miserable, as suddenly there is no longer > a DU2, while the single unified Display Unit node prevents the DTS > writer from not setting the DU2's status to "okay" in the board DTS > file. But you might look at the ports submode? This will require a separate compatible string I'm afraid. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA83C34047 for ; Wed, 19 Feb 2020 16:07:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F35FE24670 for ; Wed, 19 Feb 2020 16:07:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a1zWwS1O"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VrkdB72G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F35FE24670 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6AKZc6KvSAsJeq+CoBaZZ4nokjPXEeSx7EyZZrmVbwo=; b=a1zWwS1OIokEqk wT7NAoBkvOGJjSgWfZk5MxJP70IIl3pAGExM+AakXER/fm7nfz3epPjXJxL6/s8TRbAB2i4Dm3Fhn zKziDUoPpDNQpyTmBnah5kjqeTXLxPrnD3wTCssQNaEixrJJPhcytfIHlDpePaId8FjUq296UGaPu hyIcXGNQCsPgQzxzYPxtQ2ae9XqWTiTLiMxOW5tpcvGfwJ1pCxzV4iFRt7WjFV3FD0vylcTiZosUH 7Jp4jEZJiPPrksW3JxO5ci+apOse/RDV5hki7TvEF9DWYHHwWUljSAZMN+14IPdW+Vzwt0iFzHugG nkP0OahELcaGWqkEgMzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4RsN-0002DK-4M; Wed, 19 Feb 2020 16:07:03 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4RsK-0002Cp-II for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 16:07:01 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9778A52B; Wed, 19 Feb 2020 17:06:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582128418; bh=rJBM2Gnp8sGsg4UIZMvUb7h2wsW/k0LNeeSa2VfEEa4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VrkdB72GClhJCGPFukl1RsMjTQgw+Uz3H/bdlKKwOevD1SmVjL/yq0IItfutggc1Y npftcZQMgILD6IbF+Xcwtfw7XSq1/Y9PKw36ig7W0hkLlLaQhZUKFDWK4JgbPub+3g SjTC+SMHv04cVImPMuHlNIlvZvjO7f0PfL24RWeo= Date: Wed, 19 Feb 2020 18:06:40 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Subject: Re: [PATCH v2 3/4] arm64: dts: renesas: rcar-gen3: Add reset control properties for display Message-ID: <20200219160640.GY5070@pendragon.ideasonboard.com> References: <20200218133019.22299-1-geert+renesas@glider.be> <20200218133019.22299-4-geert+renesas@glider.be> <20200219153339.GT5070@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_080700_756370_9C0D797E X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-Renesas , Kieran Bingham , Magnus Damm , Linux ARM , Geert Uytterhoeven Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, On Wed, Feb 19, 2020 at 04:55:52PM +0100, Geert Uytterhoeven wrote: > On Wed, Feb 19, 2020 at 4:33 PM Laurent Pinchart wrote: > > On Tue, Feb 18, 2020 at 02:30:18PM +0100, Geert Uytterhoeven wrote: > > > Add reset control properties to the device nodes for the Display Units > > > on all supported R-Car Gen3 SoCs. Note that on these SoCs, there is > > > only a single reset for each pair of DU channels. > > > > > > The display nodes on R-Car V3M and V3H already had "resets" properties, > > > but lacked the corresponding "reset-names" properties. > > > > > > Join the clocks lines while at it, to increase uniformity. > > > > > > Signed-off-by: Geert Uytterhoeven > > > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > @@ -2503,10 +2503,11 @@ > > > interrupts = , > > > , > > > ; > > > - clocks = <&cpg CPG_MOD 724>, > > > - <&cpg CPG_MOD 723>, > > > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > > > <&cpg CPG_MOD 721>; > > > clock-names = "du.0", "du.1", "du.3"; > > > + resets = <&cpg 724>, <&cpg 722>; > > > + reset-names = "du.0", "du.3"; > > > > I wonder if this should be du.2, especially given that 722 corresponds > > to the non-existing DU2 channel. It's a bit of a mess at the hardware > > Just following the bindings: "du.3" is the lowest channel that is affected > by the reset. Yes I was looking at that, and replied to the DT bindings patch. If the outcome of the discussion there is to keep the bindings as-is, you can have my Reviewed-by: Laurent Pinchart for this whole series. > > level :-S > > Note that supporting R-Car H3-N will make your^H^H^H^Hthe rcar-du device > driver writer's life even more miserable, as suddenly there is no longer > a DU2, while the single unified Display Unit node prevents the DTS > writer from not setting the DU2's status to "okay" in the board DTS > file. But you might look at the ports submode? This will require a separate compatible string I'm afraid. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel