From: Keith Busch <kbusch@kernel.org>
To: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de
Cc: Keith Busch <kbusch@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] nvme: Fix uninitialized-variable warning
Date: Thu, 20 Feb 2020 01:19:50 +0900 [thread overview]
Message-ID: <20200219161950.14460-1-kbusch@kernel.org> (raw)
gcc may detect a false positive on nvme using an unintialized variable
if setting features fails. Since this is not a fast path, explicitly
initialize this variable to suppress the warning.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index ada59df642d2..a4d8c90ee7cc 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1165,8 +1165,8 @@ static int nvme_identify_ns(struct nvme_ctrl *ctrl,
static int nvme_features(struct nvme_ctrl *dev, u8 op, unsigned int fid,
unsigned int dword11, void *buffer, size_t buflen, u32 *result)
{
+ union nvme_result res = { 0 };
struct nvme_command c;
- union nvme_result res;
int ret;
memset(&c, 0, sizeof(c));
--
2.21.0
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2020-02-19 16:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 16:19 Keith Busch [this message]
2020-02-19 16:22 ` [PATCH] nvme: Fix uninitialized-variable warning Christoph Hellwig
2020-02-20 7:43 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2020-01-07 21:42 [PATCH] nvme: fix " Arnd Bergmann
2020-01-07 21:42 ` Arnd Bergmann
2020-01-30 15:04 ` Christoph Hellwig
2020-01-30 15:04 ` Christoph Hellwig
2020-01-30 15:36 ` Arnd Bergmann
2020-01-30 15:36 ` Arnd Bergmann
2020-01-30 15:48 ` Christoph Hellwig
2020-01-30 15:48 ` Christoph Hellwig
2020-02-13 19:51 ` Keith Busch
2020-02-13 19:51 ` Keith Busch
2020-02-19 15:21 ` Christoph Hellwig
2020-02-19 15:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219161950.14460-1-kbusch@kernel.org \
--to=kbusch@kernel.org \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.