From: Christoph Hellwig <hch@infradead.org>
To: Coly Li <colyli@suse.de>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/3] bcache: move macro btree() and btree_root() into btree.h
Date: Wed, 19 Feb 2020 08:29:45 -0800 [thread overview]
Message-ID: <20200219162945.GD10644@infradead.org> (raw)
In-Reply-To: <20200215082858.128025-2-colyli@suse.de>
On Sat, Feb 15, 2020 at 04:28:56PM +0800, Coly Li wrote:
> In order to accelerate bcache registration speed, the macro btree()
> and btree_root() will be referenced out of btree.c. This patch moves
> them from btree.c into btree.h with other relative function declaration
> in btree.h, for the following changes.
Can you give them a bcache_ prefix? That names are awfully generic
and bound to clash sooner or later.
next prev parent reply other threads:[~2020-02-19 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 8:28 [RFC PATCH 0/3] bcache: accelerate device registration speed Coly Li
2020-02-15 8:28 ` [PATCH 1/3] bcache: move macro btree() and btree_root() into btree.h Coly Li
2020-02-19 16:29 ` Christoph Hellwig [this message]
2020-02-20 13:21 ` Coly Li
2020-02-15 8:28 ` [PATCH 2/3] bcache: make bch_btree_check() to be multiple threads Coly Li
2020-02-19 16:30 ` Christoph Hellwig
2020-02-20 13:21 ` Coly Li
2020-02-15 8:28 ` [PATCH 3/3] bcache: make bch_sectors_dirty_init() " Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219162945.GD10644@infradead.org \
--to=hch@infradead.org \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.