From: Mike Rapoport <rppt@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Baoquan He <bhe@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Wei Yang <richardw.yang@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v2 RESEND] mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM
Date: Wed, 19 Feb 2020 19:31:35 +0100 [thread overview]
Message-ID: <20200219183135.GA10266@linux.ibm.com> (raw)
In-Reply-To: <CAPcyv4isoKSo2TtP3_VzdPQwdfc2O=KAv44LkqSSTccP7Cnh7A@mail.gmail.com>
On Wed, Feb 19, 2020 at 08:37:25AM -0800, Dan Williams wrote:
> On Wed, Feb 19, 2020 at 12:57 AM Mike Rapoport <rppt@linux.ibm.com> wrote:
> >
> > On Tue, Feb 18, 2020 at 07:25:15PM -0800, Dan Williams wrote:
> > > On Tue, Feb 18, 2020 at 7:05 PM Baoquan He <bhe@redhat.com> wrote:
> > > >
> > > > From: Wei Yang <richardw.yang@linux.intel.com>
> > > >
> > > > When we use SPARSEMEM instead of SPARSEMEM_VMEMMAP, pfn_to_page()
> > > > doesn't work before sparse_init_one_section() is called. This leads to a
> > > > crash when hotplug memory:
> > >
> > > I'd also add:
> > >
> > > "On x86 the impact is limited to x86_32 builds, or x86_64
> > > configurations that override the default setting for
> > > SPARSEMEM_VMEMMAP".
> >
> > Do we also want to check how it affects, say, arm64, ia64 and ppc? ;-)
>
> Sure, I just did not take the time to look up their respective default
> stances on SPARSEMEM_VMEMMAP. For a distro looking to backport this
> commit I think it's helpful for them to understand if they are exposed
> or not.
Looks like only i386_defconfig does not enable SPARSEMEM_VMEMMAP. All the
rest may have it disabled only with manual override.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-02-19 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 3:04 [PATCH v2 RESEND] mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM Baoquan He
2020-02-19 3:25 ` Dan Williams
2020-02-19 3:46 ` Baoquan He
2020-02-19 8:57 ` Mike Rapoport
2020-02-19 16:37 ` Dan Williams
2020-02-19 18:31 ` Mike Rapoport [this message]
2020-02-19 19:50 ` Andrew Morton
2020-02-19 20:13 ` Dan Williams
2020-02-19 21:45 ` Wei Yang
2020-02-19 23:55 ` Baoquan He
2020-02-20 10:41 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219183135.GA10266@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.